Page MenuHomePhabricator

Open Tasks

Unbreak Now! (1)

Recent Activity

Yesterday

ioannisg added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

TF-M currently support "-mfloat-abi=soft" as default, but doesn't support the setting in Zephyr "-mfloat-abi=softfp". Because they are totally different things.

Thu, May 13, 5:56 PM · Trusted Firmware M
nullr0ute added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Thanks, I submitted the following based on CJKay's patch above:
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/9990

Thu, May 13, 11:15 AM · Trusted Firmware A
federliangarm added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

This is the explanation for "FP_SOFTABI" in Zephyr.
"config FP_SOFTABI
bool "Floating point Soft ABI"
help

	  This option selects the Floating point ABI in which hardware floating
	  point instructions are generated but soft-float calling conventions."
Thu, May 13, 9:28 AM · Trusted Firmware M
ioannisg added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

Yes, it crashes even without Lazy Stacking. It is a bit more deterministic as is. It crashes in the first secure exception entry, after the transition to secure domain from non-secure.

Thu, May 13, 8:26 AM · Trusted Firmware M
ioannisg added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

But for Zephyr, are you using soft FP or hardware FP?

Thu, May 13, 8:12 AM · Trusted Firmware M
federliangarm added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

The first thing I want to confirm is "I compile zephyr and Tf-M with soft FP". As you know, TF-M is default with soft FP.

  1. But for Zephyr, are you using soft FP or hardware FP?
  2. Is it possible for you to share the compile options and linker options for the source file including the "Non-Secure interrupt" crashing?
  3. Is it possible to show the assembly code for the "Non-Secure interrupt"?
Thu, May 13, 1:35 AM · Trusted Firmware M

Wed, May 12

ioannisg added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

Hi Feder,

Wed, May 12, 12:36 PM · Trusted Firmware M

Tue, May 11

yuezhiran closed T868: TF-A Bug as Resolved.

The problem has been solved.

Tue, May 11, 1:40 PM · TF-A Bug, Trusted Firmware A
federliangarm added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

If you didn't change TF-M while integrating into your project, PSA call(handler mode) cannot be interrupted by non-secure interrupt like you mentioned, the reason is non-secure exceptions are de-prioritized (AIRCR.PRIS = 1) in TF-M.
Non-secure interrupt can only be active when system in thread mode.

Tue, May 11, 8:01 AM · Trusted Firmware M

Fri, May 7

Sherryzhang2 added a comment to T923: PS relies on linking ITS library to get its definition.

Hi Alamy,

Fri, May 7, 9:03 AM
KenLSoft closed T911: Build warnings as Resolved.
Fri, May 7, 2:32 AM · Trusted Firmware M
KenLSoft added a comment to T911: Build warnings.

Merged.

Fri, May 7, 2:32 AM · Trusted Firmware M

Thu, May 6

davidwang added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

Hi @ioannisg,
FYI. Feder is on holiday and will back to office on 10th May.
Thanks.

Thu, May 6, 6:05 AM · Trusted Firmware M

Wed, May 5

jwerner added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Yes, the __sramdata in the declaration is a mistake, the correct target section for that global needs to be .pmusram.data. This used to be in .sram.data once upon a time but then the suspend.c stuff got added and required it to be moved to PMUSRAM. I guess they forgot to update that part in the declaration and since the old GCC seemed to silently prefer the attribute in the definition, nobody noticed. Please apply CJKay's first patch to fix the warning.

Wed, May 5, 5:52 PM · Trusted Firmware A
CJKay added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

I can only assume GCC <11 simply didn't have this warning, but it looks legitimate.

Wed, May 5, 1:14 PM · Trusted Firmware A
odeprez added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Ok thanks.

Wed, May 5, 12:35 PM · Trusted Firmware A
nullr0ute added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

It's native aarch64, the command line I'm using is:
make HOSTCC="gcc $RPM_OPT_FLAGS" CROSS_COMPILE="" PLAT=rk3399 bl31

Wed, May 5, 10:03 AM · Trusted Firmware A
odeprez added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Is this building natively on arm64 host?

Wed, May 5, 9:31 AM · Trusted Firmware A
nullr0ute added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

I'm using Fedora 34/35 with the distribution toolchain (gcc 11.1 GA)

Wed, May 5, 9:26 AM · Trusted Firmware A
odeprez added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Can you please provide the link to the gcc11 toolchain you use?
AFAIK latest public Arm release of the cross compiler toolchains is 10.2 (https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-a/downloads)

Wed, May 5, 9:19 AM · Trusted Firmware A

Tue, May 4

nullr0ute created T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.
Tue, May 4, 9:08 PM · Trusted Firmware A
andvib created T924: Protected Storage Non-Secure Client Identification test cases failing.
Tue, May 4, 2:54 PM · Trusted Firmware M

Mon, May 3

ioannisg triaged T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU as High priority.

Setting this to High for now - but feel free to re-triage this was not appropriate.

Mon, May 3, 8:21 AM · Trusted Firmware M
ioannisg added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

Hi Feder,

Mon, May 3, 8:04 AM · Trusted Firmware M

Fri, Apr 30

federliangarm added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

For the concern you mentioned, yes, we need to add extra steps in secure scheduler, I am still working on this part.

  1. When secure doing secure calls: a. if lazy fp is disabled, hardware will push/pop FP context automatically during exception entry/return. b. if lazy fp is enable, for isolation 1, secure scheduler will save and restore FP context, but not invalidate FP context; for isolation 2 and 3, secure scheduler will trigger lazy fp stacking, hardware will push FP context to thread' stack and invalidate them automatically.
  2. When non-secure doing secure calls, non-secure side will SG to secure world in tfm_nspm_thread_entry, then doing secure calls as same as above. FP context of non-secure can be restored when bxns lr to non-secure side.
Fri, Apr 30, 3:57 AM · Trusted Firmware M

Thu, Apr 29

gyuri-szing added a comment to T922: cmake: TF-M documentation build issue.

At a quick glance this seems to be an m2r bug: https://github.com/sphinx-doc/sphinx/issues/8705. m2r seems to be abandoned, switching to m2r2 might be a workaround, as that seems to have a fix merged.
For now the best might be to stick to the documented package versions. I am wondering if the requirements file should be more strict on Spninx version.

Thu, Apr 29, 8:06 AM · Restricted Project
davidhuziji reassigned T923: PS relies on linking ITS library to get its definition from davidhuziji to Sherryzhang2.
Thu, Apr 29, 7:12 AM
AlamyLiu triaged T923: PS relies on linking ITS library to get its definition as Normal priority.
Thu, Apr 29, 7:10 AM
AndreyButokNXP added a comment to T922: cmake: TF-M documentation build issue.

Hi Minos,
Is this a compatibility issue and the TFM doc build system can be upgraded, or this a bug in the latest version of Sphinx?

Thu, Apr 29, 5:47 AM · Restricted Project

Wed, Apr 28

MartinaHanusovaNXP added a comment to T922: cmake: TF-M documentation build issue.

Hi Minos,

Wed, Apr 28, 3:55 PM · Restricted Project
minosgalanakis added a comment to T922: cmake: TF-M documentation build issue.

Hi Martina.

Wed, Apr 28, 1:26 PM · Restricted Project
MartinaHanusovaNXP triaged T922: cmake: TF-M documentation build issue as Low priority.
Wed, Apr 28, 10:30 AM · Restricted Project
davidwang reassigned T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU from Anton-TF to federliangarm.
Wed, Apr 28, 2:23 AM · Trusted Firmware M

Tue, Apr 27

ioannisg created T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.
Tue, Apr 27, 9:12 AM · Trusted Firmware M

Wed, Apr 21

shebuk edited the content of Roadmap.
Wed, Apr 21, 10:14 AM
KenLSoft added a comment to T911: Build warnings.

The first patch for this:
https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/9730

Wed, Apr 21, 9:49 AM · Trusted Firmware M
davidhuziji added a comment to T911: Build warnings.

Currently GNU 10-2020-q4-major cannot support CMSE well (https://git.trustedfirmware.org/TF-M/trusted-firmware-m.git/tree/docs/getting_started/tfm_sw_requirement.rst#n54).
So this GNU version won't be supported in TF-M.

Wed, Apr 21, 9:46 AM · Trusted Firmware M

Mon, Apr 19

shebuk edited the content of Roadmap.
Mon, Apr 19, 2:41 PM
shebuk edited the content of Trusted Services.
Mon, Apr 19, 2:41 PM · Restricted Project
shebuk created an object: Roadmap.
Mon, Apr 19, 2:40 PM