Page MenuHomePhabricator

mpam_supported wrong register
Closed, ResolvedPublic

Description

Hi,

while working with the MPAM extension, I noticed that in the lib/extensions/mpam/mpam.c file there is a mistake when accessing the feature register inside the mpam_supported() function. In particular the read_id_aa64dfr0_el1 register is accessed instead of the read_id_aa64pfr0_el1 register, where the bits regarding the availability of MPAM are.
I hope my assumption is correct and this is the right place to report it.

Regards and thank you in advance.
Matteo

Event Timeline

Scimmiaparlante updated the task description. (Show Details)
AlexeiFedorov added a subscriber: AlexeiFedorov.EditedSun, May 10, 12:18 PM

Hello Matteo,
Yes, you are right ID_AA64PFR0_EL1 must be used. Thanks for spotting this!

Please review the patch:
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/4038

Regards.
Alexei.

Scimmiaparlante closed this task as Resolved.Thu, May 28, 7:42 AM
Scimmiaparlante removed Scimmiaparlante as the assignee of this task.