Page MenuHomePhabricator
Feed All Stories

Yesterday

ioannisg added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

TF-M currently support "-mfloat-abi=soft" as default, but doesn't support the setting in Zephyr "-mfloat-abi=softfp". Because they are totally different things.

Thu, May 13, 5:56 PM · Trusted Firmware M
nullr0ute added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Thanks, I submitted the following based on CJKay's patch above:
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/9990

Thu, May 13, 11:15 AM · Trusted Firmware A
federliangarm added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

This is the explanation for "FP_SOFTABI" in Zephyr.
"config FP_SOFTABI
bool "Floating point Soft ABI"
help

	  This option selects the Floating point ABI in which hardware floating
	  point instructions are generated but soft-float calling conventions."
Thu, May 13, 9:28 AM · Trusted Firmware M
ioannisg added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

Yes, it crashes even without Lazy Stacking. It is a bit more deterministic as is. It crashes in the first secure exception entry, after the transition to secure domain from non-secure.

Thu, May 13, 8:26 AM · Trusted Firmware M
ioannisg added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

But for Zephyr, are you using soft FP or hardware FP?

Thu, May 13, 8:12 AM · Trusted Firmware M
federliangarm added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

The first thing I want to confirm is "I compile zephyr and Tf-M with soft FP". As you know, TF-M is default with soft FP.

  1. But for Zephyr, are you using soft FP or hardware FP?
  2. Is it possible for you to share the compile options and linker options for the source file including the "Non-Secure interrupt" crashing?
  3. Is it possible to show the assembly code for the "Non-Secure interrupt"?
Thu, May 13, 1:35 AM · Trusted Firmware M

Wed, May 12

ioannisg added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

Hi Feder,

Wed, May 12, 12:36 PM · Trusted Firmware M

Tue, May 11

yuezhiran closed T868: TF-A Bug as Resolved.

The problem has been solved.

Tue, May 11, 1:40 PM · TF-A Bug, Trusted Firmware A
federliangarm added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

If you didn't change TF-M while integrating into your project, PSA call(handler mode) cannot be interrupted by non-secure interrupt like you mentioned, the reason is non-secure exceptions are de-prioritized (AIRCR.PRIS = 1) in TF-M.
Non-secure interrupt can only be active when system in thread mode.

Tue, May 11, 8:01 AM · Trusted Firmware M

Fri, May 7

Sherryzhang2 added a comment to T923: PS relies on linking ITS library to get its definition.

Hi Alamy,

Fri, May 7, 9:03 AM
KenLSoft closed T911: Build warnings as Resolved.
Fri, May 7, 2:32 AM · Trusted Firmware M
KenLSoft added a comment to T911: Build warnings.

Merged.

Fri, May 7, 2:32 AM · Trusted Firmware M

Thu, May 6

davidwang added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

Hi @ioannisg,
FYI. Feder is on holiday and will back to office on 10th May.
Thanks.

Thu, May 6, 6:05 AM · Trusted Firmware M

Wed, May 5

jwerner added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Yes, the __sramdata in the declaration is a mistake, the correct target section for that global needs to be .pmusram.data. This used to be in .sram.data once upon a time but then the suspend.c stuff got added and required it to be moved to PMUSRAM. I guess they forgot to update that part in the declaration and since the old GCC seemed to silently prefer the attribute in the definition, nobody noticed. Please apply CJKay's first patch to fix the warning.

Wed, May 5, 5:52 PM · Trusted Firmware A
CJKay added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

I can only assume GCC <11 simply didn't have this warning, but it looks legitimate.

Wed, May 5, 1:14 PM · Trusted Firmware A
odeprez added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Ok thanks.

Wed, May 5, 12:35 PM · Trusted Firmware A
nullr0ute added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

It's native aarch64, the command line I'm using is:
make HOSTCC="gcc $RPM_OPT_FLAGS" CROSS_COMPILE="" PLAT=rk3399 bl31

Wed, May 5, 10:03 AM · Trusted Firmware A
odeprez added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Is this building natively on arm64 host?

Wed, May 5, 9:31 AM · Trusted Firmware A
nullr0ute added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

I'm using Fedora 34/35 with the distribution toolchain (gcc 11.1 GA)

Wed, May 5, 9:26 AM · Trusted Firmware A
odeprez added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Can you please provide the link to the gcc11 toolchain you use?
AFAIK latest public Arm release of the cross compiler toolchains is 10.2 (https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-a/downloads)

Wed, May 5, 9:19 AM · Trusted Firmware A

Tue, May 4

nullr0ute created T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.
Tue, May 4, 9:08 PM · Trusted Firmware A
andvib created T924: Protected Storage Non-Secure Client Identification test cases failing.
Tue, May 4, 2:54 PM · Trusted Firmware M

Mon, May 3

ioannisg triaged T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU as High priority.

Setting this to High for now - but feel free to re-triage this was not appropriate.

Mon, May 3, 8:21 AM · Trusted Firmware M
ioannisg added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

Hi Feder,

Mon, May 3, 8:04 AM · Trusted Firmware M

Fri, Apr 30

federliangarm added a comment to T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.

For the concern you mentioned, yes, we need to add extra steps in secure scheduler, I am still working on this part.

  1. When secure doing secure calls: a. if lazy fp is disabled, hardware will push/pop FP context automatically during exception entry/return. b. if lazy fp is enable, for isolation 1, secure scheduler will save and restore FP context, but not invalidate FP context; for isolation 2 and 3, secure scheduler will trigger lazy fp stacking, hardware will push FP context to thread' stack and invalidate them automatically.
  2. When non-secure doing secure calls, non-secure side will SG to secure world in tfm_nspm_thread_entry, then doing secure calls as same as above. FP context of non-secure can be restored when bxns lr to non-secure side.
Fri, Apr 30, 3:57 AM · Trusted Firmware M

Thu, Apr 29

gyuri-szing added a comment to T922: cmake: TF-M documentation build issue.

At a quick glance this seems to be an m2r bug: https://github.com/sphinx-doc/sphinx/issues/8705. m2r seems to be abandoned, switching to m2r2 might be a workaround, as that seems to have a fix merged.
For now the best might be to stick to the documented package versions. I am wondering if the requirements file should be more strict on Spninx version.

Thu, Apr 29, 8:06 AM · Restricted Project
davidhuziji reassigned T923: PS relies on linking ITS library to get its definition from davidhuziji to Sherryzhang2.
Thu, Apr 29, 7:12 AM
AlamyLiu triaged T923: PS relies on linking ITS library to get its definition as Normal priority.
Thu, Apr 29, 7:10 AM
AndreyButokNXP added a comment to T922: cmake: TF-M documentation build issue.

Hi Minos,
Is this a compatibility issue and the TFM doc build system can be upgraded, or this a bug in the latest version of Sphinx?

Thu, Apr 29, 5:47 AM · Restricted Project

Wed, Apr 28

MartinaHanusovaNXP added a comment to T922: cmake: TF-M documentation build issue.

Hi Minos,

Wed, Apr 28, 3:55 PM · Restricted Project
minosgalanakis added a comment to T922: cmake: TF-M documentation build issue.

Hi Martina.

Wed, Apr 28, 1:26 PM · Restricted Project
MartinaHanusovaNXP triaged T922: cmake: TF-M documentation build issue as Low priority.
Wed, Apr 28, 10:30 AM · Restricted Project
davidwang reassigned T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU from Anton-TF to federliangarm.
Wed, Apr 28, 2:23 AM · Trusted Firmware M

Tue, Apr 27

ioannisg created T921: Supporting Non-Secure RTOS applications, integrated with Trusted Firmware-M, which want to use the FPU.
Tue, Apr 27, 9:12 AM · Trusted Firmware M

Wed, Apr 21

shebuk edited the content of Roadmap.
Wed, Apr 21, 10:14 AM
KenLSoft added a comment to T911: Build warnings.

The first patch for this:
https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/9730

Wed, Apr 21, 9:49 AM · Trusted Firmware M
davidhuziji added a comment to T911: Build warnings.

Currently GNU 10-2020-q4-major cannot support CMSE well (https://git.trustedfirmware.org/TF-M/trusted-firmware-m.git/tree/docs/getting_started/tfm_sw_requirement.rst#n54).
So this GNU version won't be supported in TF-M.

Wed, Apr 21, 9:46 AM · Trusted Firmware M

Mon, Apr 19

shebuk edited the content of Roadmap.
Mon, Apr 19, 2:41 PM
shebuk edited the content of Trusted Services.
Mon, Apr 19, 2:41 PM · Restricted Project
shebuk created an object: Roadmap.
Mon, Apr 19, 2:40 PM

Apr 13 2021

shebuk edited the content of Roadmap.
Apr 13 2021, 3:29 PM
shebuk edited the content of Roadmap.
Apr 13 2021, 2:44 PM
shebuk edited the content of Trusted Firmware M.
Apr 13 2021, 1:19 PM
shebuk edited the content of TF-M Videos.
Apr 13 2021, 12:21 PM · Trusted Firmware M
shebuk created an object: Linaro Virtual Connect 2021.
Apr 13 2021, 12:20 PM

Apr 12 2021

zoescott25 updated zoescott25.
Apr 12 2021, 10:17 AM
oyvindronningstad added a comment to T911: Build warnings.

I built with

Apr 12 2021, 7:21 AM · Trusted Firmware M
KenLSoft added a comment to T911: Build warnings.

I will run the GCC version later to check if there are more warnings. Will collect all the warnings and fix them in one shot later.

Apr 12 2021, 5:41 AM · Trusted Firmware M
KenLSoft added a comment to T911: Build warnings.

Would fix after the release. Mark as a long term goal.

Apr 12 2021, 5:10 AM · Trusted Firmware M

Apr 7 2021

adrianlshaw added a comment to Twin-cpu.

Hi Martin. I was referring to PSA FF-M, not FF-A. See the spec here, in Section 2.1. TF-A conforms to FF-A, which is a different spec.

Apr 7 2021, 1:37 PM
MartinSchoenstedt added a comment to Twin-cpu.

Thanks @adrianlshaw for your comment. A multi-core TF-M design is indeed a different thing than this twin-cpu design or any of the implemented designs for multiple CPUs in TF-M.
Do I understand you correctly, that such a multi-core TF-M design would not be possible to design according to PSA FF-A guidelines, because no mutex is defined in these?
How is this problem handled in TF-A as the same PSA guidelines apply there?

I somehow messed up the two files and got confused

Apr 7 2021, 1:28 PM
Karl added a comment to T910: Interactive tests fail to return to main thread after test has ran and sit in osRtxIdleThread() function.

Okay, I run into a fault when apply this patch on AN521, may need some investigations :
Running Test Suite Core non-secure interactive tests (TFM_CORE_TEST_2XXX)...

Executing 'TFM_CORE_TEST_2001'

Description: 'Interactive tests'

Segmentation fault

Apr 7 2021, 7:02 AM · Trusted Firmware M
lairdjm added a comment to T910: Interactive tests fail to return to main thread after test has ran and sit in osRtxIdleThread() function.

You will need to apply this patch in order for the interactive tests to function as without it the secure part will never build with that part enabled https://review.trustedfirmware.org/c/TF-M/tf-m-tests/+/9431
After applying that and building using:

cmake -DTFM_PLATFORM=lairdconnectivity/bl5340_dvk_cpuapp -GNinja -DTFM_TOOLCHAIN_FILE=../toolchain_GNUARM.cmake -DTEST_S=off -DTEST_NS=on -DCMAKE_BUILD_TYPE=debug -DTFM_INTERACTIVE_TEST=on -DTFM_PERIPH_ACCESS_TEST=ON -DTFM_IRQ_TEST=ON ..

And running it, the first test passes but the freezes at the same point as yours does, it does not continue with the next task

Apr 7 2021, 6:44 AM · Trusted Firmware M
Karl claimed T910: Interactive tests fail to return to main thread after test has ran and sit in osRtxIdleThread() function.

I took a look at this test case, the interactive test suit is disabled by default. Could you append some logs or command on your platform of TFM_CORE_TEST_2001
The test from my side on AN521 will stop after scenario 1:

Executing 'TFM_CORE_TEST_2001'

Description: 'Interactive tests'

Scenario 1 - SequentialTrying to acquire the TFM core from NS [seq_task]NS Lock: acquired [seq_task]Secure call to tfm_spm_core_test_sfn_veneer(&in_vec, 1, NULL, 0) failed, generic!NS Lock: releasing... [seq_task]Scenario 1 - test finished

Apr 7 2021, 6:41 AM · Trusted Firmware M

Apr 6 2021

adrianlshaw added a comment to Twin-cpu.

If the NSPE can use all the ARMv8-M processors, then it makes sense to use a model similar to ARMv8-A. In that model, the request for a secure service is usually handled by the local core - no cross core interaction.

Apr 6 2021, 3:34 PM
davidhuziji added a comment to Twin-cpu.

Imo, the implementation can be very platform specific. It is required that the two cores shall be physically isolated.
Besides, when NS requires secure services on the other core, the other core must runs in S world. It is a bit difficult to guarantee.

Apr 6 2021, 2:33 PM
MartinSchoenstedt added a comment to Twin-cpu.

The concept I am working on would allow for execution of two NS environments both with access to TF-M services. The goal is also to isolate the NS environments from one another to provide safety in case of failure / maliciousness of one NS env. But this safety feature is not necessary for the use case of two Cortex M-33 with NS + TF-M.

Apr 6 2021, 9:50 AM
Sherryzhang2 added a comment to T918: Issues with alignment and buffer locations.

@oyvind.ronningstad@nordicsemi.no This issue is on the Nordic platform. Can you take a look at it?

Apr 6 2021, 9:26 AM · Trusted Firmware M
lairdjm created T920: Cryptocell CC312 does not work on Nordic nRF5340.
Apr 6 2021, 8:56 AM
davidwang assigned T910: Interactive tests fail to return to main thread after test has ran and sit in osRtxIdleThread() function to karl-zh.
Apr 6 2021, 3:06 AM · Trusted Firmware M
davidwang added a comment to T911: Build warnings.

Assigned to Ken for the warning fix.

Apr 6 2021, 3:01 AM · Trusted Firmware M
davidwang reassigned T911: Build warnings from davidwang to KenLSoft.
Apr 6 2021, 3:01 AM · Trusted Firmware M
davidhuziji added a comment to Twin-cpu.

@MartinSchoenstedt so are you trying to run Non-secure OS + TF-M on both MPS2 AN521 cores?
Are you designing a SMP (symmetric multiprocessing) system for both NS and S? May I know the benefit to run NS + TF-M on both cores, compared to running a single Cortex-M33?

Apr 6 2021, 1:42 AM

Apr 5 2021

ta9ya closed T916: The Assert State for Checking PSCI_INVALID_DATA dose not work, dose it? as Resolved.

I solved this issue by myself.
The assert state works normally.

Apr 5 2021, 12:40 AM · TF-A Question

Apr 3 2021

elmadavis added a comment to T885: What is a Minimum Viable Product (MVP) and what is its use in app development?.
Apr 3 2021, 7:55 AM

Apr 2 2021

MartinSchoenstedt added a comment to Twin-cpu.

Yes this was indeed what I was thinking about. I am now trying to modify the secure enclave implementation to work with both CPUs in the SSE 200 on the MPS2 AN521 image. This would also also both cores to still be used by nonsecure OS / applications

Apr 2 2021, 8:07 PM
adrianlshaw added a comment to Twin-cpu.

Hi David. What about a scenario where non-secure applications want to use both cores? I think this is what Martin is asking about. Dedicating one M33 to act as a secure enclave can be considered a waste of compute resource (it will be idle most of the time).

Apr 2 2021, 5:32 PM
KenLSoft created T918: Issues with alignment and buffer locations.
Apr 2 2021, 12:39 AM · Trusted Firmware M

Apr 1 2021

gyuri-szing created T917: cmake: change install rules to use GNUInstallDirs..
Apr 1 2021, 12:24 PM · Restricted Project
ta9ya created T916: The Assert State for Checking PSCI_INVALID_DATA dose not work, dose it?.
Apr 1 2021, 7:50 AM · TF-A Question
davidhuziji updated subscribers of T910: Interactive tests fail to return to main thread after test has ran and sit in osRtxIdleThread() function.
Apr 1 2021, 2:48 AM · Trusted Firmware M
davidhuziji added a project to T910: Interactive tests fail to return to main thread after test has ran and sit in osRtxIdleThread() function: Trusted Firmware M.
Apr 1 2021, 2:47 AM · Trusted Firmware M

Mar 31 2021

gyuri-szing renamed T893: User and system includes are not consistent. from User ar system includes are not consistent. to User and system includes are not consistent..
Mar 31 2021, 3:05 PM · Restricted Project
imre-kis-arm added a project to T915: Implement FF-A Direct Message Routing Extension: Restricted Project.
Mar 31 2021, 2:47 PM · Restricted Project
imre-kis-arm created T915: Implement FF-A Direct Message Routing Extension.
Mar 31 2021, 2:46 PM · Restricted Project
gyuri-szing created an object: Design.
Mar 31 2021, 12:18 PM · Restricted Project
balintdobszay created T914: SPM: unmap FIP SP image after loading.
Mar 31 2021, 8:35 AM · Restricted Project
gyuri-szing created T913: CppUtest features are limited on arm-linux builds..
Mar 31 2021, 7:31 AM · Restricted Project

Mar 30 2021

nathan-menhorn created T912: OP-TEE OS 3.11.0 Hangs at opteed_enter_sp on Cold Boot.
Mar 30 2021, 4:11 PM · TF-A Bug, Trusted Firmware A
maulik-arm edited the content of Psa Arch Crypto Test Failure Analysis In Tf-m V1.3 Release.
Mar 30 2021, 10:43 AM
maulik-arm edited the content of Psa Arch Crypto Test Failure Analysis In Tf-m V1.3 Release.
Mar 30 2021, 9:54 AM
davidhuziji added a comment to T911: Build warnings.

I will run the GCC version later to check if there are more warnings. Will collect all the warnings and fix them in one shot later.

Mar 30 2021, 8:06 AM · Trusted Firmware M
davidhuziji added a project to T911: Build warnings: Trusted Firmware M.
Mar 30 2021, 8:03 AM · Trusted Firmware M
oyvindronningstad added a comment to T911: Build warnings.

Makes sense :)
Here is the GCC version output:

$arm-zephyr-eabi-gcc --version
arm-zephyr-eabi-gcc (crosstool-NG 1.24.0.212_d7da3a9) 10.2.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Mar 30 2021, 7:48 AM · Trusted Firmware M
Summer-ARM edited the content of Psa Arch Crypto Test Failure Analysis In Tf-m V1.3 Release.
Mar 30 2021, 6:51 AM
davidhuziji added a comment to T911: Build warnings.

It looks like your compiler is bit more stricter than mine :)
It won't take too much to effort to fix those warnings I guess.

Mar 30 2021, 5:31 AM · Trusted Firmware M
Summer-ARM edited the content of Psa Arch Crypto Test Failure Analysis In Tf-m V1.3 Release.
Mar 30 2021, 3:29 AM
davidhuziji added a comment to T911: Build warnings.

Can you share the Compiler information please?

Mar 30 2021, 3:27 AM · Trusted Firmware M
davidhuziji added a comment to T911: Build warnings.
Mar 30 2021, 3:22 AM · Trusted Firmware M
davidhuziji added a comment to Twin-cpu.

Hi Martin, this *dual-cpu* design is dedicated for the platforms which consist of a non-secure core and a secure core. The secure core is protected from the non-secure core by system physical isolation. PSoC 64 is an example port of this *dual-cpu* implementation.

Mar 30 2021, 3:09 AM

Mar 29 2021

oyvindronningstad created T911: Build warnings.
Mar 29 2021, 10:28 AM · Trusted Firmware M
MartinSchoenstedt added a comment to Twin-cpu.

Don't know where to ask this, current TF-M design allows only for one secure cpu and one non-secure?
Why not have SPE and NSPE on both cores, as would be possible on mps2/an521 e.g. (dual M-33 with TrustZone). Could TF-M be modified to allow for such a behavior in the current version?
Thankful for any answers!

Mar 29 2021, 10:23 AM
lairdjm triaged T910: Interactive tests fail to return to main thread after test has ran and sit in osRtxIdleThread() function as Normal priority.
Mar 29 2021, 8:32 AM · Trusted Firmware M
davidhuziji closed T892: AUDIT_LOG secure regression tests don't compile with TFM_PSA_API=ON as Resolved.
Mar 29 2021, 8:16 AM
davidhuziji added a comment to T892: AUDIT_LOG secure regression tests don't compile with TFM_PSA_API=ON.

Improved by https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/9451

Mar 29 2021, 8:16 AM
gyuri-szing edited the content of Trusted Services.
Mar 29 2021, 8:12 AM · Restricted Project
gyuri-szing created an object: Public Videos And Presentations.
Mar 29 2021, 8:10 AM · Restricted Project
davidhuziji added a comment to T892: AUDIT_LOG secure regression tests don't compile with TFM_PSA_API=ON.

Great suggestion. Will add one in build configuration check soon.

Mar 29 2021, 6:58 AM
oyvindronningstad added a comment to T892: AUDIT_LOG secure regression tests don't compile with TFM_PSA_API=ON.

I see. It would be good to have an error message in that case.

Mar 29 2021, 6:48 AM
davidhuziji added a comment to T907: AUDIT_LOG incompatible with profile_medium.

Profile Medium selects IPC model by default. TF-M IPC model disables audit log service since audit log doesn't implement IPC model interface yet.
Please see: https://git.trustedfirmware.org/TF-M/trusted-firmware-m.git/tree/config/tfm_ipc_config_default.cmake

Mar 29 2021, 6:46 AM