adeaarm (Antonio de Angelis)
User

Projects

User Details

User Since
Apr 10 2018, 1:03 PM (61 w, 4 d)

Recent Activity

Fri, Jun 14

adeaarm added a comment to T398: Initial support for IAR Embedded Workbench for Arm tool chain.

Change associated to this is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1260

Fri, Jun 14, 1:55 PM · Trusted Firmware M
adeaarm added a comment to T398: Initial support for IAR Embedded Workbench for Arm tool chain.

Hi Thomas, I see you mention a failure with GNUARM 7.3.1 with some build config. Can you please provide instructions on how to reproduce the build failure? As you say the failure happens with the mainline as well, that shouldn't happen and I am not seeing the failure either. Would like to try to reproduce it here if it's a genuine issue.

Fri, Jun 14, 1:54 PM · Trusted Firmware M

Mon, Jun 10

adeaarm added a comment to T376: Allow NS secure call at pre-rtos stage.
In T376#4490, @ccli8 wrote:

This call involves a Thread -> Handler mode request on every service call to check if we are in pre-RTOS stage. I think this will introduce a non-negligible penalty; in most of the cases, we expect this call to happen when the RTOS has been loaded.

For the osKernelGetState() overhead in tfm_ns_lock_dispatch(...), I think it can be replaced by just checking ns_lock.init.

Mon, Jun 10, 1:17 PM · Trusted Firmware M
adeaarm added a comment to T376: Allow NS secure call at pre-rtos stage.

Strictly speaking, the files in interface/src are a possible implementation of the interface described in interface/include. Your integration can provide a different implementation of tfm_ns_lock_dispatch(...) based on your requirements, without the need to upstream your change. But if you think that your change can be useful for a wider audience, yes, please create a change where you modify tfm_ns_lock_dispatch(...) to check for pre-rtos stage and we'll get that reviewed.

Mon, Jun 10, 8:46 AM · Trusted Firmware M

Fri, Jun 7

adeaarm added a comment to T376: Allow NS secure call at pre-rtos stage.

Thanks for summarising the three options.

Fri, Jun 7, 2:28 PM · Trusted Firmware M

Thu, Jun 6

adeaarm added a comment to T376: Allow NS secure call at pre-rtos stage.

Just to be clear, as there has been some confusion between get_init_state() and get_lock_state (particularly on my side :) ), I think that the get_init_state(...) doesn't need to be exported as probably the same result can be obtained by proper usage of CMSIS-RTOS2 API's (or equivalent API's, based on the NS side scenario). Regarding the get_lock_state(...), I will comment on the other thread. T378

Thu, Jun 6, 2:41 PM · Trusted Firmware M
adeaarm added a comment to T376: Allow NS secure call at pre-rtos stage.

I agree in principle with the idea, but I have a comment regarding the implementation.

Thu, Jun 6, 2:07 PM · Trusted Firmware M
adeaarm added a comment to T392: Drop support for older versions of Armclang.

Change for this ticket is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1223

Thu, Jun 6, 10:24 AM · Trusted Firmware M
adeaarm triaged T392: Drop support for older versions of Armclang as Normal priority.
Thu, Jun 6, 10:21 AM · Trusted Firmware M

Thu, May 30

adeaarm added a comment to T386: Support building IPC model without tests.

Additional patch is required for Musca A to make sure that the quantity of RAM assigned to the SPE in the region_defs.h header is increased for IPC mode build even if the tests are not build, as RAM requirements for IPC are higher than the current default limit of 64 KB. Patch for this is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1184

Thu, May 30, 8:59 PM · Trusted Firmware M

Sat, May 25

adeaarm closed T352: Build: Add build configurations for PSA API compliance tests in IPC mode as Resolved.
Sat, May 25, 11:30 PM · Trusted Firmware M
adeaarm closed T354: Attestation: Align to use the update PSA Crypto APIs needed as Resolved.
Sat, May 25, 11:29 PM · Unknown Object (Project)
adeaarm closed T348: TF-M Crypto service update as Resolved.
Sat, May 25, 11:29 PM · Restricted Project

Fri, May 24

adeaarm added a comment to T355: SST: Update the service to call into the Crypto service.

Additional patch: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1147

Fri, May 24, 9:39 AM · Restricted Project

Sat, May 18

adeaarm moved T348: TF-M Crypto service update from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sat, May 18, 11:44 PM · Restricted Project
adeaarm moved T154: Modular secure services -- audit logging from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sat, May 18, 11:44 PM · Restricted Project
adeaarm moved T348: TF-M Crypto service update from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sat, May 18, 11:44 PM · Restricted Project
adeaarm closed T353: Remove references to Mbed TLS build in Audit Logging service as Resolved.
Sat, May 18, 11:43 PM · Restricted Project
adeaarm added a comment to T183: Build error: TF-M build fails for gcc version 6.3 for CoreTest configuration.

This needs to be merged, it has been open for months and the issue is being reported by Summer as well.

Sat, May 18, 11:41 PM · Trusted Firmware M

May 14 2019

adeaarm added a comment to T348: TF-M Crypto service update.

Pacthes for this work are as follows:

May 14 2019, 1:38 PM · Restricted Project
adeaarm added a comment to T355: SST: Update the service to call into the Crypto service.

Task which fixes this issue is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1076

May 14 2019, 1:22 PM · Restricted Project
adeaarm triaged T355: SST: Update the service to call into the Crypto service as Normal priority.
May 14 2019, 1:22 PM · Restricted Project
adeaarm added a comment to T354: Attestation: Align to use the update PSA Crypto APIs needed.

Change which completes this issue is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1073

May 14 2019, 12:51 PM · Unknown Object (Project)
adeaarm triaged T354: Attestation: Align to use the update PSA Crypto APIs needed as Normal priority.
May 14 2019, 12:50 PM · Unknown Object (Project)
adeaarm updated the task description for T348: TF-M Crypto service update.
May 14 2019, 12:49 PM · Restricted Project
adeaarm triaged T353: Remove references to Mbed TLS build in Audit Logging service as Normal priority.
May 14 2019, 12:46 PM · Restricted Project
adeaarm added a comment to T352: Build: Add build configurations for PSA API compliance tests in IPC mode.

Change which fixes this issue is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1079

May 14 2019, 12:44 PM · Trusted Firmware M
adeaarm triaged T352: Build: Add build configurations for PSA API compliance tests in IPC mode as Normal priority.
May 14 2019, 12:43 PM · Trusted Firmware M

May 13 2019

adeaarm updated subscribers of T348: TF-M Crypto service update.
May 13 2019, 8:53 AM · Restricted Project
adeaarm triaged T348: TF-M Crypto service update as Normal priority.
May 13 2019, 8:52 AM · Restricted Project

May 9 2019

adeaarm closed T326: ConfigCoreIPC.cmake with Regression = True fails during runtime as Resolved.
May 9 2019, 11:12 AM · Restricted Project
adeaarm added a comment to T326: ConfigCoreIPC.cmake with Regression = True fails during runtime.

This has been merged and I am able to run Regression in IPC mode, so this ticket can be closed.

May 9 2019, 11:11 AM · Restricted Project
adeaarm closed T343: Docs: Fix CSS theme style issue as Resolved.
May 9 2019, 11:10 AM · Trusted Firmware M
adeaarm added a comment to T343: Docs: Fix CSS theme style issue.

Fix for this style issue is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1019

May 9 2019, 11:06 AM · Trusted Firmware M
adeaarm added a comment to T343: Docs: Fix CSS theme style issue.

It turns out that it's a configuration option which can be overriden in our custom CSS file.

May 9 2019, 9:53 AM · Trusted Firmware M
adeaarm updated the task description for T343: Docs: Fix CSS theme style issue.
May 9 2019, 9:39 AM · Trusted Firmware M

May 8 2019

adeaarm updated the task description for T343: Docs: Fix CSS theme style issue.
May 8 2019, 3:21 PM · Trusted Firmware M
adeaarm updated the task description for T343: Docs: Fix CSS theme style issue.
May 8 2019, 3:16 PM · Trusted Firmware M
adeaarm renamed T343: Docs: Fix CSS theme style issue from Build: Fix CSS theme style issue to Docs: Fix CSS theme style issue.
May 8 2019, 2:54 PM · Trusted Firmware M
adeaarm triaged T343: Docs: Fix CSS theme style issue as Low priority.
May 8 2019, 2:53 PM · Trusted Firmware M
adeaarm added a comment to T341: Build: Fix documentation generation issues.

The fix for this issue is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1011

May 8 2019, 9:33 AM · Trusted Firmware M
adeaarm renamed T341: Build: Fix documentation generation issues from Docs: Various fixes to Build: Fix documentation generation issues.
May 8 2019, 9:28 AM · Trusted Firmware M
adeaarm triaged T341: Build: Fix documentation generation issues as Normal priority.
May 8 2019, 9:15 AM · Trusted Firmware M

May 7 2019

adeaarm added a comment to T326: ConfigCoreIPC.cmake with Regression = True fails during runtime.

Fix for this is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1001/

May 7 2019, 7:32 AM · Restricted Project

Apr 26 2019

adeaarm closed T234: GCC/Release: Compiler optimizes tfm_core_ns_ipc_request() too much as Resolved.
Apr 26 2019, 5:14 PM · Restricted Project

Apr 24 2019

adeaarm moved T163: SST IPC Compatibility from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 24 2019, 8:02 PM · Restricted Project
adeaarm moved T234: GCC/Release: Compiler optimizes tfm_core_ns_ipc_request() too much from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 24 2019, 7:57 PM · Restricted Project
adeaarm moved T234: GCC/Release: Compiler optimizes tfm_core_ns_ipc_request() too much from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 24 2019, 7:56 PM · Restricted Project
adeaarm added a project to T324: IPC compatibility for Initial Attestation Service: Unknown Object (Project).
Apr 24 2019, 7:49 PM · Unknown Object (Project)
adeaarm added a project to T157: PyCrypto switch to PyCryptodome: Trusted Firmware M.
Apr 24 2019, 7:48 PM · Trusted Firmware M
adeaarm added a project to T152: Proposal for Attestation Implementation: Unknown Object (Project).
Apr 24 2019, 7:47 PM · Unknown Object (Project)
adeaarm added a project to T303: Running partition index isn't update for IPC: Unknown Object (Project).
Apr 24 2019, 7:47 PM · Unknown Object (Project)
adeaarm edited projects for T234: GCC/Release: Compiler optimizes tfm_core_ns_ipc_request() too much, added: Restricted Project; removed Trusted Firmware M.
Apr 24 2019, 7:45 PM · Restricted Project
adeaarm lowered the priority of T154: Modular secure services -- audit logging from Normal to Low.
Apr 24 2019, 7:43 PM · Restricted Project
adeaarm added a project to T158: Building C++ files in TF-M: Trusted Firmware M.
Apr 24 2019, 7:39 PM · Trusted Firmware M
adeaarm triaged T175: Modular secure services -- SST as Low priority.
Apr 24 2019, 7:38 PM · Restricted Project
adeaarm edited projects for T326: ConfigCoreIPC.cmake with Regression = True fails during runtime, added: Restricted Project; removed Trusted Firmware M.
Apr 24 2019, 7:37 PM · Restricted Project
adeaarm triaged T160: Modular secure services -- crypto as Low priority.
Apr 24 2019, 7:35 PM · Restricted Project
adeaarm merged T241: tfm_psa_call_veneer() has wrong argument type for out_vecs into T313: psa_call(...) prototype in the veneer function uses wrong parameters.
Apr 24 2019, 7:34 PM · Restricted Project
adeaarm merged task T241: tfm_psa_call_veneer() has wrong argument type for out_vecs into T313: psa_call(...) prototype in the veneer function uses wrong parameters.
Apr 24 2019, 7:34 PM · Trusted Firmware M
adeaarm closed T239: NSPE lock cb isn't allocated as Wontfix.
Apr 24 2019, 7:29 PM · Trusted Firmware M
adeaarm added a comment to T239: NSPE lock cb isn't allocated.

Closing this as it's a design choice.

Apr 24 2019, 7:29 PM · Trusted Firmware M
adeaarm triaged T239: NSPE lock cb isn't allocated as Low priority.
Apr 24 2019, 7:28 PM · Trusted Firmware M

Apr 23 2019

adeaarm triaged T326: ConfigCoreIPC.cmake with Regression = True fails during runtime as High priority.
Apr 23 2019, 1:44 PM · Restricted Project

Apr 21 2019

adeaarm added a comment to T234: GCC/Release: Compiler optimizes tfm_core_ns_ipc_request() too much.

This is currently merged in the master branch. I am keeping the issue open for some more time in case any other external party needs to report/track the issue in their platforms/setup, I will then close if if no more occurrences of this are reported.

Apr 21 2019, 10:30 PM · Restricted Project
adeaarm closed T318: Make sure that volatile is used consistently to mark inline assembly block throughout the codebase as Resolved.
Apr 21 2019, 10:29 PM · Trusted Firmware M

Apr 17 2019

adeaarm added a project to T318: Make sure that volatile is used consistently to mark inline assembly block throughout the codebase: Trusted Firmware M.
Apr 17 2019, 6:19 PM · Trusted Firmware M
adeaarm added a comment to T318: Make sure that volatile is used consistently to mark inline assembly block throughout the codebase.

Patch for this issue is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/881

Apr 17 2019, 9:46 AM · Trusted Firmware M
adeaarm triaged T318: Make sure that volatile is used consistently to mark inline assembly block throughout the codebase as Low priority.
Apr 17 2019, 9:45 AM · Trusted Firmware M
adeaarm triaged T234: GCC/Release: Compiler optimizes tfm_core_ns_ipc_request() too much as High priority.
Apr 17 2019, 9:42 AM · Restricted Project
adeaarm added a comment to T234: GCC/Release: Compiler optimizes tfm_core_ns_ipc_request() too much.

A candidate fix for this issue is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/882

Apr 17 2019, 9:25 AM · Restricted Project
adeaarm claimed T234: GCC/Release: Compiler optimizes tfm_core_ns_ipc_request() too much.
Apr 17 2019, 9:22 AM · Restricted Project

Apr 13 2019

adeaarm closed T295: Use uniform signatures in Crypto service as Resolved.
Apr 13 2019, 12:20 AM · Restricted Project
adeaarm added a comment to T313: psa_call(...) prototype in the veneer function uses wrong parameters.

Assigned to Ken as he's the one driving this activity.

Apr 13 2019, 12:20 AM · Restricted Project
adeaarm reassigned T313: psa_call(...) prototype in the veneer function uses wrong parameters from adeaarm to KenLSoft.
Apr 13 2019, 12:19 AM · Restricted Project

Apr 11 2019

adeaarm added a comment to T313: psa_call(...) prototype in the veneer function uses wrong parameters.

Got it, thanks for the clarification. Do you think it's worth it to add a comment in the code to explain this in the header? Might be confusing at first glance. Or we should just close this item as a "won't fix, not an issue."

Apr 11 2019, 8:09 AM · Restricted Project

Apr 10 2019

adeaarm triaged T313: psa_call(...) prototype in the veneer function uses wrong parameters as Normal priority.
Apr 10 2019, 10:29 PM · Restricted Project

Apr 9 2019

adeaarm added a comment to T304: Incorrect build options for NS code.

Also, please note that __DOMAIN_NS (and later, DOMAIN_NS for later CMSIS versions) is used in the CMSIS_5 project hence our build systems has to define them to be able to build correctly those files.

Apr 9 2019, 4:16 PM · Trusted Firmware M

Mar 29 2019

adeaarm updated the task description for T295: Use uniform signatures in Crypto service.
Mar 29 2019, 4:23 PM · Restricted Project

Mar 28 2019

adeaarm added a comment to T295: Use uniform signatures in Crypto service.

The changes that complete this task are available here:

Mar 28 2019, 2:09 PM · Restricted Project
adeaarm updated the task description for T295: Use uniform signatures in Crypto service.
Mar 28 2019, 1:59 PM · Restricted Project
adeaarm triaged T295: Use uniform signatures in Crypto service as Normal priority.
Mar 28 2019, 1:58 PM · Restricted Project

Mar 6 2019

adeaarm closed T266: reduce the size of the tfm_audit.a and save build time as Resolved.
Mar 6 2019, 11:58 AM · Restricted Project
adeaarm added a comment to T266: reduce the size of the tfm_audit.a and save build time.

I have merged this change in https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/430/

Mar 6 2019, 11:58 AM · Restricted Project

Mar 5 2019

adeaarm closed T249: Add support for using Mbed TLS 2.16.0 as Resolved.
Mar 5 2019, 10:52 AM · Trusted Firmware M
adeaarm added a comment to T249: Add support for using Mbed TLS 2.16.0.

Fix for this is provided with https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/635/

Mar 5 2019, 10:52 AM · Trusted Firmware M
adeaarm closed T262: Build: Fix the location of some exported headers with make install as Resolved.
Mar 5 2019, 10:50 AM · Trusted Firmware M
adeaarm closed T232: TFM Crypto: Operation context retrieval additional checks as Resolved.
Mar 5 2019, 10:50 AM · Restricted Project
adeaarm moved T232: TFM Crypto: Operation context retrieval additional checks from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 5 2019, 10:49 AM · Restricted Project

Feb 21 2019

adeaarm added a watcher for Trusted Firmware M: adeaarm.
Feb 21 2019, 11:18 AM

Feb 20 2019

adeaarm added a comment to T262: Build: Fix the location of some exported headers with make install.

The change which fixes this issue is available here: https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/650/

Feb 20 2019, 3:28 PM · Trusted Firmware M
adeaarm triaged T262: Build: Fix the location of some exported headers with make install as Low priority.
Feb 20 2019, 3:27 PM · Trusted Firmware M

Feb 15 2019

adeaarm added a comment to T1: Add information on running under QEMU to the user guide.

This set of instructions proposed in this patch is now *OUTDATED* as it's based on running on mps2-an505 QEMU board even for AN521. As we have introduces some code now which is specific to AN521 with this commit http://git.trustedfirmware.org/trusted-firmware-m.git/commit/?id=c2f181e5ca4fce219c0e513bd3bf22e25dbdba5d , the instructions are no longer valid and need further update to be able to use AN521 build on QEMU.

Feb 15 2019, 12:43 PM · Restricted Project
adeaarm triaged T1: Add information on running under QEMU to the user guide as Low priority.
Feb 15 2019, 12:40 PM · Restricted Project

Feb 14 2019

adeaarm triaged T249: Add support for using Mbed TLS 2.16.0 as Low priority.
Feb 14 2019, 11:11 AM · Trusted Firmware M

Feb 13 2019

adeaarm closed T207: TFM Crypto: Align headers to 0.1.0a as Resolved.
Feb 13 2019, 11:25 PM · Restricted Project
adeaarm triaged T207: TFM Crypto: Align headers to 0.1.0a as Normal priority.
Feb 13 2019, 11:25 PM · Restricted Project
adeaarm moved T207: TFM Crypto: Align headers to 0.1.0a from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Feb 13 2019, 11:24 PM · Restricted Project
adeaarm moved T232: TFM Crypto: Operation context retrieval additional checks from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Feb 13 2019, 11:24 PM · Restricted Project
adeaarm triaged T232: TFM Crypto: Operation context retrieval additional checks as Normal priority.
Feb 13 2019, 11:24 PM · Restricted Project