adeaarm (Antonio de Angelis)
User

Projects

User Details

User Since
Apr 10 2018, 1:03 PM (87 w, 2 d)

Recent Activity

Oct 31 2019

adeaarm added a comment to T561: Update the TFM Crypto Service to use the mbedCrypto v2.0.

Preliminary change showing passing TF-M regression available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/2391

Oct 31 2019, 2:41 PM · Restricted Project

Oct 23 2019

adeaarm added a comment to T533: Crypto header clash with mbed-crypto.

Assigned to @davidwang for futher tracking and follow up.

Oct 23 2019, 10:59 AM · Restricted Project
adeaarm reassigned T533: Crypto header clash with mbed-crypto from adeaarm to davidwang.
Oct 23 2019, 10:58 AM · Restricted Project
adeaarm triaged T561: Update the TFM Crypto Service to use the mbedCrypto v2.0 as Normal priority.
Oct 23 2019, 10:58 AM · Restricted Project

Aug 8 2019

adeaarm closed T456: Crypto: Add configurability options to selectively disable service modules during cmake build as Resolved.
Aug 8 2019, 4:15 PM · Restricted Project

Aug 5 2019

adeaarm closed T447: Build: Add support for GNUARM 8.3.1 as Resolved.
Aug 5 2019, 2:25 PM · Trusted Firmware M

Aug 2 2019

adeaarm added a comment to T456: Crypto: Add configurability options to selectively disable service modules during cmake build.

Changes for this issue:

Aug 2 2019, 1:22 PM · Restricted Project
adeaarm triaged T456: Crypto: Add configurability options to selectively disable service modules during cmake build as Normal priority.
Aug 2 2019, 1:21 PM · Restricted Project

Jul 31 2019

adeaarm closed T444: Core: optimise bitcount routine as Resolved.
Jul 31 2019, 10:11 AM · Restricted Project

Jul 26 2019

adeaarm added a comment to T447: Build: Add support for GNUARM 8.3.1.

Patch for this is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1661

Jul 26 2019, 10:13 AM · Trusted Firmware M
adeaarm triaged T447: Build: Add support for GNUARM 8.3.1 as Low priority.
Jul 26 2019, 10:12 AM · Trusted Firmware M

Jul 25 2019

adeaarm added a comment to T444: Core: optimise bitcount routine.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/1654

Jul 25 2019, 2:34 PM · Restricted Project
adeaarm triaged T444: Core: optimise bitcount routine as Low priority.
Jul 25 2019, 1:31 PM · Restricted Project

Jul 24 2019

adeaarm added a comment to T443: Latest code can not run at MPS3(AN524) .

Hi @qixiang , could you help debugging? Most probably the faulty commit is blocked in an fault handler, it would be good to know which instruction causes the fault to be triggered to speed up analysis from developer's point of view.

Jul 24 2019, 3:27 PM · Restricted Project

Jul 23 2019

adeaarm updated subscribers of T378: Allow NS secure call in interrupt-disabled context.

This will be completed by an additional refactoring to use abstracted OS interface when possible (i.e. os_wrapper_*) to be done by @kevin-peng-hao . Please use this ticket to keep track of the additional change.

Jul 23 2019, 10:08 AM · Trusted Firmware M
adeaarm closed T428: Crypto: Update interface file to use Mbed Crypto 1.1.0 as Resolved.
Jul 23 2019, 9:26 AM · Restricted Project

Jul 19 2019

adeaarm added a comment to T420: Audit Log: Use uniform signatures.

One additional change for this that I missed on the first patch (thanks @matetothpal ): https://review.trustedfirmware.org/c/trusted-firmware-m/+/1594/

Jul 19 2019, 9:04 AM · Restricted Project

Jul 17 2019

adeaarm closed T420: Audit Log: Use uniform signatures as Resolved.
Jul 17 2019, 10:12 AM · Restricted Project

Jul 16 2019

adeaarm added a comment to T428: Crypto: Update interface file to use Mbed Crypto 1.1.0.

As explained above, this is not an issue as if a user project needs to include for some reason more than one implementation of the same PSA crypto interface, it's up to the user to provide a separation of the include trees.

Jul 16 2019, 8:30 AM · Restricted Project

Jul 15 2019

adeaarm added a comment to T428: Crypto: Update interface file to use Mbed Crypto 1.1.0.

There is no conflict anywhere in the header names of the TF-M project. Your use case is to have both Mbed Crypto and TF-M as part of the same IDE project, at that point is up to you to provide a clear separation of the different include trees of Mbed Crypto and TF-M, and not rely on the fact that having the same names they will have same contents, as they are two different implementations of the same interface, coming from two different projects and not distributed together (i.e. they have different paths by design).

Jul 15 2019, 2:33 PM · Restricted Project
adeaarm added a comment to T428: Crypto: Update interface file to use Mbed Crypto 1.1.0.

Not sure what is your use case, but I don't see how it's possible to compile Mbed Crypto and TF-M Crypto as part of the same application without doing symbol renaming of one of the two, given that they export the same symbol names. So I assume you have some way of renaming the symbols of either of the two before compilation, or excluding one of the two at link time.

Jul 15 2019, 2:12 PM · Restricted Project
adeaarm added a comment to T428: Crypto: Update interface file to use Mbed Crypto 1.1.0.

The expected use case is that an application will have to use a single implementation of the PSA Crypto interface at a time, so there won't be any conflict. In this case the module of the application will just "#include psa/crypto.h" as main header.

Jul 15 2019, 1:45 PM · Restricted Project
adeaarm added a comment to T428: Crypto: Update interface file to use Mbed Crypto 1.1.0.

the only common difference in the headers is the different license used by the headers distributed by TF-M and the ones distributed by Mbed Crypto.

Jul 15 2019, 12:51 PM · Restricted Project
adeaarm added a comment to T428: Crypto: Update interface file to use Mbed Crypto 1.1.0.

Change for this is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1562

Jul 15 2019, 10:01 AM · Restricted Project
adeaarm triaged T428: Crypto: Update interface file to use Mbed Crypto 1.1.0 as Normal priority.
Jul 15 2019, 9:56 AM · Restricted Project

Jul 12 2019

adeaarm added a comment to T414: Build failed on AN524/musca_b1 platform when -DMBEDTLS_DEBUG=ON.

HI @qixiang , the option to build with the debug version of Mbed Crypto or Mbed TLS is presented in our documentation just for the sake of completeness, but it's not something that we actively guarantee (i.e. we can't guarantee that the debug version of the mbedcrypto/mbedtls library will fit on all our platforms, due to different requirements in size). The option should be left as default and overriden only on those platforms that can afford it, and only on designed debug sessions. In my experience so far with the Crypto service, there is no need to debug the mbedcrypto/mbedtls libraries, as that would be out of scope for a TF-M deployment. Please let me know if you have questions or doubts about this.

Jul 12 2019, 9:50 AM · Restricted Project

Jul 11 2019

adeaarm added a comment to T420: Audit Log: Use uniform signatures.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/1531

Jul 11 2019, 2:59 PM · Restricted Project
adeaarm closed T404: Test: Refactor the os_wrapper layer as Resolved.
Jul 11 2019, 8:43 AM · Trusted Firmware M
adeaarm closed T415: Build: Add support for latest versions of CMSIS_5 as Resolved.
Jul 11 2019, 8:42 AM · Trusted Firmware M

Jul 10 2019

adeaarm triaged T420: Audit Log: Use uniform signatures as Low priority.
Jul 10 2019, 1:52 PM · Restricted Project

Jul 9 2019

adeaarm triaged T419: Build: Review build default defines as Wishlist priority.
Jul 9 2019, 9:33 AM · Trusted Firmware M
adeaarm added a project to T415: Build: Add support for latest versions of CMSIS_5: Trusted Firmware M.
Jul 9 2019, 9:32 AM · Trusted Firmware M

Jul 5 2019

adeaarm added a comment to T378: Allow NS secure call in interrupt-disabled context.

Possible refactoring available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1460

Jul 5 2019, 10:03 AM · Trusted Firmware M

Jul 4 2019

adeaarm added a comment to T378: Allow NS secure call in interrupt-disabled context.

We have discussed this matter and we would like to propose a solution which might be feasible for you.

Jul 4 2019, 9:21 AM · Trusted Firmware M

Jul 3 2019

adeaarm added a comment to T415: Build: Add support for latest versions of CMSIS_5.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/1421

Jul 3 2019, 1:18 PM · Trusted Firmware M
adeaarm triaged T415: Build: Add support for latest versions of CMSIS_5 as Low priority.
Jul 3 2019, 1:17 PM · Trusted Firmware M

Jun 28 2019

adeaarm added a comment to T408: Refactor UART stdio retargeting.

Additional change: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1420/

Jun 28 2019, 9:56 AM · Trusted Firmware M

Jun 25 2019

adeaarm added a comment to T408: Refactor UART stdio retargeting.

Patch for this issue: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1409

Jun 25 2019, 1:32 PM · Trusted Firmware M
adeaarm triaged T408: Refactor UART stdio retargeting as Low priority.
Jun 25 2019, 1:32 PM · Trusted Firmware M
adeaarm closed T401: Crypto: Check owner of contexts and key handles as Resolved.
Jun 25 2019, 1:30 PM · Restricted Project, Restricted Project
adeaarm closed T406: Update .gitignore for Visual Studio Code ignored items as Resolved.
Jun 25 2019, 1:30 PM · Trusted Firmware M

Jun 23 2019

adeaarm added a comment to T406: Update .gitignore for Visual Studio Code ignored items.

Change for this ticket: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1389

Jun 23 2019, 4:52 PM · Trusted Firmware M
adeaarm triaged T406: Update .gitignore for Visual Studio Code ignored items as Low priority.
Jun 23 2019, 4:37 PM · Trusted Firmware M

Jun 20 2019

adeaarm added a comment to T404: Test: Refactor the os_wrapper layer.

Patch for this: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1373

Jun 20 2019, 3:31 PM · Trusted Firmware M
adeaarm triaged T404: Test: Refactor the os_wrapper layer as Normal priority.
Jun 20 2019, 3:31 PM · Trusted Firmware M

Jun 19 2019

adeaarm added a comment to T401: Crypto: Check owner of contexts and key handles.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/1371

Jun 19 2019, 3:14 PM · Restricted Project, Restricted Project
adeaarm triaged T401: Crypto: Check owner of contexts and key handles as Normal priority.
Jun 19 2019, 3:05 PM · Restricted Project, Restricted Project
adeaarm closed T392: Drop support for older versions of Armclang as Resolved.
Jun 19 2019, 3:02 PM · Trusted Firmware M

Jun 17 2019

adeaarm updated the answer details for Q23: How will the crypto engine layer be added in crypto service compared to the old version? (Answer 27).
Jun 17 2019, 11:02 AM
adeaarm added Q23: How will the crypto engine layer be added in crypto service compared to the old version? (Answer 27).
Jun 17 2019, 10:47 AM

Jun 14 2019

adeaarm added a comment to T398: Initial support for IAR Embedded Workbench for Arm tool chain.

Change associated to this is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1260

Jun 14 2019, 1:55 PM · Trusted Firmware M
adeaarm added a comment to T398: Initial support for IAR Embedded Workbench for Arm tool chain.

Hi Thomas, I see you mention a failure with GNUARM 7.3.1 with some build config. Can you please provide instructions on how to reproduce the build failure? As you say the failure happens with the mainline as well, that shouldn't happen and I am not seeing the failure either. Would like to try to reproduce it here if it's a genuine issue.

Jun 14 2019, 1:54 PM · Trusted Firmware M

Jun 10 2019

adeaarm added a comment to T376: Allow NS secure call at pre-rtos stage.
In T376#4490, @ccli8 wrote:

This call involves a Thread -> Handler mode request on every service call to check if we are in pre-RTOS stage. I think this will introduce a non-negligible penalty; in most of the cases, we expect this call to happen when the RTOS has been loaded.

For the osKernelGetState() overhead in tfm_ns_lock_dispatch(...), I think it can be replaced by just checking ns_lock.init.

Jun 10 2019, 1:17 PM · Trusted Firmware M
adeaarm added a comment to T376: Allow NS secure call at pre-rtos stage.

Strictly speaking, the files in interface/src are a possible implementation of the interface described in interface/include. Your integration can provide a different implementation of tfm_ns_lock_dispatch(...) based on your requirements, without the need to upstream your change. But if you think that your change can be useful for a wider audience, yes, please create a change where you modify tfm_ns_lock_dispatch(...) using CMSIS-RTOS2 APIs to check for pre-rtos stage and we'll get that reviewed.

Jun 10 2019, 8:46 AM · Trusted Firmware M

Jun 7 2019

adeaarm added a comment to T376: Allow NS secure call at pre-rtos stage.

Thanks for summarising the three options.

Jun 7 2019, 2:28 PM · Trusted Firmware M

Jun 6 2019

adeaarm added a comment to T376: Allow NS secure call at pre-rtos stage.

Just to be clear, as there has been some confusion between get_init_state() and get_lock_state (particularly on my side :) ), I think that the get_init_state(...) doesn't need to be exported as probably the same result can be obtained by proper usage of CMSIS-RTOS2 API's (or equivalent API's, based on the NS side scenario). Regarding the get_lock_state(...), I will comment on the other thread. T378

Jun 6 2019, 2:41 PM · Trusted Firmware M
adeaarm added a comment to T376: Allow NS secure call at pre-rtos stage.

I agree in principle with the idea, but I have a comment regarding the implementation.

Jun 6 2019, 2:07 PM · Trusted Firmware M
adeaarm added a comment to T392: Drop support for older versions of Armclang.

Change for this ticket is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1223

Jun 6 2019, 10:24 AM · Trusted Firmware M
adeaarm triaged T392: Drop support for older versions of Armclang as Normal priority.
Jun 6 2019, 10:21 AM · Trusted Firmware M

May 30 2019

adeaarm added a comment to T386: Support building IPC model without tests.

Additional patch is required for Musca A to make sure that the quantity of RAM assigned to the SPE in the region_defs.h header is increased for IPC mode build even if the tests are not build, as RAM requirements for IPC are higher than the current default limit of 64 KB. Patch for this is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1184

May 30 2019, 8:59 PM · Trusted Firmware M

May 25 2019

adeaarm closed T352: Build: Add build configurations for PSA API compliance tests in IPC mode as Resolved.
May 25 2019, 11:30 PM · Trusted Firmware M
adeaarm closed T354: Attestation: Align to use the update PSA Crypto APIs needed as Resolved.
May 25 2019, 11:29 PM · Restricted Project
adeaarm closed T348: TF-M Crypto service update as Resolved.
May 25 2019, 11:29 PM · Restricted Project

May 24 2019

adeaarm added a comment to T355: SST: Update the service to call into the Crypto service.

Additional patch: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1147

May 24 2019, 9:39 AM · Restricted Project

May 18 2019

adeaarm moved T348: TF-M Crypto service update from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 18 2019, 11:44 PM · Restricted Project
adeaarm moved T154: Modular secure services -- audit logging from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 18 2019, 11:44 PM · Restricted Project
adeaarm moved T348: TF-M Crypto service update from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 18 2019, 11:44 PM · Restricted Project
adeaarm closed T353: Remove references to Mbed TLS build in Audit Logging service as Resolved.
May 18 2019, 11:43 PM · Restricted Project
adeaarm added a comment to T183: Build error: TF-M build fails for gcc version 6.3 for CoreTest configuration.

This needs to be merged, it has been open for months and the issue is being reported by Summer as well.

May 18 2019, 11:41 PM · Trusted Firmware M

May 14 2019

adeaarm added a comment to T348: TF-M Crypto service update.

Pacthes for this work are as follows:

May 14 2019, 1:38 PM · Restricted Project
adeaarm added a comment to T355: SST: Update the service to call into the Crypto service.

Task which fixes this issue is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1076

May 14 2019, 1:22 PM · Restricted Project
adeaarm triaged T355: SST: Update the service to call into the Crypto service as Normal priority.
May 14 2019, 1:22 PM · Restricted Project
adeaarm added a comment to T354: Attestation: Align to use the update PSA Crypto APIs needed.

Change which completes this issue is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1073

May 14 2019, 12:51 PM · Restricted Project
adeaarm triaged T354: Attestation: Align to use the update PSA Crypto APIs needed as Normal priority.
May 14 2019, 12:50 PM · Restricted Project
adeaarm updated the task description for T348: TF-M Crypto service update.
May 14 2019, 12:49 PM · Restricted Project
adeaarm triaged T353: Remove references to Mbed TLS build in Audit Logging service as Normal priority.
May 14 2019, 12:46 PM · Restricted Project
adeaarm added a comment to T352: Build: Add build configurations for PSA API compliance tests in IPC mode.

Change which fixes this issue is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1079

May 14 2019, 12:44 PM · Trusted Firmware M
adeaarm triaged T352: Build: Add build configurations for PSA API compliance tests in IPC mode as Normal priority.
May 14 2019, 12:43 PM · Trusted Firmware M

May 13 2019

adeaarm updated subscribers of T348: TF-M Crypto service update.
May 13 2019, 8:53 AM · Restricted Project
adeaarm triaged T348: TF-M Crypto service update as Normal priority.
May 13 2019, 8:52 AM · Restricted Project

May 9 2019

adeaarm closed T326: ConfigCoreIPC.cmake with Regression = True fails during runtime as Resolved.
May 9 2019, 11:12 AM · Restricted Project
adeaarm added a comment to T326: ConfigCoreIPC.cmake with Regression = True fails during runtime.

This has been merged and I am able to run Regression in IPC mode, so this ticket can be closed.

May 9 2019, 11:11 AM · Restricted Project
adeaarm closed T343: Docs: Fix CSS theme style issue as Resolved.
May 9 2019, 11:10 AM · Trusted Firmware M
adeaarm added a comment to T343: Docs: Fix CSS theme style issue.

Fix for this style issue is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1019

May 9 2019, 11:06 AM · Trusted Firmware M
adeaarm added a comment to T343: Docs: Fix CSS theme style issue.

It turns out that it's a configuration option which can be overriden in our custom CSS file.

May 9 2019, 9:53 AM · Trusted Firmware M
adeaarm updated the task description for T343: Docs: Fix CSS theme style issue.
May 9 2019, 9:39 AM · Trusted Firmware M

May 8 2019

adeaarm updated the task description for T343: Docs: Fix CSS theme style issue.
May 8 2019, 3:21 PM · Trusted Firmware M
adeaarm updated the task description for T343: Docs: Fix CSS theme style issue.
May 8 2019, 3:16 PM · Trusted Firmware M
adeaarm renamed T343: Docs: Fix CSS theme style issue from Build: Fix CSS theme style issue to Docs: Fix CSS theme style issue.
May 8 2019, 2:54 PM · Trusted Firmware M
adeaarm triaged T343: Docs: Fix CSS theme style issue as Low priority.
May 8 2019, 2:53 PM · Trusted Firmware M
adeaarm added a comment to T341: Build: Fix documentation generation issues.

The fix for this issue is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1011

May 8 2019, 9:33 AM · Trusted Firmware M
adeaarm renamed T341: Build: Fix documentation generation issues from Docs: Various fixes to Build: Fix documentation generation issues.
May 8 2019, 9:28 AM · Trusted Firmware M
adeaarm triaged T341: Build: Fix documentation generation issues as Normal priority.
May 8 2019, 9:15 AM · Trusted Firmware M

May 7 2019

adeaarm added a comment to T326: ConfigCoreIPC.cmake with Regression = True fails during runtime.

Fix for this is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1001/

May 7 2019, 7:32 AM · Restricted Project

Apr 26 2019

adeaarm closed T234: GCC/Release: Compiler optimizes tfm_core_ns_ipc_request() too much as Resolved.
Apr 26 2019, 5:14 PM · Restricted Project

Apr 24 2019

adeaarm moved T163: SST IPC Compatibility from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 24 2019, 8:02 PM · Restricted Project
adeaarm moved T234: GCC/Release: Compiler optimizes tfm_core_ns_ipc_request() too much from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 24 2019, 7:57 PM · Restricted Project
adeaarm moved T234: GCC/Release: Compiler optimizes tfm_core_ns_ipc_request() too much from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 24 2019, 7:56 PM · Restricted Project
adeaarm added a project to T324: IPC compatibility for Initial Attestation Service: Restricted Project.
Apr 24 2019, 7:49 PM · Restricted Project
adeaarm added a project to T157: PyCrypto switch to PyCryptodome: Trusted Firmware M.
Apr 24 2019, 7:48 PM · Trusted Firmware M