- User Since
- Apr 10 2018, 1:03 PM (61 w, 4 d)
Fri, Jun 14
Change associated to this is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1260
Hi Thomas, I see you mention a failure with GNUARM 7.3.1 with some build config. Can you please provide instructions on how to reproduce the build failure? As you say the failure happens with the mainline as well, that shouldn't happen and I am not seeing the failure either. Would like to try to reproduce it here if it's a genuine issue.
Mon, Jun 10
Strictly speaking, the files in interface/src are a possible implementation of the interface described in interface/include. Your integration can provide a different implementation of tfm_ns_lock_dispatch(...) based on your requirements, without the need to upstream your change. But if you think that your change can be useful for a wider audience, yes, please create a change where you modify tfm_ns_lock_dispatch(...) to check for pre-rtos stage and we'll get that reviewed.
Fri, Jun 7
Thanks for summarising the three options.
Thu, Jun 6
Just to be clear, as there has been some confusion between get_init_state() and get_lock_state (particularly on my side :) ), I think that the get_init_state(...) doesn't need to be exported as probably the same result can be obtained by proper usage of CMSIS-RTOS2 API's (or equivalent API's, based on the NS side scenario). Regarding the get_lock_state(...), I will comment on the other thread. T378
I agree in principle with the idea, but I have a comment regarding the implementation.
Change for this ticket is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1223
Thu, May 30
Additional patch is required for Musca A to make sure that the quantity of RAM assigned to the SPE in the region_defs.h header is increased for IPC mode build even if the tests are not build, as RAM requirements for IPC are higher than the current default limit of 64 KB. Patch for this is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1184
Sat, May 25
Fri, May 24
Additional patch: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1147
Sat, May 18
This needs to be merged, it has been open for months and the issue is being reported by Summer as well.
May 14 2019
Pacthes for this work are as follows:
Task which fixes this issue is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1076
Change which completes this issue is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1073
Change which fixes this issue is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1079
May 13 2019
May 9 2019
This has been merged and I am able to run Regression in IPC mode, so this ticket can be closed.
Fix for this style issue is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1019
It turns out that it's a configuration option which can be overriden in our custom CSS file.
May 8 2019
The fix for this issue is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1011
May 7 2019
Fix for this is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1001/
Apr 26 2019
Apr 24 2019
Closing this as it's a design choice.
Apr 23 2019
Apr 21 2019
This is currently merged in the master branch. I am keeping the issue open for some more time in case any other external party needs to report/track the issue in their platforms/setup, I will then close if if no more occurrences of this are reported.
Apr 17 2019
Patch for this issue is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/881
A candidate fix for this issue is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/882
Apr 13 2019
Assigned to Ken as he's the one driving this activity.
Apr 11 2019
Got it, thanks for the clarification. Do you think it's worth it to add a comment in the code to explain this in the header? Might be confusing at first glance. Or we should just close this item as a "won't fix, not an issue."
Apr 10 2019
Apr 9 2019
Also, please note that __DOMAIN_NS (and later, DOMAIN_NS for later CMSIS versions) is used in the CMSIS_5 project hence our build systems has to define them to be able to build correctly those files.
Mar 29 2019
Mar 28 2019
The changes that complete this task are available here:
Mar 6 2019
I have merged this change in https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/430/
Mar 5 2019
Fix for this is provided with https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/635/
Feb 21 2019
Feb 20 2019
The change which fixes this issue is available here: https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/650/
Feb 15 2019
This set of instructions proposed in this patch is now *OUTDATED* as it's based on running on mps2-an505 QEMU board even for AN521. As we have introduces some code now which is specific to AN521 with this commit http://git.trustedfirmware.org/trusted-firmware-m.git/commit/?id=c2f181e5ca4fce219c0e513bd3bf22e25dbdba5d , the instructions are no longer valid and need further update to be able to use AN521 build on QEMU.