Page MenuHomePhabricator

adeaarm (Antonio de Angelis)
User

Projects

User Details

User Since
Apr 10 2018, 1:03 PM (172 w, 9 h)

Recent Activity

Yesterday

adeaarm moved T935: PSA driver for cipher capability from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mon, Jul 26, 3:50 PM · Restricted Project
adeaarm moved T933: PSA driver for hash capability from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mon, Jul 26, 3:49 PM · Restricted Project
adeaarm moved T948: List all missing one-shot API tests from the existing TF-M regression from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mon, Jul 26, 3:44 PM · Restricted Project
adeaarm added a comment to T948: List all missing one-shot API tests from the existing TF-M regression.

Single shot key agreement:

Mon, Jul 26, 3:42 PM · Restricted Project

Fri, Jul 23

adeaarm updated subscribers of T933: PSA driver for hash capability.

hash_compute has been added directly by @salomethirot-arm to the multipart patch available here: https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/10607 as discussed during the last sync-up call. @Vge0rge please do have a round of review of the hash_compute (and the whole patch as well) to get to +1 status.

Fri, Jul 23, 5:16 PM · Restricted Project
adeaarm added a comment to T941: PSA driver for hash multipart capability.

https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/10607

Fri, Jul 23, 5:15 PM · Restricted Project
adeaarm assigned T934: PSA driver for mac capability to salomethirot-arm.
Fri, Jul 23, 2:24 PM · Restricted Project
adeaarm assigned T935: PSA driver for cipher capability to noonfom.
Fri, Jul 23, 2:19 PM · Restricted Project

Tue, Jul 20

adeaarm claimed T951: TFM regressions tests seem to hang on QEMU for mps2_an521.
Tue, Jul 20, 9:33 AM

Mon, Jul 19

adeaarm added a comment to T951: TFM regressions tests seem to hang on QEMU for mps2_an521.

Probably better to reduce the priority of the ticket but keep it open just to make sure we are reminded to verify it again once the next release of qemu is available.

Mon, Jul 19, 11:16 AM

Fri, Jul 16

adeaarm added a comment to T951: TFM regressions tests seem to hang on QEMU for mps2_an521.

Hi @ioannisg , this is due to this bug in QEMU:

Fri, Jul 16, 2:25 PM

Wed, Jul 7

adeaarm added a comment to T948: List all missing one-shot API tests from the existing TF-M regression.

Cipher/MAC single-shot APIs patches:

Wed, Jul 7, 4:24 PM · Restricted Project
adeaarm closed T929: Optimise SPM operations in Library mode as Resolved.
Wed, Jul 7, 8:21 AM · Trusted Firmware M

Mon, Jul 5

adeaarm added a comment to T948: List all missing one-shot API tests from the existing TF-M regression.

Hash: https://review.trustedfirmware.org/c/TF-M/tf-m-tests/+/10544
MAC: Support in mbedtls-2.26.0 for the single-shot APIs is not present. I have a patch to enable the tests and the shim layer in TF-M, I will keep it private until support from the backend side is available somehow.

Mon, Jul 5, 12:09 PM · Restricted Project

Sun, Jul 4

adeaarm added a comment to T933: PSA driver for hash capability.

This patch extends tests coverate in the TF-M regression test suite for the single-shot hash API.

Sun, Jul 4, 1:50 PM · Restricted Project

Fri, Jul 2

adeaarm moved T948: List all missing one-shot API tests from the existing TF-M regression from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Fri, Jul 2, 7:10 PM · Restricted Project
adeaarm triaged T948: List all missing one-shot API tests from the existing TF-M regression as Normal priority.
Fri, Jul 2, 7:10 PM · Restricted Project
adeaarm added a comment to T945: PSA driver for cipher multipart capability.

Prototypes derived from: https://github.com/ARMmbed/mbedtls/blob/development/library/psa_crypto_driver_wrappers.h

Fri, Jul 2, 7:06 PM · Restricted Project
adeaarm added a comment to T944: PSA driver for aead multipart capability.
typedef ... acme_aead_operation_t;
psa_status_t acme_aead_encrypt_setup(
   acme_aead_operation_t *operation,
   const psa_key_attributes_t *attributes,
   const uint8_t *key_buffer, size_t key_buffer_size,
   psa_algorithm_t alg);
psa_status_t acme_aead_decrypt_setup(
   acme_aead_operation_t *operation,
   const psa_key_attributes_t *attributes,
   const uint8_t *key_buffer, size_t key_buffer_size,
   psa_algorithm_t alg);
psa_status_t acme_aead_set_nonce(
   acme_aead_operation_t *operation,
   const uint8_t *nonce,
   size_t nonce_length);
psa_status_t acme_aead_set_lengths(
   acme_aead_operation_t *operation,
   size_t ad_length,
   size_t plaintext_length);
psa_status_t acme_aead_update_ad(
   acme_aead_operation_t *operation,
   const uint8_t *input,
   size_t input_length);
psa_status_t acme_aead_update(
   acme_aead_operation_t *operation,
   const uint8_t *input,
   size_t input_length,
   uint8_t *output,
   size_t output_size,
   size_t *output_length);
psa_status_t acme_aead_finish(
   acme_aead_operation_t *operation,
   uint8_t *ciphertext,
   size_t ciphertext_size,
   size_t *ciphertext_length,
   uint8_t *tag,
   size_t tag_size,
   size_t *tag_length);
psa_status_t acme_aead_verify(
   acme_aead_operation_t *operation,
   uint8_t *plaintext,
   size_t plaintext_size,
   size_t *plaintext_length,
   const uint8_t *tag,
   size_t tag_length);
psa_status_t acme_aead_abort(
   acme_aead_operation_t *operation);
Fri, Jul 2, 7:01 PM · Restricted Project
adeaarm closed T942: Finalise list of multipart capabilities entry points as Resolved.
Fri, Jul 2, 6:58 PM · Restricted Project
adeaarm added a comment to T943: PSA driver for mac multipart capability.
typedef ... acme_mac_operation_t;
psa_status_t acme_mac_sign_setup(
    acme_mac_operation_t *operation,
    const psa_key_attributes_t *attributes,
    const uint8_t *key_buffer,
    size_t key_buffer_size,
    psa_algorithm_t alg);
psa_status_t acme_mac_verify_setup(
    acme_mac_operation_t *operation,
    const psa_key_attributes_t *attributes,
    const uint8_t *key_buffer,
    size_t key_buffer_size,
    psa_algorithm_t alg);
psa_status_t acme_mac_update(
    acme_mac_operation_t *operation,
    const uint8_t *input,
    size_t input_length);
psa_status_t acme_mac_sign_finish(
    acme_mac_operation_t *operation,
    uint8_t *mac,
    size_t mac_size,
    size_t *mac_length);
psa_status_t acme_mac_verify_finish(
    acme_mac_operation_t *operation,
    const uint8_t *mac,
    size_t mac_length);
psa_status_t acme_mac_abort(
    acme_mac_operation_t *operation);
Fri, Jul 2, 6:56 PM · Restricted Project
adeaarm moved T942: Finalise list of multipart capabilities entry points from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Fri, Jul 2, 6:55 PM · Restricted Project
adeaarm moved T942: Finalise list of multipart capabilities entry points from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Fri, Jul 2, 6:55 PM · Restricted Project
adeaarm added a comment to T942: Finalise list of multipart capabilities entry points.

MAC:

typedef ... acme_mac_operation_t;
psa_status_t acme_mac_sign_setup(
    acme_mac_operation_t *operation,
    const psa_key_attributes_t *attributes,
    const uint8_t *key_buffer,
    size_t key_buffer_size,
    psa_algorithm_t alg);
psa_status_t acme_mac_verify_setup(
    acme_mac_operation_t *operation,
    const psa_key_attributes_t *attributes,
    const uint8_t *key_buffer,
    size_t key_buffer_size,
    psa_algorithm_t alg);
psa_status_t acme_mac_update(
    acme_mac_operation_t *operation,
    const uint8_t *input,
    size_t input_length);
psa_status_t acme_mac_sign_finish(
    acme_mac_operation_t *operation,
    uint8_t *mac,
    size_t mac_size,
    size_t *mac_length);
psa_status_t acme_mac_verify_finish(
    acme_mac_operation_t *operation,
    const uint8_t *mac,
    size_t mac_length);
psa_status_t acme_mac_abort(
    acme_mac_operation_t *operation);
Fri, Jul 2, 6:54 PM · Restricted Project
adeaarm added a comment to T1: Add information on running under QEMU to the user guide.

Due to a bug recently discovered in Qemu, we should mention in the docs that minimum required version is 6.1 (to be released around mid-end of August)

Fri, Jul 2, 7:14 AM · Restricted Project

Thu, Jul 1

adeaarm added a comment to T941: PSA driver for hash multipart capability.

There is also an hash_clone entry point which is not currently documented in the spec draft but is present as a call in the core layer.

Thu, Jul 1, 4:26 PM · Restricted Project
adeaarm assigned T945: PSA driver for cipher multipart capability to noonfom.
Thu, Jul 1, 2:28 PM · Restricted Project

Jun 25 2021

adeaarm moved T942: Finalise list of multipart capabilities entry points from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 25 2021, 11:25 AM · Restricted Project
adeaarm triaged T947: PSA driver for random generation multipart capability as Normal priority.
Jun 25 2021, 11:24 AM · Restricted Project
adeaarm triaged T946: PSA driver for key_derivation multipart capability as Normal priority.
Jun 25 2021, 11:18 AM · Restricted Project
adeaarm triaged T945: PSA driver for cipher multipart capability as Normal priority.
Jun 25 2021, 11:17 AM · Restricted Project
adeaarm triaged T944: PSA driver for aead multipart capability as Normal priority.
Jun 25 2021, 11:16 AM · Restricted Project
adeaarm triaged T943: PSA driver for mac multipart capability as Normal priority.
Jun 25 2021, 11:15 AM · Restricted Project
adeaarm triaged T942: Finalise list of multipart capabilities entry points as High priority.
Jun 25 2021, 11:13 AM · Restricted Project
adeaarm triaged T941: PSA driver for hash multipart capability as Normal priority.
Jun 25 2021, 11:10 AM · Restricted Project
adeaarm triaged T940: PSA driver for get_entropy capability as Normal priority.
Jun 25 2021, 11:08 AM · Restricted Project
adeaarm triaged T939: PSA driver for key_agreement capability as Normal priority.
Jun 25 2021, 11:08 AM · Restricted Project
adeaarm triaged T938: PSA driver for sign/verify message capability as Normal priority.
Jun 25 2021, 11:07 AM · Restricted Project
adeaarm triaged T937: PSA driver for asymmetric capability as Normal priority.
Jun 25 2021, 11:06 AM · Restricted Project
adeaarm triaged T936: PSA driver for aead capability as Normal priority.
Jun 25 2021, 11:05 AM · Restricted Project
adeaarm created T936: PSA driver for aead capability.
Jun 25 2021, 11:04 AM · Restricted Project
adeaarm triaged T935: PSA driver for cipher capability as Normal priority.
Jun 25 2021, 11:04 AM · Restricted Project
adeaarm triaged T934: PSA driver for mac capability as Normal priority.
Jun 25 2021, 11:02 AM · Restricted Project
adeaarm triaged T933: PSA driver for hash capability as Normal priority.
Jun 25 2021, 11:01 AM · Restricted Project

Jun 3 2021

adeaarm added a comment to T929: Optimise SPM operations in Library mode.

Note that as part of this activity the following bug in the Qemu porting of the mps2-an521 board has been found and fixed with the following pull request:

Jun 3 2021, 6:32 PM · Trusted Firmware M
adeaarm added a comment to T929: Optimise SPM operations in Library mode.

Patches available here:

Jun 3 2021, 6:18 PM · Trusted Firmware M
adeaarm triaged T929: Optimise SPM operations in Library mode as Normal priority.
Jun 3 2021, 6:17 PM · Trusted Firmware M

Mar 24 2021

adeaarm added a comment to T1: Add information on running under QEMU to the user guide.

With a recent version of QEMU (i.e. 4.x), it should be enough just to use this to run TF-M on QEMU for AN521:

Mar 24 2021, 7:58 PM · Restricted Project

Mar 17 2021

adeaarm closed T408: Refactor UART stdio retargeting as Wontfix.
Mar 17 2021, 11:51 AM · Trusted Firmware M

Oct 31 2019

adeaarm added a comment to T561: Update the TFM Crypto Service to use the mbedCrypto v2.0.

Preliminary change showing passing TF-M regression available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/2391

Oct 31 2019, 2:41 PM · Restricted Project

Oct 23 2019

adeaarm added a comment to T533: Crypto header clash with mbed-crypto.

Assigned to @davidwang for futher tracking and follow up.

Oct 23 2019, 10:59 AM · Restricted Project
adeaarm reassigned T533: Crypto header clash with mbed-crypto from adeaarm to davidwang.
Oct 23 2019, 10:58 AM · Restricted Project
adeaarm triaged T561: Update the TFM Crypto Service to use the mbedCrypto v2.0 as Normal priority.
Oct 23 2019, 10:58 AM · Restricted Project

Aug 8 2019

adeaarm closed T456: Crypto: Add configurability options to selectively disable service modules during cmake build as Resolved.
Aug 8 2019, 4:15 PM · Restricted Project

Aug 5 2019

adeaarm closed T447: Build: Add support for GNUARM 8.3.1 as Resolved.
Aug 5 2019, 2:25 PM · Trusted Firmware M

Aug 2 2019

adeaarm added a comment to T456: Crypto: Add configurability options to selectively disable service modules during cmake build.

Changes for this issue:

Aug 2 2019, 1:22 PM · Restricted Project
adeaarm triaged T456: Crypto: Add configurability options to selectively disable service modules during cmake build as Normal priority.
Aug 2 2019, 1:21 PM · Restricted Project

Jul 31 2019

adeaarm closed T444: Core: optimise bitcount routine as Resolved.
Jul 31 2019, 10:11 AM · Restricted Project

Jul 26 2019

adeaarm added a comment to T447: Build: Add support for GNUARM 8.3.1.

Patch for this is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1661

Jul 26 2019, 10:13 AM · Trusted Firmware M
adeaarm triaged T447: Build: Add support for GNUARM 8.3.1 as Low priority.
Jul 26 2019, 10:12 AM · Trusted Firmware M

Jul 25 2019

adeaarm added a comment to T444: Core: optimise bitcount routine.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/1654

Jul 25 2019, 2:34 PM · Restricted Project
adeaarm triaged T444: Core: optimise bitcount routine as Low priority.
Jul 25 2019, 1:31 PM · Restricted Project

Jul 24 2019

adeaarm added a comment to T443: Latest code can not run at MPS3(AN524) .

Hi @qixiang , could you help debugging? Most probably the faulty commit is blocked in an fault handler, it would be good to know which instruction causes the fault to be triggered to speed up analysis from developer's point of view.

Jul 24 2019, 3:27 PM · Restricted Project

Jul 23 2019

adeaarm updated subscribers of T378: Allow NS secure call in interrupt-disabled context.

This will be completed by an additional refactoring to use abstracted OS interface when possible (i.e. os_wrapper_*) to be done by @kevin-peng-hao . Please use this ticket to keep track of the additional change.

Jul 23 2019, 10:08 AM · Trusted Firmware M
adeaarm closed T428: Crypto: Update interface file to use Mbed Crypto 1.1.0 as Resolved.
Jul 23 2019, 9:26 AM · Restricted Project

Jul 19 2019

adeaarm added a comment to T420: Audit Log: Use uniform signatures.

One additional change for this that I missed on the first patch (thanks @matetothpal ): https://review.trustedfirmware.org/c/trusted-firmware-m/+/1594/

Jul 19 2019, 9:04 AM · Restricted Project

Jul 17 2019

adeaarm closed T420: Audit Log: Use uniform signatures as Resolved.
Jul 17 2019, 10:12 AM · Restricted Project

Jul 16 2019

adeaarm added a comment to T428: Crypto: Update interface file to use Mbed Crypto 1.1.0.

As explained above, this is not an issue as if a user project needs to include for some reason more than one implementation of the same PSA crypto interface, it's up to the user to provide a separation of the include trees.

Jul 16 2019, 8:30 AM · Restricted Project

Jul 15 2019

adeaarm added a comment to T428: Crypto: Update interface file to use Mbed Crypto 1.1.0.

There is no conflict anywhere in the header names of the TF-M project. Your use case is to have both Mbed Crypto and TF-M as part of the same IDE project, at that point is up to you to provide a clear separation of the different include trees of Mbed Crypto and TF-M, and not rely on the fact that having the same names they will have same contents, as they are two different implementations of the same interface, coming from two different projects and not distributed together (i.e. they have different paths by design).

Jul 15 2019, 2:33 PM · Restricted Project
adeaarm added a comment to T428: Crypto: Update interface file to use Mbed Crypto 1.1.0.

Not sure what is your use case, but I don't see how it's possible to compile Mbed Crypto and TF-M Crypto as part of the same application without doing symbol renaming of one of the two, given that they export the same symbol names. So I assume you have some way of renaming the symbols of either of the two before compilation, or excluding one of the two at link time.

Jul 15 2019, 2:12 PM · Restricted Project
adeaarm added a comment to T428: Crypto: Update interface file to use Mbed Crypto 1.1.0.

The expected use case is that an application will have to use a single implementation of the PSA Crypto interface at a time, so there won't be any conflict. In this case the module of the application will just "#include psa/crypto.h" as main header.

Jul 15 2019, 1:45 PM · Restricted Project
adeaarm added a comment to T428: Crypto: Update interface file to use Mbed Crypto 1.1.0.

the only common difference in the headers is the different license used by the headers distributed by TF-M and the ones distributed by Mbed Crypto.

Jul 15 2019, 12:51 PM · Restricted Project
adeaarm added a comment to T428: Crypto: Update interface file to use Mbed Crypto 1.1.0.

Change for this is available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1562

Jul 15 2019, 10:01 AM · Restricted Project
adeaarm triaged T428: Crypto: Update interface file to use Mbed Crypto 1.1.0 as Normal priority.
Jul 15 2019, 9:56 AM · Restricted Project

Jul 12 2019

adeaarm added a comment to T414: Build failed on AN524/musca_b1 platform when -DMBEDTLS_DEBUG=ON.

HI @qixiang , the option to build with the debug version of Mbed Crypto or Mbed TLS is presented in our documentation just for the sake of completeness, but it's not something that we actively guarantee (i.e. we can't guarantee that the debug version of the mbedcrypto/mbedtls library will fit on all our platforms, due to different requirements in size). The option should be left as default and overriden only on those platforms that can afford it, and only on designed debug sessions. In my experience so far with the Crypto service, there is no need to debug the mbedcrypto/mbedtls libraries, as that would be out of scope for a TF-M deployment. Please let me know if you have questions or doubts about this.

Jul 12 2019, 9:50 AM · Restricted Project

Jul 11 2019

adeaarm added a comment to T420: Audit Log: Use uniform signatures.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/1531

Jul 11 2019, 2:59 PM · Restricted Project
adeaarm closed T404: Test: Refactor the os_wrapper layer as Resolved.
Jul 11 2019, 8:43 AM · Trusted Firmware M
adeaarm closed T415: Build: Add support for latest versions of CMSIS_5 as Resolved.
Jul 11 2019, 8:42 AM · Trusted Firmware M

Jul 10 2019

adeaarm triaged T420: Audit Log: Use uniform signatures as Low priority.
Jul 10 2019, 1:52 PM · Restricted Project

Jul 9 2019

adeaarm triaged T419: Build: Review build default defines as Wishlist priority.
Jul 9 2019, 9:33 AM · Trusted Firmware M
adeaarm added a project to T415: Build: Add support for latest versions of CMSIS_5: Trusted Firmware M.
Jul 9 2019, 9:32 AM · Trusted Firmware M

Jul 5 2019

adeaarm added a comment to T378: Allow NS secure call in interrupt-disabled context.

Possible refactoring available here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1460

Jul 5 2019, 10:03 AM · Trusted Firmware M

Jul 4 2019

adeaarm added a comment to T378: Allow NS secure call in interrupt-disabled context.

We have discussed this matter and we would like to propose a solution which might be feasible for you.

Jul 4 2019, 9:21 AM · Trusted Firmware M

Jul 3 2019

adeaarm added a comment to T415: Build: Add support for latest versions of CMSIS_5.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/1421

Jul 3 2019, 1:18 PM · Trusted Firmware M
adeaarm triaged T415: Build: Add support for latest versions of CMSIS_5 as Low priority.
Jul 3 2019, 1:17 PM · Trusted Firmware M

Jun 28 2019

adeaarm added a comment to T408: Refactor UART stdio retargeting.

Additional change: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1420/

Jun 28 2019, 9:56 AM · Trusted Firmware M

Jun 25 2019

adeaarm added a comment to T408: Refactor UART stdio retargeting.

Patch for this issue: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1409

Jun 25 2019, 1:32 PM · Trusted Firmware M
adeaarm triaged T408: Refactor UART stdio retargeting as Low priority.
Jun 25 2019, 1:32 PM · Trusted Firmware M
adeaarm closed T401: Crypto: Check owner of contexts and key handles as Resolved.
Jun 25 2019, 1:30 PM · Restricted Project, Restricted Project
adeaarm closed T406: Update .gitignore for Visual Studio Code ignored items as Resolved.
Jun 25 2019, 1:30 PM · Trusted Firmware M

Jun 23 2019

adeaarm added a comment to T406: Update .gitignore for Visual Studio Code ignored items.

Change for this ticket: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1389

Jun 23 2019, 4:52 PM · Trusted Firmware M
adeaarm triaged T406: Update .gitignore for Visual Studio Code ignored items as Low priority.
Jun 23 2019, 4:37 PM · Trusted Firmware M

Jun 20 2019

adeaarm added a comment to T404: Test: Refactor the os_wrapper layer.

Patch for this: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1373

Jun 20 2019, 3:31 PM · Trusted Firmware M
adeaarm triaged T404: Test: Refactor the os_wrapper layer as Normal priority.
Jun 20 2019, 3:31 PM · Trusted Firmware M

Jun 19 2019

adeaarm added a comment to T401: Crypto: Check owner of contexts and key handles.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/1371

Jun 19 2019, 3:14 PM · Restricted Project, Restricted Project
adeaarm triaged T401: Crypto: Check owner of contexts and key handles as Normal priority.
Jun 19 2019, 3:05 PM · Restricted Project, Restricted Project
adeaarm closed T392: Drop support for older versions of Armclang as Resolved.
Jun 19 2019, 3:02 PM · Trusted Firmware M

Jun 17 2019

adeaarm updated the answer details for Q23: How will the crypto engine layer be added in crypto service compared to the old version? (Answer 27).
Jun 17 2019, 11:02 AM
adeaarm added Q23: How will the crypto engine layer be added in crypto service compared to the old version? (Answer 27).
Jun 17 2019, 10:47 AM

Jun 14 2019

adeaarm added a comment to T398: Initial support for IAR Embedded Workbench for Arm tool chain.

Change associated to this is here: https://review.trustedfirmware.org/c/trusted-firmware-m/+/1260

Jun 14 2019, 1:55 PM · Trusted Firmware M