gyuri-szing (György Szing)
User

Projects

User Details

User Since
Apr 9 2018, 7:07 AM (86 w, 3 d)

Recent Activity

Yesterday

gyuri-szing added a comment to T228: Update build system to support latest cmake version..
In T228#6978, @CJKay wrote:

Snapcraft distributes builds for the latest stable versions of CMake: https://snapcraft.io/cmake

Perhaps consider recommended it be installed through that? On Ubuntu it is as simple as sudo snap install cmake --classic.

Thu, Dec 5, 9:25 AM · Trusted Firmware M

Tue, Nov 26

gyuri-szing edited the content of CMake buildsystem proposal.
Tue, Nov 26, 3:37 PM · Trusted Firmware A
gyuri-szing added a member for Trusted Firmware A: gyuri-szing.
Tue, Nov 26, 1:10 PM

Sep 13 2019

gyuri-szing closed T478: Configure Cmake Build - Error : Could NOT find Plantuml (missing: PLANTUML_VERSION) as Resolved.

Fix has been merged.

Sep 13 2019, 4:11 PM · Restricted Project, Unknown Object (Project)
gyuri-szing added a comment to T495: Docs: Distro supplied python packages may be too outdated.

I think we shall discuss the issue internally with the team first.

Sep 13 2019, 9:09 AM · Unknown Object (Project)

Sep 11 2019

gyuri-szing added a comment to T495: Docs: Distro supplied python packages may be too outdated.

What's wrong with virtualenv? How does it hurt the user experience?

Sep 11 2019, 4:53 PM · Unknown Object (Project)
gyuri-szing added a comment to T495: Docs: Distro supplied python packages may be too outdated.

Using pip instead of the Linux distributions package manager is considered bad practice because:

  • may end up having two version of a package installed which can trigger problems. (Packages installed by pip are not visible to apt and vice-versa.)
  • some pip packages have binary components. Some versions of these components may be not compatible to other binaries installed on the machine. This means only some versions of such pip packages are compatible with a specific distro.
Sep 11 2019, 3:30 PM · Unknown Object (Project)

Sep 4 2019

gyuri-szing closed T483: Docuent build fails if PDF generation tools are present as Resolved.

Fix merged.

Sep 4 2019, 1:42 PM · Trusted Firmware M

Sep 2 2019

gyuri-szing added a comment to T483: Docuent build fails if PDF generation tools are present.

Patch-set with the fix: https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/1884/

Sep 2 2019, 5:07 PM · Trusted Firmware M
gyuri-szing triaged T483: Docuent build fails if PDF generation tools are present as Low priority.
Sep 2 2019, 4:06 PM · Trusted Firmware M

Aug 28 2019

gyuri-szing closed T479: Configure Cmake Build - Error : Could NOT find Sphinx (missing: SPHINX_VERSION) as Resolved.

Fix was merged.

Aug 28 2019, 11:42 AM

Aug 27 2019

gyuri-szing added a comment to T479: Configure Cmake Build - Error : Could NOT find Sphinx (missing: SPHINX_VERSION) .

Can you please create a pull request with the fix?

Aug 27 2019, 1:10 PM

Aug 26 2019

gyuri-szing added a comment to T479: Configure Cmake Build - Error : Could NOT find Sphinx (missing: SPHINX_VERSION) .

Can you please double check you modification? Line 84-88 should be:

if(_SPHINX_VERSION)
        if(_SPHINX_VERSION MATCHES ".*sphinx-build[^0-9.]*([0-9.]+).*")
		string(REGEX REPLACE ".*sphinx-build ([0-9.]+).*" "\\1" SPHINX_VERSION "${_SPHINX_VERSION}")
	endif()
endif()
Aug 26 2019, 11:37 AM
gyuri-szing added a comment to T265: mbedtls-2.7.9 Build error on Cygwin platform.

Note: there was a patch pushed to work around the issue. See commit: https://git.trustedfirmware.org/trusted-firmware-m.git/commit/BuildMbedtls.cmake?id=a0f505c659e2af2ffa278d215045add711f7f2d8
The workaround only helps when the build is run from git-bash (or Msys/Msys2) or cygwin but will fail when building from cmd.exe (ln command not available).

Aug 26 2019, 11:31 AM

Aug 23 2019

gyuri-szing closed T409: Define the Design Proposal Process. as Resolved.

Process documentation has been merged (https://git.trustedfirmware.org/trusted-firmware-m.git/commit/?id=5c87323db941c3470eb4d4998981ced8b33cf84c) and process is in place.

Aug 23 2019, 3:47 PM · Trusted Firmware M
gyuri-szing added a comment to T479: Configure Cmake Build - Error : Could NOT find Sphinx (missing: SPHINX_VERSION) .

Newer versions of sphinx seem to print the version as:

$ sphinx-build.exe --version
sphinx-build 2.1.2

I think the ) character is making the reqexp on this line https://git.trustedfirmware.org/trusted-firmware-m.git/tree/cmake/FindSphinx.cmake#n85 fail to match.
Can you please check if changing line 85 like this helps?: if(_SPHINX_VERSION MATCHES ".*sphinx-build[^0-9.]*([0-9.]+).*")

Aug 23 2019, 3:01 PM
gyuri-szing added a comment to T265: mbedtls-2.7.9 Build error on Cygwin platform.

The same issue seems to affect mbedcrypto and this commit has the fix: https://github.com/ARMmbed/mbed-crypto/pull/118/commits/7346b312e12a54d77608fc6bb8aa3c55cf046d90
In TF-M build instructions (https://git.trustedfirmware.org/trusted-firmware-m.git/about/docs/user_guides/tfm_build_instruction.rst ) the following dependencies are defined:

  1. mbedtls v2.7.9
  2. mbedcrypto v1.1.0
Aug 23 2019, 11:41 AM
gyuri-szing assigned T478: Configure Cmake Build - Error : Could NOT find Plantuml (missing: PLANTUML_VERSION) to jainvikas8.

@jainvikas8: Thank you for volunteering! Please create a patch to fix the documentation.

Aug 23 2019, 9:25 AM · Restricted Project, Unknown Object (Project)
gyuri-szing reopened T478: Configure Cmake Build - Error : Could NOT find Plantuml (missing: PLANTUML_VERSION) as "Open".

That's a valid point, the documentation needs to be fixed.

Aug 23 2019, 9:01 AM · Restricted Project, Unknown Object (Project)
gyuri-szing closed T478: Configure Cmake Build - Error : Could NOT find Plantuml (missing: PLANTUML_VERSION) as Invalid.

Based on my investigations this is not a bug and no fix is needed.

Aug 23 2019, 8:36 AM · Restricted Project, Unknown Object (Project)
gyuri-szing added a comment to T478: Configure Cmake Build - Error : Could NOT find Plantuml (missing: PLANTUML_VERSION) .

Summary:

It is wrong to set PLANTUML_JAR_PATH as export PLANTUML_JAR_PATH="~/plantuml/plantuml.jar" and instead export PLANTUML_JAR_PATH=~/plantuml/plantuml.jar shall be used (Note: quotation marks removed).

Aug 23 2019, 8:34 AM · Restricted Project, Unknown Object (Project)

Jun 26 2019

gyuri-szing created T410: Add preprocessor based project content defintition techique.
Jun 26 2019, 12:09 PM · Trusted Firmware M
gyuri-szing added a comment to T409: Define the Design Proposal Process..

For the design proposal published to the TSC please refer to the archive of the TSC mailing-list: https://lists.trustedfirmware.org/mailman/listinfo/tsc .

Jun 26 2019, 9:11 AM · Trusted Firmware M
gyuri-szing triaged T409: Define the Design Proposal Process. as Normal priority.
Jun 26 2019, 9:08 AM · Trusted Firmware M

May 8 2019

gyuri-szing closed T341: Build: Fix documentation generation issues as Resolved.

Fix was merged.

May 8 2019, 10:52 AM · Trusted Firmware M

May 3 2019

gyuri-szing closed T331: Fix build if GNUARM_PATH is explicitly set as Resolved.

Fix was merged.

May 3 2019, 11:57 AM

May 2 2019

gyuri-szing added a comment to T265: mbedtls-2.7.9 Build error on Cygwin platform.

It seems the fix has been merged to mbedtls development branch. (See it https://github.com/ARMmbed/mbedtls/commit/7346b312e12a54d77608fc6bb8aa3c55cf046d90?diff=unified).
We may be able to update supported mbedtls version after the next mdbedtls release.

May 2 2019, 12:35 PM

May 1 2019

gyuri-szing added a comment to T331: Fix build if GNUARM_PATH is explicitly set.

I tested the behavior and found the following:

  • if GNUARM_PATH is set to point to the /bin directory of the GNUARM install tree, then the compiler is found ok. This behavior is not matching the documentation in FindGnuArm.cmake.
  • if GNUARM_PATH is set as mentioned above, but there is another version available on the PATH, then the one on the PATH gets used.
May 1 2019, 6:14 AM

Apr 30 2019

gyuri-szing added a comment to T309: Initial support for IAR Embedded Workbench for Arm tool chain.

A related change seems to be: https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/862/

Apr 30 2019, 10:06 AM · Trusted Firmware M

Apr 3 2019

gyuri-szing closed T19: Build issue related to Keil environment variables as Resolved.
Apr 3 2019, 2:19 PM · Unknown Object (Project)
gyuri-szing closed T228: Update build system to support latest cmake version. as Resolved.

Turned to be a documentation update task. Fixed in https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/661/ .

Apr 3 2019, 2:18 PM · Trusted Firmware M
gyuri-szing closed T238: Add support for building Doxygen documentation as Resolved.
Apr 3 2019, 2:13 PM · Unknown Object (Project)
gyuri-szing created T304: Incorrect build options for NS code.
Apr 3 2019, 1:22 PM · Trusted Firmware M

Mar 13 2019

gyuri-szing added a comment to T228: Update build system to support latest cmake version..

No. T95 needs deeper investigation to check what cmake version the fix supports and if all aspects are addressed. Response files not only affect the linker but the archiver too.
There was an important bugfix for response file handling merged into cmake 3.9 so we might need to drop support for anything below 3.10.

Mar 13 2019, 8:38 AM · Trusted Firmware M
gyuri-szing added a comment to T228: Update build system to support latest cmake version..

The response file problem is another ticket. See https://developer.trustedfirmware.org/T95

Mar 13 2019, 8:24 AM · Trusted Firmware M
gyuri-szing added a comment to T228: Update build system to support latest cmake version..

and what error do you get?

Mar 13 2019, 8:14 AM · Trusted Firmware M
gyuri-szing added a comment to T228: Update build system to support latest cmake version..

In my test environment I could not re-create any failure. Can you please provide more details about your case?

Mar 13 2019, 7:42 AM · Trusted Firmware M

Feb 28 2019

gyuri-szing added a comment to T228: Update build system to support latest cmake version..

After extensive testing no blocking issues could be identified and this effort turned to be a documentation update. See https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/661/
All mentioned cmake versions work fine win the build-system..

Feb 28 2019, 6:27 AM · Trusted Firmware M

Feb 27 2019

gyuri-szing added a comment to T265: mbedtls-2.7.9 Build error on Cygwin platform.

Thanks for the PR!

Feb 27 2019, 6:50 AM

Feb 26 2019

gyuri-szing added a comment to T265: mbedtls-2.7.9 Build error on Cygwin platform.

What is going to happen?
We had a discussion with the tech leads and decided to go forward with the current workaround. Meanwhile I contacted the mbedtls team to see when they can fix the issue. When mbdtls is fixed we will disable the workaround and update the documentation and thus support the latest version.

Feb 26 2019, 12:16 PM

Feb 25 2019

gyuri-szing added a comment to T265: mbedtls-2.7.9 Build error on Cygwin platform.

For me this seems to be an mbedtls bug. See: https://github.com/ARMmbed/mbedtls/issues/1496

Feb 25 2019, 5:35 PM
gyuri-szing added a comment to T265: mbedtls-2.7.9 Build error on Cygwin platform.

What CMake version are you using?

Feb 25 2019, 10:49 AM

Feb 7 2019

gyuri-szing added a comment to T95: Support CMake response file to enable linking many objects.

As a workaround try to make the path shorter. I refer to the directory where the tf-m, the mbedtls and the CMSIS5 working copy is as "work root" hereafter.
For this on windows:

  • you can use the subst command map the work root to a drive letter.
  • use the mklink command to link (hard link or junction point) the work root into c:\
Feb 7 2019, 10:33 AM · Trusted Firmware M
gyuri-szing added a comment to T238: Add support for building Doxygen documentation.

Changes in review: https://review.trustedfirmware.org/#/q/topic:Doxygen_support+(status:open+OR+status:merged)

Feb 7 2019, 7:16 AM · Unknown Object (Project)

Feb 6 2019

gyuri-szing triaged T238: Add support for building Doxygen documentation as Normal priority.
Feb 6 2019, 11:38 AM · Unknown Object (Project)

Feb 1 2019

gyuri-szing added a comment to T19: Build issue related to Keil environment variables.

Fix in review: https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/590/

Feb 1 2019, 4:16 PM · Unknown Object (Project)
gyuri-szing added a comment to T95: Support CMake response file to enable linking many objects.

Note: cmake release CMake 3.9.0-rc1 has an important bugfix for response file handling. Fixing this issue shall be done after build-system is updated to support latest cmake version. See T228.

Feb 1 2019, 11:03 AM · Trusted Firmware M
gyuri-szing created T228: Update build system to support latest cmake version..
Feb 1 2019, 10:55 AM · Trusted Firmware M

Nov 19 2018

gyuri-szing added a comment to T95: Support CMake response file to enable linking many objects.

First:
I wonder what cmake version you used when testing this change. According to my investigations 3.7 and the up-to-date version works different. Also there is an open issue for ARMCLang and response files: See: https://gitlab.kitware.com/cmake/cmake/issues/18457
Please add some details about your tests.

Nov 19 2018, 11:40 AM · Trusted Firmware M

Oct 19 2018

gyuri-szing created T121: Need a way to better origanize constant sections.
Oct 19 2018, 8:02 AM · Unknown Object (Project)

May 22 2018

gyuri-szing created Trusted Firmware.
May 22 2018, 11:53 AM

May 18 2018

gyuri-szing added a comment to T19: Build issue related to Keil environment variables.

After some investigation there seems to be multiple valid environment variable settings available for Keil. Depending on the license type either no configuration is needed, and Keil "automagically" solves the problem based on licensing configuration done in the IDE, or the environment variables need to be set properly.
In tfm_sw_requirement.md we already state (line 17) "Note* ARM compiler specific environment variable may need updating based on specific products and licenses as explained in ...". I think we can not go further than this, since compiler licensing is out of scope for the project, and we already pointed users to the appropriate source of information.
In reflection of all this I plan to take two actions:

  1. The licensing configuration check shall be removed from the build system. The warning shall be eliminated when the environment variables are missing sine this is a valid configuration.
  2. Discussion shall be stared to decide how to modify the documentation. It seems to be impossible to come up with something which works for all possible scenarios and licence types, so the change shall focus on making the note mentioned above more visible. In addition it is worth to consider adding a wiki page about this where we list working settings for specific environments.
May 18 2018, 12:01 PM · Unknown Object (Project)

May 17 2018

gyuri-szing claimed T19: Build issue related to Keil environment variables.
May 17 2018, 5:20 PM · Unknown Object (Project)