wmnt (Miklós Bálint)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2018, 6:38 AM (80 w, 1 d)

Recent Activity

Sep 9 2019

wmnt closed T141: Provide different build options for TF-M Core NSPM on NS client support as Wontfix.

Various aspects of this task are to be addressed in different broader conceptual changes in the code base.

Sep 9 2019, 2:17 PM · Trusted Firmware M

Jul 29 2019

wmnt reassigned T86: Optionally enable NS IRQ handling during service execution from wmnt to matetothpal.

As I believe the change has been implemented with the new scope, I'm re-assigning the ticket to Mate, the owner of the change.

Jul 29 2019, 6:36 AM · Trusted Firmware M

Jul 25 2019

wmnt assigned T174: Hide generated veneer format from its users by using wrapper macro to matetothpal.

Revisiting this topic:

Jul 25 2019, 5:34 PM · Trusted Firmware M

Jun 28 2019

wmnt updated subscribers of T378: Allow NS secure call in interrupt-disabled context.

TF-M does not need to be aware of any solution applied on the non-secure side to ensure serialization of secure calls. TF-M does not check the status of the NS lock, what it does is detects concurrent calls to the secure domain using a secure lock that is independent of the NS side implementation.
What we have in the repository for the NS lock is a reference implementation for a generic solution, but use of the non-secure lock is not - and cannot - be enforced by SPM. So if the NS OS you are using in your build exposes the functions you mention, your application is free to call them. It does not need support in the TF-M repository.
The only thing to note is that any proprietary implementation should ensure single entry to the secure domain as any concurrent calls would be flagged up as severe security violations. Any NS policy that avoids this scenario is transparent and acceptable.

Jun 28 2019, 9:29 AM · Trusted Firmware M

Jun 19 2019

wmnt edited the content of ELC-E 2018 Trusted Firmware-M Presentations.
Jun 19 2019, 6:41 AM
wmnt edited the content of TF-M Videos.
Jun 19 2019, 6:38 AM · Trusted Firmware M

Jun 6 2019

wmnt updated subscribers of T376: Allow NS secure call at pre-rtos stage.

The NS lock is initialized at a point in time when the scheduler is not yet started, therefore there is a single thread of execution on the NS side.
I agree it is safe to assume that in such a scenario, the only actor on the NS side is privileged and therefore is assumed to be in full control of execution, there are no separate protection domains within NSPE.
Secure lock is already set up so there's no risk of introducing new exploits with this change.

Jun 6 2019, 1:45 PM · Trusted Firmware M

Jun 5 2019

wmnt closed T329: Platform: create design pattern for platform-specific services as Resolved.

https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/951/ reviewed, approved, upstreamed

Jun 5 2019, 4:10 PM · Trusted Firmware M
wmnt renamed ELC-E 2018 Trusted Firmware-M Presentations from ELC-E Trusted Firmware-M Presentations to ELC-E 2018 Trusted Firmware-M Presentations.
Jun 5 2019, 3:30 PM

Jun 3 2019

wmnt added a comment to T329: Platform: create design pattern for platform-specific services.

Due to increased interest in this feature and no objections to the implementation concept, I'm raising the priority and will rebase my proposal change and do some polishing to make it a good candidate for upstreaming.
The suggested change of naming convention was discussed offline but was deemed unnecessary as there's limited risk of the feature being misunderstood and that is planned to be mitigated by improved documentation, while the design pattern evoked by the current name is hopefully a reasonable point of reference.

Jun 3 2019, 9:11 AM · Trusted Firmware M
wmnt raised the priority of T329: Platform: create design pattern for platform-specific services from Normal to High.
Jun 3 2019, 9:00 AM · Trusted Firmware M

May 31 2019

wmnt added a comment to T383: Core: Fix compile error on casting pointer type.

Fix for second issue:
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/1197/

May 31 2019, 3:14 PM · Trusted Firmware M

May 30 2019

wmnt closed T367: Platform: create common linker script and scatter file as Resolved.

Upstreamed

May 30 2019, 2:31 PM · Trusted Firmware M
wmnt added a comment to T383: Core: Fix compile error on casting pointer type.

Thanks, the change is approved.

May 30 2019, 12:40 PM · Trusted Firmware M
wmnt added a comment to T383: Core: Fix compile error on casting pointer type.

Could you provide details of the compiler configuration where you received this error?
We may need to update the configurations in CI to capture similar shortcomings.
I will execute some rudimentary tests in the meantime.

May 30 2019, 9:36 AM · Trusted Firmware M
wmnt triaged T383: Core: Fix compile error on casting pointer type as Normal priority.
May 30 2019, 9:31 AM · Trusted Firmware M

May 24 2019

wmnt added a comment to T367: Platform: create common linker script and scatter file.

See below review for corresponding change:
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/1152/

May 24 2019, 2:12 PM · Trusted Firmware M
wmnt triaged T367: Platform: create common linker script and scatter file as Normal priority.
May 24 2019, 2:10 PM · Trusted Firmware M

May 20 2019

wmnt edited the content of TF-M Videos.
May 20 2019, 2:19 PM · Trusted Firmware M
wmnt edited the content of TF-M Videos.
May 20 2019, 2:14 PM · Trusted Firmware M
wmnt edited the content of Videos From BKK'19 Linaro Connect.
May 20 2019, 10:57 AM

Apr 25 2019

wmnt updated subscribers of T329: Platform: create design pattern for platform-specific services.
Apr 25 2019, 3:06 PM · Trusted Firmware M
wmnt added a comment to T329: Platform: create design pattern for platform-specific services.

Please see the review below for proposal:
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/951/

Apr 25 2019, 3:06 PM · Trusted Firmware M
wmnt triaged T329: Platform: create design pattern for platform-specific services as Normal priority.
Apr 25 2019, 1:52 PM · Trusted Firmware M

Apr 11 2019

wmnt added a comment to T313: psa_call(...) prototype in the veneer function uses wrong parameters.

The transition from NS to S using the psa_call veneer has an implementation-defined layer of serialization in addition to what is prescribed in the PSA client API, necessary because of the limitations on parameter passing between security states.
The argument list mentioned above:

psa_status_t tfm_psa_call_veneer(psa_handle_t handle,
        const psa_invec *in_vecs,
        const psa_invec *out_vecs);

has those data types by design: both the invec array and outvec array are serialized to one invec each, i.e. two input parameters for the secure veneer, one containing the array of invecs, the other containing the array of outvecs.
From the veneer point of view both are constant input parameters, hence the const psa_invec type.
When extracting the arrays from these vectors in tfm_svcalls.c you can see the deserialization to the PSA-defined data types:

outptr = (psa_outvec *)((psa_invec *)args[2])->base;
out_num = ((psa_invec *)args[2])->len;
Apr 11 2019, 7:56 AM · Restricted Project

Feb 25 2019

wmnt updated the task description for T151: Remove unused platform dependencies from TF-M.
Feb 25 2019, 9:44 AM · Trusted Firmware M

Feb 21 2019

wmnt edited the content of Non-secure Client Management.
Feb 21 2019, 10:42 AM · Trusted Firmware M
wmnt edited the content of Non-secure Client Management.
Feb 21 2019, 10:41 AM · Trusted Firmware M

Feb 5 2019

wmnt added a project to T228: Update build system to support latest cmake version.: Trusted Firmware M.
Feb 5 2019, 2:07 PM · Trusted Firmware M

Jan 29 2019

wmnt added a comment to T194: invec/outvec checks TOCTOU.

Please note that secure SVC is running on highest priority. Execution of this code cannot be pre-empted by either NSPE or any external secure interrupt. This is essentially a critical section.

Jan 29 2019, 8:53 AM · Trusted Firmware M

Jan 10 2019

wmnt updated the task description for T39: manifest files PSA alignment.
Jan 10 2019, 4:14 PM · Trusted Firmware M
wmnt assigned T39: manifest files PSA alignment to KenLSoft.

Hi Ken,

Jan 10 2019, 4:13 PM · Trusted Firmware M
wmnt edited the content of Design.
Jan 10 2019, 2:15 PM · Trusted Firmware M
wmnt triaged T174: Hide generated veneer format from its users by using wrapper macro as Normal priority.
Jan 10 2019, 1:20 PM · Trusted Firmware M
wmnt closed T140: Add TF-M Core API for requests by Secure Partitions to SPM as Resolved.
Jan 10 2019, 12:26 PM · Trusted Firmware M
wmnt edited the content of Uniform Secure Service Signature.
Jan 10 2019, 11:10 AM · Trusted Firmware M

Jan 8 2019

wmnt reassigned T150: Memory region miss-configuration from wmnt to KenLSoft.
Jan 8 2019, 8:06 AM · Trusted Firmware M

Dec 19 2018

wmnt edited the content of Design.
Dec 19 2018, 12:27 PM · Trusted Firmware M
wmnt created Secure Partition Interrupt Handling.
Dec 19 2018, 12:09 PM · Trusted Firmware M

Dec 11 2018

wmnt edited the content of Design.
Dec 11 2018, 7:52 AM · Trusted Firmware M
wmnt added a project to Uniform Secure Service Signature: Trusted Firmware M.
Dec 11 2018, 7:36 AM · Trusted Firmware M

Dec 10 2018

wmnt added a comment to T100: Use psa_invec and psa_outvec in veneer functions.

Please see https://developer.trustedfirmware.org/w/tf_m/design/uniform_secure_service_signature/ for detailed design proposal

Dec 10 2018, 4:37 PM · Trusted Firmware M
wmnt created Uniform Secure Service Signature.
Dec 10 2018, 4:12 PM · Trusted Firmware M

Nov 23 2018

wmnt triaged T151: Remove unused platform dependencies from TF-M as Wishlist priority.
Nov 23 2018, 2:12 PM · Trusted Firmware M

Nov 19 2018

wmnt added a comment to T141: Provide different build options for TF-M Core NSPM on NS client support.

A bugfix is provided for incorrect default behaviour if NS client identification is turned off in the build environment in change:
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/378/

Nov 19 2018, 4:41 PM · Trusted Firmware M

Nov 14 2018

wmnt triaged T141: Provide different build options for TF-M Core NSPM on NS client support as High priority.
Nov 14 2018, 7:29 AM · Trusted Firmware M

Nov 13 2018

wmnt added a comment to T140: Add TF-M Core API for requests by Secure Partitions to SPM.

Implemented by https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/364/

Nov 13 2018, 12:57 PM · Trusted Firmware M
wmnt triaged T140: Add TF-M Core API for requests by Secure Partitions to SPM as Normal priority.
Nov 13 2018, 12:47 PM · Trusted Firmware M

Nov 12 2018

wmnt triaged T134: Enable privileged execution of PSA RoT services in isolation level 3 as Low priority.
Nov 12 2018, 7:33 AM · Trusted Firmware M
wmnt added a project to T71: Support GNU ARM tool-chain 7.3.1: Trusted Firmware M.
Nov 12 2018, 7:17 AM · Trusted Firmware M
wmnt added a project to T94: Data exchange b/w bootloader and runtime: Trusted Firmware M.
Nov 12 2018, 7:17 AM · Trusted Firmware M

Oct 20 2018

wmnt added a project to T33: Port secure partitions to threads : Trusted Firmware M.
Oct 20 2018, 3:08 PM · Trusted Firmware M
wmnt added a project to T35: Adapt TF-M HAL to support multicore systems : Trusted Firmware M.
Oct 20 2018, 3:08 PM · Restricted Project
wmnt added a project to T38: Create architecture dependent hierarchy TF-M: Trusted Firmware M.
Oct 20 2018, 3:07 PM · Trusted Firmware M
wmnt added a project to T31: Add secure thread Scheduler: Trusted Firmware M.
Oct 20 2018, 3:07 PM · Trusted Firmware M
wmnt added a project to T32: Implement secure IRQ handling : Trusted Firmware M.
Oct 20 2018, 3:07 PM · Trusted Firmware M
wmnt added a project to T34: Implement IPC as interaction layer between partitions : Trusted Firmware M.
Oct 20 2018, 3:04 PM · Trusted Firmware M
wmnt added a project to T36: Implement S/NS secure boot in twin v7M : Trusted Firmware M.
Oct 20 2018, 2:59 PM · Restricted Project
wmnt added a project to T37: Implement IPC over twin v7M communication HAL: Trusted Firmware M.
Oct 20 2018, 2:56 PM · Restricted Project
wmnt triaged T39: manifest files PSA alignment as Normal priority.
Oct 20 2018, 10:39 AM · Trusted Firmware M

Oct 19 2018

wmnt added a project to T86: Optionally enable NS IRQ handling during service execution: Trusted Firmware M.
Oct 19 2018, 8:55 AM · Trusted Firmware M

Oct 1 2018

wmnt added a comment to T67: Non-secure client identity API for secure services.

Design documented at https://developer.trustedfirmware.org/w/tf_m/design/ns_client_management/

Oct 1 2018, 7:05 PM
wmnt changed the visibility for Non-secure Client Management.
Oct 1 2018, 3:27 PM · Trusted Firmware M
wmnt created Non-secure Client Management.
Oct 1 2018, 3:08 PM · Trusted Firmware M

Sep 21 2018

wmnt closed T98: Core: refactor error handling scenarios as Resolved.

Change submitted.

Sep 21 2018, 2:02 PM · Trusted Firmware M

Sep 19 2018

wmnt claimed T98: Core: refactor error handling scenarios.
Sep 19 2018, 8:27 PM · Trusted Firmware M
wmnt closed T67: Non-secure client identity API for secure services as Resolved.

Change and related improvements upstreamed

Sep 19 2018, 8:27 PM
wmnt added a comment to T98: Core: refactor error handling scenarios.

https://review.trustedfirmware.org/#/c/191/ is a proposed resolution for this change.

Sep 19 2018, 2:57 PM · Trusted Firmware M
wmnt triaged T98: Core: refactor error handling scenarios as Normal priority.
Sep 19 2018, 2:53 PM · Trusted Firmware M

Sep 17 2018

wmnt updated subscribers of T86: Optionally enable NS IRQ handling during service execution.

Based on @gyuri-szing's comment on the review I split the change to two parts:
https://review.trustedfirmware.org/#/c/174/ only fixes the upstream to keep NS exceptions disabled during secure execution by default as is the current assumption for TF-M.
Change https://review.trustedfirmware.org/#/c/183/ introduces the switch. Gyorgy's comment can be debated separately this way without blocking the fix.

Sep 17 2018, 10:38 AM · Trusted Firmware M

Sep 7 2018

wmnt updated subscribers of T83: Move SST secure API to named section .
Sep 7 2018, 2:04 PM · Restricted Project
wmnt added a comment to T83: Move SST secure API to named section .

In my view we should investigate other options for having the API definitions stand out from the service internal files.
There is an ongoing effort to limit the number of steps that need to be taken in order to integrate a new partition into the system, or to disable/enable one that is already present.
I would therefore suggest to keep service API files in the service folder and not create a new location for them.

Sep 7 2018, 2:03 PM · Restricted Project

Sep 4 2018

wmnt updated subscribers of T86: Optionally enable NS IRQ handling during service execution.
Sep 4 2018, 3:27 PM · Trusted Firmware M
wmnt added a comment to T86: Optionally enable NS IRQ handling during service execution.

Change on review at:
https://review.trustedfirmware.org/#/c/174/

Sep 4 2018, 3:25 PM · Trusted Firmware M
wmnt triaged T86: Optionally enable NS IRQ handling during service execution as Normal priority.
Sep 4 2018, 3:24 PM · Trusted Firmware M
wmnt closed T66: Thread mode NS-S transition for secure services as Resolved.

The change has been merged on both branches

Sep 4 2018, 3:21 PM

Aug 24 2018

wmnt updated subscribers of T67: Non-secure client identity API for secure services.
Aug 24 2018, 8:54 PM
wmnt updated subscribers of T66: Thread mode NS-S transition for secure services.
Aug 24 2018, 8:54 PM
wmnt assigned T32: Implement secure IRQ handling to matetothpal.

Mate is working on the prototype while I'm writing the design document.

Aug 24 2018, 8:32 PM · Trusted Firmware M
wmnt added a comment to T66: Thread mode NS-S transition for secure services.

The same two changes for the feature-ipc branch:
https://review.trustedfirmware.org/#/c/145/
https://review.trustedfirmware.org/#/c/146/

Aug 24 2018, 7:22 PM
wmnt updated subscribers of T67: Non-secure client identity API for secure services.
Aug 24 2018, 8:57 AM
wmnt updated subscribers of T66: Thread mode NS-S transition for secure services.
Aug 24 2018, 8:57 AM

Aug 6 2018

wmnt claimed T67: Non-secure client identity API for secure services.
Aug 6 2018, 8:17 AM
wmnt triaged T67: Non-secure client identity API for secure services as Normal priority.
Aug 6 2018, 8:14 AM
wmnt triaged T66: Thread mode NS-S transition for secure services as Normal priority.
Aug 6 2018, 8:09 AM

Jun 26 2018

wmnt closed T21: replace secure partition integration layer with manifest files as Resolved.

https://issues.trustedfirmware.org/T39 to follow up on updates needed for newer version of PSA spec and updates, reduction of proprietary fields

Jun 26 2018, 6:37 PM · Restricted Project
wmnt added a comment to T21: replace secure partition integration layer with manifest files.

First batch of related changes upstreamed.
https://review.trustedfirmware.org/#/c/85/
https://review.trustedfirmware.org/#/c/86/
https://review.trustedfirmware.org/#/c/87/
https://review.trustedfirmware.org/#/c/88/
https://review.trustedfirmware.org/#/c/89/
https://review.trustedfirmware.org/#/c/90/
https://review.trustedfirmware.org/#/c/91/

Jun 26 2018, 6:26 PM · Restricted Project

Jun 21 2018

wmnt created T39: manifest files PSA alignment.
Jun 21 2018, 1:31 PM · Trusted Firmware M
wmnt triaged T38: Create architecture dependent hierarchy TF-M as Normal priority.
Jun 21 2018, 1:28 PM · Trusted Firmware M
wmnt created T37: Implement IPC over twin v7M communication HAL.
Jun 21 2018, 1:27 PM · Restricted Project
wmnt created T36: Implement S/NS secure boot in twin v7M .
Jun 21 2018, 1:25 PM · Restricted Project
wmnt triaged T35: Adapt TF-M HAL to support multicore systems as Normal priority.
Jun 21 2018, 1:25 PM · Restricted Project
wmnt triaged T34: Implement IPC as interaction layer between partitions as High priority.
Jun 21 2018, 1:24 PM · Trusted Firmware M
wmnt triaged T33: Port secure partitions to threads as Normal priority.
Jun 21 2018, 1:23 PM · Trusted Firmware M
wmnt triaged T32: Implement secure IRQ handling as High priority.
Jun 21 2018, 1:20 PM · Trusted Firmware M
wmnt triaged T31: Add secure thread Scheduler as High priority.
Jun 21 2018, 1:18 PM · Trusted Firmware M

Jun 1 2018

wmnt triaged T21: replace secure partition integration layer with manifest files as High priority.
Jun 1 2018, 12:46 PM · Restricted Project
wmnt closed T13: Core: Execute partition init functions in SP context as Resolved.

change merged

Jun 1 2018, 12:39 PM · Restricted Project
wmnt added a comment to T13: Core: Execute partition init functions in SP context.

change sent for review:
https://review.trustedfirmware.org/#/c/69/

Jun 1 2018, 12:38 PM · Restricted Project
wmnt closed T14: Make UART1 non-secure by default as Resolved.

change merged

Jun 1 2018, 12:37 PM · Restricted Project