Page MenuHomePhabricator

Trusted Firmware AProject
ActivePublic

Recent Activity

Thu, Feb 25

CJKay renamed Conventional Commits from Conventional Commits Sign-off to Conventional Commits.
Thu, Feb 25, 5:50 PM · Trusted Firmware A
CJKay added a comment to Conventional Commits.

Hi all, I suggest we move this discussion back to the mailing list so we can track the progression a bit more easily.

Thu, Feb 25, 5:38 PM · Trusted Firmware A
leon-chen-mtk created T887: [Question] Could CASSERT check PSCI_MAX_PWR_LVL be removed?.
Thu, Feb 25, 5:53 AM · Trusted Firmware A

Tue, Feb 23

jenswi-linaro added a comment to Conventional Commits.

Vote: Jens Wiklander (qemu and OP-TEE Dispatcher): disapprove
I too have concerns with adding more tags to the the subject of the commit message.

Tue, Feb 23, 7:17 AM · Trusted Firmware A

Mon, Feb 22

joannafarley-arm added a comment to Conventional Commits.

We have had some contact with some other TF.org projects but was not aware of the Mbed TLS project had its own solution already. Its already acknowledged we should to look for a common solution across projects. This discussion is part of that engaging. We do need to make a decision at some point.

Mon, Feb 22, 5:56 PM · Trusted Firmware A
vwadekar added a comment to Conventional Commits.

Hi, I agree with @danh-arm. We should try to come up with a unified guidance, if possible. I think we will have a better idea of the path forward, once most of the maintainers respond. Personally, I would be open to merging both approaches to get the best of both worlds.

Mon, Feb 22, 5:46 PM · Trusted Firmware A
gyuri-szing added a comment to Conventional Commits.

I think tags in the subject of the commit message are problematic in general. Since commits are expected to capture "logical unit of change", the granularity of tags and commit scope often mismatches. While not mandated in the "Contributors Guide" sections, some commits indeed use tags already (i.e. libc, spmd, docs, etc..). What if a "logical unit of change" affects multiple components (i.e. a fix affects both libc and spmd)?

Mon, Feb 22, 5:42 PM · Trusted Firmware A
danh-arm added a comment to Conventional Commits.

Hi, I just want to make you aware that the Mbed TLS project has a different, home-rolled solution to this problem:
https://github.com/ARMmbed/mbedtls/blob/development/ChangeLog.d/00README.md

Mon, Feb 22, 3:38 PM · Trusted Firmware A

Sun, Feb 21

vwadekar added a comment to Conventional Commits.

Yes, I have found that 50 chars is not enough to describe commits many times. Adding a tag would mean sacrificing space. But I am open to adding this tag to the commit message instead of the header. We already plan to add tags to the message anyways?

Sun, Feb 21, 6:24 PM · Trusted Firmware A
raghuncstate added a comment to Conventional Commits.

I think this is generally a good move. The transition period will be ugly and unavoidable but we should reap the benefits of it long term. I do agree with Varun's concern about using tags in the headers but it is a trade-off we will have to make for the benefits standard commits offers.
Varun, is the format <conventional commit tag>:<plat> or <submodule>:<short message> not sufficient? I dont think we want to pack too much into the header any way in terms of what the commit is doing.

Sun, Feb 21, 5:38 PM · Trusted Firmware A

Fri, Feb 19

vwadekar added a comment to Conventional Commits.

Vote: <Varun Wadekar> (<Tegra>): <disapprove>

Fri, Feb 19, 11:47 PM · Trusted Firmware A
CJKay created an object: Conventional Commits.
Fri, Feb 19, 11:45 AM · Trusted Firmware A

Dec 2 2020

madhukar-Arm added a comment to T868: TF-A Bug.

Hi,
A developer submitted a patch which closely relates to this issue. Please give your feedback here: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/7314

Dec 2 2020, 6:48 PM · TF-A Bug, Trusted Firmware A

Nov 30 2020

madhukar-Arm added a comment to T868: TF-A Bug.

Hi,
Please use personal email and git configs/identity to push the patch to trustedfirmware.org. Few developers from the tf-a community have done this. Here is a link to contribution guidelines:

Nov 30 2020, 10:28 PM · TF-A Bug, Trusted Firmware A

Nov 28 2020

nickfrasher794 added a comment to T868: TF-A Bug.
Nov 28 2020, 12:37 PM · TF-A Bug, Trusted Firmware A
yuezhiran added a comment to T868: TF-A Bug.

Thanks for your reply. It is difficult to submit code to community or Gerrit using company's account and system. So, I wonder whether it's permitted to upload by providing modifications or “git send-email” with patches.

Nov 28 2020, 4:17 AM · TF-A Bug, Trusted Firmware A

Nov 19 2020

madhukar-Arm added a comment to T868: TF-A Bug.

Hi,
Yeah, looks like such a large system with numerous clusters will run into an issue with the current limitation of "lock_index" being "unsigned char". Please go ahead and submit a patch for review:

Nov 19 2020, 6:23 PM · TF-A Bug, Trusted Firmware A
yuezhiran added a comment to T868: TF-A Bug.

Yes, The power domain topology of the system can be described as 8 sockets, each socket with 10 clusters and each cluster with 8 cores. We just consider a system like this might face the constraint mentioned above, and we must modify the declaration of lock_index to solve this problem. Feature, more and more interconnected system, with numerous cpus, might face the same problem.

Nov 19 2020, 12:49 PM · TF-A Bug, Trusted Firmware A

Nov 18 2020

madhukar-Arm updated subscribers of T868: TF-A Bug.
Nov 18 2020, 5:54 PM · TF-A Bug, Trusted Firmware A
madhukar-Arm added a comment to T868: TF-A Bug.

Hi,
The struct "non_cpu_pwr_domain_node" represents a non-leaf power domain in an SoC such as a logical cluster. As you mentioned, the lock_index declaration with "unsigned char" limits such non-cpu power domains to 64. I believe it doesn't restrict the number of CPUs in a system to be <= 64. Do you currently face an issue with PSCI implementation due to the above constraint? Can you advise what is the power domain topology of your system? I think the lock_index can be expanded using "unsigned int" if needed.

Nov 18 2020, 5:53 PM · TF-A Bug, Trusted Firmware A
yuezhiran created T868: TF-A Bug.
Nov 18 2020, 3:06 AM · TF-A Bug, Trusted Firmware A

Nov 6 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:51 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:50 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:47 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:46 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:44 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:43 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:43 PM · Trusted Firmware A

Sep 27 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Sep 27 2020, 3:59 PM · Trusted Firmware A

Aug 28 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Aug 28 2020, 9:25 AM · Trusted Firmware A

Aug 27 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Aug 27 2020, 3:47 PM · Trusted Firmware A

Aug 26 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Aug 26 2020, 2:12 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Aug 26 2020, 2:11 PM · Trusted Firmware A

Aug 12 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Aug 12 2020, 1:11 PM · Trusted Firmware A

Aug 10 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Aug 10 2020, 9:56 AM · Trusted Firmware A

Jul 22 2020

brianq-ti removed a member for Trusted Firmware A: brianq-ti.
Jul 22 2020, 9:06 PM
brianq-ti removed a watcher for Trusted Firmware A: brianq-ti.
Jul 22 2020, 9:06 PM
brianq-ti added a watcher for Trusted Firmware A: brianq-ti.
Jul 22 2020, 9:05 PM
brianq-ti added a member for Trusted Firmware A: brianq-ti.
Jul 22 2020, 9:05 PM
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jul 22 2020, 3:52 PM · Trusted Firmware A

Jul 2 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jul 2 2020, 3:23 PM · Trusted Firmware A

Jun 26 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jun 26 2020, 1:43 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jun 26 2020, 1:42 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jun 26 2020, 9:01 AM · Trusted Firmware A

Jun 23 2020

wlozano0collabora added a comment to T762: RK3399_BAUDRATE default value.

Thanks for your comments and clarification. I should have updated this ticket with the information provided in the mail list, in order to keep them in sync.

Jun 23 2020, 8:16 PM · Trusted Firmware A, TF-A Bug

Jun 19 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jun 19 2020, 4:00 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jun 19 2020, 1:01 PM · Trusted Firmware A
joannafarley-arm created an object: Tf-a-tech-forum-scheduling.
Jun 19 2020, 12:53 PM · Trusted Firmware A
tchebb added a comment to T762: RK3399_BAUDRATE default value.

I noticed this as well, and I was on the verge of submitting a patch until I looked into it further and decided that the current default is justifiable.

Jun 19 2020, 5:04 AM · Trusted Firmware A, TF-A Bug

Jun 3 2020

wlozano0collabora updated the task description for T762: RK3399_BAUDRATE default value.
Jun 3 2020, 4:42 PM · Trusted Firmware A, TF-A Bug