Page MenuHomePhabricator

Trusted Firmware AProject
ActivePublic

Recent Activity

Jul 14 2021

joannafarley-arm added a comment to T949: TF-A Module Testcase.

The TF-A project uses the OpenCI project https://www.trustedfirmware.org/projects/open-ci/ to provide "Daily" and "Gerrit patch review" testing through a Jenkins infrastructure system with jobs visible here https://ci.trustedfirmware.org and these make use of tests defined in the TF-A Tests repository and from other reposititories. Please refer to the OpenCI documentation for more information https://tf-ci-users-guide.readthedocs.io/en/latest/

Jul 14 2021, 8:46 AM · Trusted Firmware A
yuezhiran triaged T949: TF-A Module Testcase as Normal priority.
Jul 14 2021, 6:32 AM · Trusted Firmware A

Jul 2 2021

abhishek-pandit added a member for Trusted Firmware A: abhishek-pandit.
Jul 2 2021, 7:13 PM
abhishek-pandit added a member for Trusted Firmware A: garymorrison-arm.
Jul 2 2021, 7:12 PM

Jun 24 2021

pgeorgi added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Given that there's no activity to get the submission rule issues in 9990 resolved, I followed CJKay's and jwerner's instructions and made https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/10415, hopefully more ready for inclusion.

Jun 24 2021, 4:40 PM · Trusted Firmware A

Jun 22 2021

Curacaoyang merged T931: the way to set pl011's UARTFBRD is differnt from the descrirtion in PL011 Technical Reference Manual into T932: the way to set pl011's UARTFBRD is differnt from the descrirtion in PL011 Technical Reference Manual.
Jun 22 2021, 9:03 AM · Trusted Firmware A
Curacaoyang merged task T931: the way to set pl011's UARTFBRD is differnt from the descrirtion in PL011 Technical Reference Manual into T932: the way to set pl011's UARTFBRD is differnt from the descrirtion in PL011 Technical Reference Manual.
Jun 22 2021, 9:03 AM · Trusted Firmware A
Curacaoyang updated the task description for T931: the way to set pl011's UARTFBRD is differnt from the descrirtion in PL011 Technical Reference Manual.
Jun 22 2021, 4:21 AM · Trusted Firmware A
Curacaoyang added a project to T932: the way to set pl011's UARTFBRD is differnt from the descrirtion in PL011 Technical Reference Manual: Trusted Firmware A.
Jun 22 2021, 4:21 AM · Trusted Firmware A
Curacaoyang created T931: the way to set pl011's UARTFBRD is differnt from the descrirtion in PL011 Technical Reference Manual.
Jun 22 2021, 4:15 AM · Trusted Firmware A

Jun 3 2021

joannafarley-arm added a comment to T395: support platform for rockchip px30.

FYI I removed the previous SPAM comment.

Jun 3 2021, 11:39 AM · Trusted Firmware A
elmadavis added a comment to T395: support platform for rockchip px30.
Jun 3 2021, 10:57 AM · Trusted Firmware A

May 13 2021

nullr0ute added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Thanks, I submitted the following based on CJKay's patch above:
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/9990

May 13 2021, 11:15 AM · Trusted Firmware A

May 11 2021

yuezhiran closed T868: TF-A Bug as Resolved.

The problem has been solved.

May 11 2021, 1:40 PM · TF-A Bug, Trusted Firmware A

May 5 2021

jwerner added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Yes, the __sramdata in the declaration is a mistake, the correct target section for that global needs to be .pmusram.data. This used to be in .sram.data once upon a time but then the suspend.c stuff got added and required it to be moved to PMUSRAM. I guess they forgot to update that part in the declaration and since the old GCC seemed to silently prefer the attribute in the definition, nobody noticed. Please apply CJKay's first patch to fix the warning.

May 5 2021, 5:52 PM · Trusted Firmware A
CJKay added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

I can only assume GCC <11 simply didn't have this warning, but it looks legitimate.

May 5 2021, 1:14 PM · Trusted Firmware A
odeprez added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Ok thanks.

May 5 2021, 12:35 PM · Trusted Firmware A
nullr0ute added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

It's native aarch64, the command line I'm using is:
make HOSTCC="gcc $RPM_OPT_FLAGS" CROSS_COMPILE="" PLAT=rk3399 bl31

May 5 2021, 10:03 AM · Trusted Firmware A
odeprez added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Is this building natively on arm64 host?

May 5 2021, 9:31 AM · Trusted Firmware A
nullr0ute added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

I'm using Fedora 34/35 with the distribution toolchain (gcc 11.1 GA)

May 5 2021, 9:26 AM · Trusted Firmware A
odeprez added a comment to T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.

Can you please provide the link to the gcc11 toolchain you use?
AFAIK latest public Arm release of the cross compiler toolchains is 10.2 (https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-a/downloads)

May 5 2021, 9:19 AM · Trusted Firmware A

May 4 2021

nullr0ute created T925: ATF v2.5-rc0 fails to build rk3399 support with gcc11.
May 4 2021, 9:08 PM · Trusted Firmware A

Mar 30 2021

nathan-menhorn created T912: OP-TEE OS 3.11.0 Hangs at opteed_enter_sp on Cold Boot.
Mar 30 2021, 4:11 PM · TF-A Bug, Trusted Firmware A

Mar 15 2021

sandrine-bailleux-arm edited the content of Getting started: Contributing TF-A patches on www.trustedfirmware.org.
Mar 15 2021, 9:28 AM · Trusted Firmware A

Feb 25 2021

CJKay renamed Conventional Commits from Conventional Commits Sign-off to Conventional Commits.
Feb 25 2021, 5:50 PM · Trusted Firmware A
CJKay added a comment to Conventional Commits.

Hi all, I suggest we move this discussion back to the mailing list so we can track the progression a bit more easily.

Feb 25 2021, 5:38 PM · Trusted Firmware A
leon-chen-mtk created T887: [Question] Could CASSERT check PSCI_MAX_PWR_LVL be removed?.
Feb 25 2021, 5:53 AM · Trusted Firmware A

Feb 23 2021

jenswi-linaro added a comment to Conventional Commits.

Vote: Jens Wiklander (qemu and OP-TEE Dispatcher): disapprove
I too have concerns with adding more tags to the the subject of the commit message.

Feb 23 2021, 7:17 AM · Trusted Firmware A

Feb 22 2021

joannafarley-arm added a comment to Conventional Commits.

We have had some contact with some other TF.org projects but was not aware of the Mbed TLS project had its own solution already. Its already acknowledged we should to look for a common solution across projects. This discussion is part of that engaging. We do need to make a decision at some point.

Feb 22 2021, 5:56 PM · Trusted Firmware A
vwadekar added a comment to Conventional Commits.

Hi, I agree with @danh-arm. We should try to come up with a unified guidance, if possible. I think we will have a better idea of the path forward, once most of the maintainers respond. Personally, I would be open to merging both approaches to get the best of both worlds.

Feb 22 2021, 5:46 PM · Trusted Firmware A
gyuri-szing added a comment to Conventional Commits.

I think tags in the subject of the commit message are problematic in general. Since commits are expected to capture "logical unit of change", the granularity of tags and commit scope often mismatches. While not mandated in the "Contributors Guide" sections, some commits indeed use tags already (i.e. libc, spmd, docs, etc..). What if a "logical unit of change" affects multiple components (i.e. a fix affects both libc and spmd)?

Feb 22 2021, 5:42 PM · Trusted Firmware A
danh-arm added a comment to Conventional Commits.

Hi, I just want to make you aware that the Mbed TLS project has a different, home-rolled solution to this problem:
https://github.com/ARMmbed/mbedtls/blob/development/ChangeLog.d/00README.md

Feb 22 2021, 3:38 PM · Trusted Firmware A

Feb 21 2021

vwadekar added a comment to Conventional Commits.

Yes, I have found that 50 chars is not enough to describe commits many times. Adding a tag would mean sacrificing space. But I am open to adding this tag to the commit message instead of the header. We already plan to add tags to the message anyways?

Feb 21 2021, 6:24 PM · Trusted Firmware A
raghuncstate added a comment to Conventional Commits.

I think this is generally a good move. The transition period will be ugly and unavoidable but we should reap the benefits of it long term. I do agree with Varun's concern about using tags in the headers but it is a trade-off we will have to make for the benefits standard commits offers.
Varun, is the format <conventional commit tag>:<plat> or <submodule>:<short message> not sufficient? I dont think we want to pack too much into the header any way in terms of what the commit is doing.

Feb 21 2021, 5:38 PM · Trusted Firmware A

Feb 19 2021

vwadekar added a comment to Conventional Commits.

Vote: <Varun Wadekar> (<Tegra>): <disapprove>

Feb 19 2021, 11:47 PM · Trusted Firmware A
CJKay created an object: Conventional Commits.
Feb 19 2021, 11:45 AM · Trusted Firmware A

Dec 2 2020

madhukar-Arm added a comment to T868: TF-A Bug.

Hi,
A developer submitted a patch which closely relates to this issue. Please give your feedback here: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/7314

Dec 2 2020, 6:48 PM · TF-A Bug, Trusted Firmware A

Nov 30 2020

madhukar-Arm added a comment to T868: TF-A Bug.

Hi,
Please use personal email and git configs/identity to push the patch to trustedfirmware.org. Few developers from the tf-a community have done this. Here is a link to contribution guidelines:

Nov 30 2020, 10:28 PM · TF-A Bug, Trusted Firmware A

Nov 28 2020

nickfrasher794 added a comment to T868: TF-A Bug.
Nov 28 2020, 12:37 PM · TF-A Bug, Trusted Firmware A
yuezhiran added a comment to T868: TF-A Bug.

Thanks for your reply. It is difficult to submit code to community or Gerrit using company's account and system. So, I wonder whether it's permitted to upload by providing modifications or “git send-email” with patches.

Nov 28 2020, 4:17 AM · TF-A Bug, Trusted Firmware A

Nov 19 2020

madhukar-Arm added a comment to T868: TF-A Bug.

Hi,
Yeah, looks like such a large system with numerous clusters will run into an issue with the current limitation of "lock_index" being "unsigned char". Please go ahead and submit a patch for review:

Nov 19 2020, 6:23 PM · TF-A Bug, Trusted Firmware A
yuezhiran added a comment to T868: TF-A Bug.

Yes, The power domain topology of the system can be described as 8 sockets, each socket with 10 clusters and each cluster with 8 cores. We just consider a system like this might face the constraint mentioned above, and we must modify the declaration of lock_index to solve this problem. Feature, more and more interconnected system, with numerous cpus, might face the same problem.

Nov 19 2020, 12:49 PM · TF-A Bug, Trusted Firmware A

Nov 18 2020

madhukar-Arm updated subscribers of T868: TF-A Bug.
Nov 18 2020, 5:54 PM · TF-A Bug, Trusted Firmware A
madhukar-Arm added a comment to T868: TF-A Bug.

Hi,
The struct "non_cpu_pwr_domain_node" represents a non-leaf power domain in an SoC such as a logical cluster. As you mentioned, the lock_index declaration with "unsigned char" limits such non-cpu power domains to 64. I believe it doesn't restrict the number of CPUs in a system to be <= 64. Do you currently face an issue with PSCI implementation due to the above constraint? Can you advise what is the power domain topology of your system? I think the lock_index can be expanded using "unsigned int" if needed.

Nov 18 2020, 5:53 PM · TF-A Bug, Trusted Firmware A
yuezhiran created T868: TF-A Bug.
Nov 18 2020, 3:06 AM · TF-A Bug, Trusted Firmware A

Nov 6 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:51 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:50 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:47 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:46 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:44 PM · Trusted Firmware A