Thanks for your comments and clarification. I should have updated this ticket with the information provided in the mail list, in order to keep them in sync.

I noticed this as well, and I was on the verge of submitting a patch until I looked into it further and decided that the current default is justifiable.

Hello Matteo,
Yes, you are right ID_AA64PFR0_EL1 must be used. Thanks for spotting this!

OK. Regarding naming suggestions, I like func_noabi/endfunc_noabi the most. The reason why I am discounting asmfunc/endasmfunc is because a function implemented in assembly language might still respect the ABI.
I suggest we start with func_noabi/endfunc_noabi and continue the discussion on the patch on Gerrit. Unfortunately, this ticketing system does not have the same visibility as Gerrit or the mailing list and not everyone subscribe to these.

Hi @sandrine-bailleux-arm
Ok, In order to safe iterations.
I plan to suggest a new macro which does the followin

• creates a new section - as func does
• sets the alginment - as func does
• sets the type
• together with the counterpart end??? is sets the .size

. Proposals for names

• func_noabi/endfunc_noabi - a non-abi conformant function
• asmfunc/endasmfunc - a assembly routine/function
• sym/endsym - short, but the name does not imply that it actually creates a block of code/own section
• ...

Current gerrit proposal to fix this can be found in https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3749 (and related preceding commits).

I can try end of the week. Thanks.

Corrected with the following commit that has just been merged:
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3518

This makes sense to me. Would you mind preparing a patch that removes the func macro on el3_exit and post it on review.trustedfirmware.org ?

I took the patch and put it into gerrit. Due to a lack of name or email address I used mine. Happy to change that once I learn about the real identity of "armlabs".

Hi Andrew, yes the change looks fine.

If this generally looks okay I'm happy to follow https://developer.trustedfirmware.org/w/tf_a/gerrit-getting-started/ and push this for review according to the TF-A workflow.

Again, this is for now staged via Pete's tree and you can view the pull request here - https://github.com/pbatard/arm-trusted-firmware/pull/2

This has been fixed in https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/2789.

I will send the patches shortly