Trusted Firmware AProject
ActivePublic

Recent Activity

Today

raghuncstate added a comment to T334: Barrier in sprt_queue.c.

Thanks guys! The dmbish() is not a huge deal. Just get a little nervous when i see barriers and don't completely understand why it is there. :)

Tue, May 21, 10:14 PM · TF-A Question, Trusted Firmware A
soby-mathew added a comment to T334: Barrier in sprt_queue.c.

Ah, You are right. Having taken a look at it again, yes, the SP-> SPM communication is register based and this spm_response_add() is invoked by SPM to push to a buffer within EL3 (its not a shared buffer between different ELs). I suspect the shared buffer primitives were written with shared buffer scenario in mind and the current prototype implementation does not optimize it for the case when the buffer is within EL3.

Tue, May 21, 9:03 PM · TF-A Question, Trusted Firmware A
raghuncstate added a comment to T334: Barrier in sprt_queue.c.

Thanks Paul, Soby.
spm_response_*() currently cannot invoked by any secure partition since the responses[] array is in EL3 space. Is this not the case ? or is it the expectation that the responses array will be mapped to secure EL0 some time in the future? I don't see how a secure partition can invoke spm_response_* other than through an SMC, in which case we are already in EL3 context and dont require the dmbish(), as Paul pointed. I understand your argument for sprt_queue_*, since they are invoked by EL3 and the secure partition.

Tue, May 21, 4:33 PM · TF-A Question, Trusted Firmware A
soby-mathew added a comment to T334: Barrier in sprt_queue.c.

Who is the lockless reader for spm_response_add() and spm_response_get()?

Tue, May 21, 3:23 PM · TF-A Question, Trusted Firmware A
pbeesley-arm added a comment to T334: Barrier in sprt_queue.c.

Apologies for the delay. I've had a look into the spm_buffers.c file and I understand your query is around the dmbish() that's performed shortly before releasing the lock in both spm_response_add() and spm_response_get().

Tue, May 21, 1:57 PM · TF-A Question, Trusted Firmware A
pbeesley-arm updated subscribers of T334: Barrier in sprt_queue.c.
Tue, May 21, 12:40 PM · TF-A Question, Trusted Firmware A

Yesterday

sandeepbrcm added a member for Trusted Firmware A: sandeepbrcm.
Mon, May 20, 3:08 AM

Mon, May 13

raghuncstate added a comment to T334: Barrier in sprt_queue.c.

anything ?

Mon, May 13, 6:58 PM · TF-A Question, Trusted Firmware A
pbeesley-arm added a comment to T335: Bug in rdmem_attr_to_mmap_attr in spm_xlat.c.

Thanks for taking a look and providing confirmation! :)

Mon, May 13, 9:43 AM · TF-A Bug, Trusted Firmware A
pbeesley-arm closed T335: Bug in rdmem_attr_to_mmap_attr in spm_xlat.c as Wontfix.
Mon, May 13, 9:41 AM · TF-A Bug, Trusted Firmware A
jts-arm closed T349: Test Task as Invalid.
Mon, May 13, 9:28 AM · Trusted Firmware A
jts-arm created T349: Test Task.
Mon, May 13, 9:27 AM · Trusted Firmware A
jts-arm changed the visibility for Q22: Test TF-A question.
Mon, May 13, 8:59 AM · Trusted Firmware A

Sat, May 11

raghuncstate added a comment to T335: Bug in rdmem_attr_to_mmap_attr in spm_xlat.c.

Thanks for taking a look and providing confirmation! :)

Sat, May 11, 1:49 AM · TF-A Bug, Trusted Firmware A

Fri, May 10

pbeesley-arm added a comment to T335: Bug in rdmem_attr_to_mmap_attr in spm_xlat.c.

Hello. Thanks for your report.

Fri, May 10, 12:46 PM · TF-A Bug, Trusted Firmware A

Wed, May 8

raghuncstate added a comment to T334: Barrier in sprt_queue.c.

Thanks. Missed the lockless reader of the queue. Who is the lockless reader for spm_response_add() and spm_response_get()?

Wed, May 8, 11:40 PM · TF-A Question, Trusted Firmware A
antonio-nino-diaz-arm added a comment to T334: Barrier in sprt_queue.c.

A secure partition may be reading from the queue from CPU1 at the same time as CPU0 pushes a new request. If this happens, it is needed that the stores are seen in the same order by all observers of the system.

Wed, May 8, 2:54 PM · TF-A Question, Trusted Firmware A
soby-mathew assigned T334: Barrier in sprt_queue.c to pbeesley-arm.
Wed, May 8, 9:50 AM · TF-A Question, Trusted Firmware A
soby-mathew assigned T335: Bug in rdmem_attr_to_mmap_attr in spm_xlat.c to pbeesley-arm.
Wed, May 8, 9:49 AM · TF-A Bug, Trusted Firmware A
soby-mathew added a comment to T290: Example task/Issue 2.

Example comment 3

Wed, May 8, 9:47 AM · TF-A General, Trusted Firmware A
soby-mathew changed the visibility for T335: Bug in rdmem_attr_to_mmap_attr in spm_xlat.c.
Wed, May 8, 9:45 AM · TF-A Bug, Trusted Firmware A

Mon, May 6

raghuncstate changed the visibility for T335: Bug in rdmem_attr_to_mmap_attr in spm_xlat.c.
Mon, May 6, 11:04 PM · TF-A Bug, Trusted Firmware A
raghuncstate added a watcher for Trusted Firmware A: raghuncstate.
Mon, May 6, 10:54 PM

Sun, May 5

raghuncstate updated the task description for T334: Barrier in sprt_queue.c.
Sun, May 5, 9:09 PM · TF-A Question, Trusted Firmware A
raghuncstate triaged T334: Barrier in sprt_queue.c as Normal priority.
Sun, May 5, 9:07 PM · TF-A Question, Trusted Firmware A

Thu, May 2

kennyliang-mtk added a comment to T314: Initialize platform for MediaTek mt8183.

According to Hung-Te's comment,
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/860#message-233c99d5_765db5d9
I split the initial commit to several smaller patches.

Thu, May 2, 1:14 PM · Trusted Firmware A
kennyliang-mtk added a comment to T314: Initialize platform for MediaTek mt8183.

According to Hung-Te's comment,
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/860#message-233c99d5_765db5d9
I split the initial commit to several smaller patches.

Thu, May 2, 1:12 PM · Trusted Firmware A

Apr 18 2019

Z1NZ removed a watcher for Trusted Firmware A: Z1NZ.
Apr 18 2019, 5:01 PM

Apr 17 2019

jts-arm added a comment to T314: Initialize platform for MediaTek mt8183.

Hello kennyliang-mtk,

Apr 17 2019, 10:28 AM · Trusted Firmware A
Z1NZ added a watcher for Trusted Firmware A: Z1NZ.
Apr 17 2019, 8:23 AM
kennyliang-mtk added a comment to T314: Initialize platform for MediaTek mt8183.
In T314#3510, @jts-arm wrote:

Excuse me, how do I link the commit,
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/860
to this task?

Hello kennyliang-mtk,
the link to the code review that you provided seems fine to me. Unless you had something more in mind?

John

Apr 17 2019, 7:15 AM · Trusted Firmware A

Apr 12 2019

jts-arm added a comment to T314: Initialize platform for MediaTek mt8183.

Excuse me, how do I link the commit,
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/860
to this task?

Apr 12 2019, 11:58 AM · Trusted Firmware A
kennyliang-mtk raised the priority of T314: Initialize platform for MediaTek mt8183 from Normal to Needs Triage.
Apr 12 2019, 8:03 AM · Trusted Firmware A
kennyliang-mtk added a comment to T314: Initialize platform for MediaTek mt8183.

Excuse me, how do I link the commit,
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/860
to this task?
Thanks.

Apr 12 2019, 7:57 AM · Trusted Firmware A
kennyliang-mtk updated subscribers of T314: Initialize platform for MediaTek mt8183.
Apr 12 2019, 7:56 AM · Trusted Firmware A
kennyliang-mtk triaged T314: Initialize platform for MediaTek mt8183 as Normal priority.
Apr 12 2019, 7:13 AM · Trusted Firmware A

Apr 11 2019

sandrine-bailleux-arm edited the content of Getting started: Contributing TF-A patches on www.trustedfirmware.org.
Apr 11 2019, 1:50 PM · Trusted Firmware A

Apr 8 2019

sandrine-bailleux-arm removed a project from T308: Coverity defect #337491: TF-A Bug.
Apr 8 2019, 8:15 AM · Trusted Firmware A
sandrine-bailleux-arm created T308: Coverity defect #337491.
Apr 8 2019, 7:48 AM · Trusted Firmware A

Apr 5 2019

joannafarley-arm added a comment to T290: Example task/Issue 2.

Example comment 2

Apr 5 2019, 10:24 AM · TF-A General, Trusted Firmware A
joannafarley-arm added a comment to T290: Example task/Issue 2.

Example comment 1

Apr 5 2019, 10:24 AM · TF-A General, Trusted Firmware A
joannafarley-arm moved T306: Dummy from Backlog to Closed on the Trusted Firmware A board.
Apr 5 2019, 10:23 AM · Trusted Firmware A, TF-A Info

Apr 4 2019

joannafarley-arm closed T306: Dummy as Resolved.
Apr 4 2019, 3:19 PM · Trusted Firmware A, TF-A Info
ambroise-arm added a project to T306: Dummy: Trusted Firmware A.
Apr 4 2019, 3:17 PM · Trusted Firmware A, TF-A Info
ambroise-arm added a member for Trusted Firmware A: ambroise-arm.
Apr 4 2019, 3:14 PM

Apr 3 2019

sandrine-bailleux-arm edited the content of Getting started: Contributing TF-A patches on www.trustedfirmware.org.
Apr 3 2019, 12:10 PM · Trusted Firmware A

Apr 2 2019

sandrine-bailleux-arm edited the content of Getting started: Contributing TF-A patches on www.trustedfirmware.org.
Apr 2 2019, 8:13 PM · Trusted Firmware A
sandrine-bailleux-arm edited the content of Getting started: Contributing TF-A patches on www.trustedfirmware.org.
Apr 2 2019, 1:56 PM · Trusted Firmware A
lmayencourt added a member for Trusted Firmware A: lmayencourt.
Apr 2 2019, 12:31 PM
sandrine-bailleux-arm edited the content of Getting started: Contributing TF-A patches on www.trustedfirmware.org.
Apr 2 2019, 12:08 PM · Trusted Firmware A