Page MenuHomePhabricator

Update memory pointer type to const void * in tfm_memory_check()
Closed, ResolvedPublic

Description

It sounds more reasonable to change the memory pointer type to const void * in tfm_memory_check().
From:

int32_t tfm_memory_check(void *buffer, size_t len, int32_t ns_caller,
                         enum tfm_memory_access_e access,
                         uint32_t privileged);

to

int32_t tfm_memory_check(const void *buffer, size_t len, int32_t ns_caller,
                         enum tfm_memory_access_e access,
                         uint32_t privileged);

Event Timeline

KenLSoft triaged this task as Low priority.Jul 29 2019, 2:54 AM

Hi David, since you are changing the memory checking related topics, can you help to do this task as well?

Hi @KenLSoft, I'm doing the memory checking functionalities on feature-twincpu. Do you expect me to fix it on feature-twincpu and merge it back to master or directly on master branch?

You can do it in feature-ipc branch first. I will take a look if I could cherry-pick it back to master, or I will wait for a merge from the feature-ipc branch.