rk3399: rockchip_soc_system_off() and rockchip_soc_soft_reset() are broken if board doesn't have poweroff and reset GPIOs
Open, Needs TriagePublic

Description

rockchip_soc_system_off() and rockchip_soc_soft_reset() are broken if board doesn't have poweroff and reset GPIOs since c1185ffde17c ("plat/rockchip: Switch to use new common BL aux parameter library").

plat_get_rockchip_gpio_reset() and plat_get_rockchip_gpio_poweroff() alwasy return non-NULL pointers.

anarsoul created this task.Sun, Nov 17, 8:33 PM
anarsoul added a comment.EditedSun, Nov 17, 9:07 PM

Sorry guys, your gerrit infrastructure is broken. I can't register my email at review.trustedfirmware.org it complains "Error 422 (Unprocessable Entity): invalid token" when I'm trying to confirm my email.

Changes to fix it is here: https://github.com/anarsoul/arm-trusted-firmware/commit/f4707a3c40bfc752a24c427263f7cbe8d7adfcd6

So either someone picks it up and merges it or it stays broken.

I've spent more than 30 mins trying to figure out your process of submitting changes, but it's somewhat cumbersome (and broken!) that it makes it close to impossible to follow it.

You should reconsider your process if you want independent contributors submitting their changes upstream.

Hi Vasily,

I’ll contact the team that manages the infrastructure and see if I can get them to address the issue. Unfortunately the TF-A project team do not manage that.

Joanna

Looks like it fixed itself, I was able to confirm my email.