Page MenuHomePhabricator
Create Task
Maniphest T603

Support dcc console in ATF
Open, NormalPublic
Actions

Description

I added the dcc console in the ATF code in the below path
"drivers/arm/dcc/dcc_console.c"

int32_t console_core_putc(int32_t ch, unsigned long base_addr)
{

while (__dcc_getstatus() & DCC_STATUS_TX)
                ;
__dcc_putchar(ch);
return ch;

}

int32_t console_core_getc(unsigned long base_addr)
{

while (!(__dcc_getstatus() & DCC_STATUS_RX))
          ;
return __dcc_getchar();

}
static inline void __dcc_putchar(char c)
{

/*
 * The typecast is to make absolutely certain that 'c' is
 * zero-extended.
 */
__asm__ volatile("msr dbgdtrtx_el0, %0"
             : : "r" ((unsigned long)(unsigned char)c));
isb();

}

And i just included the "drivers/console/aarch64/deprecated_console.S"
which has the console_core_init and console_core_putc etc function calls.

But now i upgraded the ATF to V2.2 and i see the console architecture got changed a lot.
Could you please let me know if i want to port the DCC console to the ATF V2.2 what are the changes need to be done?

Thanks
Venkatesh

Event Timeline

vabbarap triaged this task as Normal priority.Dec 2 2019, 12:41 PM
vabbarap created this task.
jwerner added a comment.Dec 2 2019, 10:56 PM

You'll probably want to write a function like this:

int console_ddc_register(void) {
  static console_t ddc_console;
  assert(!ddc_console.putc);
  ddc_console.putc = ddc_putc;
  ddc_console.getc = ddc_getc;
  ddc_console.flags = CONSOLE_FLAG_BOOT | CONSOLE_FLAG_CRASH;
  return console_register(&ddc_console);
}

Rename your putc/getc functions to ddc_putc and ddc_getc and make them static. Then add a call to console_ddc_register() somewhere early in the platform init for platforms you want to use this console.

vabbarap added a comment.Dec 3 2019, 6:14 AM

Thanks @jwerner. Will try this.