Page MenuHomePhabricator

RPI3/RPI4: support PSCI CPU_OFF
Open, HighPublic

Description

The current (common) rpi3_pm.c code doesn't implement a .pwr_domain_pwr_down_wfi callback to power off the cores. Of course, we can't really power off the cores or anything, but we should be putting them into a holding state to wait for another warm boot via PSCI CPU_ON.

This affects ACS tests (which use PSCI CPU_ON repeatedly) and also the ability to offline/online code within OSes like Linux.

I have a patch against @pbatard's tree, since that's what we're shipping today as part of https://rpi4-uefi.dev releases.

Event Timeline

andreiw triaged this task as High priority.Thu, Mar 12, 5:38 AM
andreiw created this task.

Again, this is for now staged via Pete's tree and you can view the pull request here - https://github.com/pbatard/arm-trusted-firmware/pull/2

If this generally looks okay I'm happy to follow https://developer.trustedfirmware.org/w/tf_a/gerrit-getting-started/ and push this for review according to the TF-A workflow.

andreiw claimed this task.Thu, Mar 12, 5:44 AM
andreiw added a subscriber: Andre-ARM.

Hi Andrew, yes the change looks fine.

The trouble with this ticketing mechanism is that it is not visible to the RPi maintainers. So could please raise a gerrit review as mentioned in the getting started page and send a mail towards the same notifying the mailing list with RPi maintainers in CC ?

Current gerrit proposal to fix this can be found in https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3749 (and related preceding commits).