Page MenuHomePhabricator

RK3399_BAUDRATE default value
Closed, ResolvedPublic

Description

I have noticed that default baudrate for rk3399 board RK3399_BAUDRATE defined in plat/rockchip/rk3399/rk3399_def.h is 115200 while U-boot default value and most documentation points to a value of 1500000.
This of course means that messages printed by ATF are not visible by default in this context.

The change from 1500000 to 115200 was introduced in 0c05748bdebfad9fa43a80962186438bb8fbce62,

https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=0c05748bdebfad9fa43a80962186438bb8fbce62

with the following message

commit 0c05748bdebfad9fa43a80962186438bb8fbce62
Author: Caesar Wang <wxt@rock-chips.com>
Date:   Tue Apr 19 20:42:17 2016 +0800

    rockchip: fixes for the required
    
    This patch has the following change for rk3399.
    
    * Set the uart to 115200 since the loader decide to set
      uart baud to 115200Hz. So the ATF also should set uart baud to 115200.
[..]

However, I'm not sure it this still applies.

I'll be happy to submit a patch to update the value if it is OK.

Event Timeline

wlozano0collabora triaged this task as Normal priority.Jun 3 2020, 4:29 PM
wlozano0collabora created this task.
tchebb added a subscriber: tchebb.Jun 19 2020, 5:04 AM

I noticed this as well, and I was on the verge of submitting a patch until I looked into it further and decided that the current default is justifiable.

Rockchip officially lists the UART speed of the RK3399 as 1500000 on their wiki, and their proprietary idbloader (I believe) uses 15000000 too. This indicates that Rockchip expects the UART to run at 1500000. However, there's nothing in the silicon itself that requires this, as the chip's BootROM doesn't use UART at all. Nor is there a prescribed baud rate in the datasheet or TRM.

Furthermore, although both U-Boot's RK3399 configs (example) and the DTS files in Linux for boards that generally use U-Boot (example) use 1500000, coreboot and the DTS files for boards that generally use coreboot (Chromebooks, example) use 115200. This means there isn't a de facto standard for baud rate, since Google has decided to use 115200 on their RK3399 products.

Since 115200 is a standard baud rate and 1500000 is very whacky, I'm inclined to just leave the default as is. It shouldn't matter with a properly configured AP_BL2 anyway, since it should pass in a DTB with the correct baud rate via the platform param which will override the default. U-Boot doesn't currently do this, probably because, up until very recently, TF-A would fail to parse the DTB because it was too large and crash. Luckily, the TF-A size limit has now been increased and I've submitted a patch to make sure it gracefully degrades to the default baud rate instead of crashing should the DTB get too large again. So in a few months, it should be safe to re-enable platform param passing in U-Boot.

Thanks for your comments and clarification. I should have updated this ticket with the information provided in the mail list, in order to keep them in sync.

I agree with you and hope that in a few months we can re enable the option.

This comment was removed by joannafarley-arm.

If you would like to change the rankdle baudrate back to 1500000 or any other desired value, you will need to modify the RK3399_BAUDRATE definition in the rk3399_def.h file to reflect your preferred baudrate. After making the change, you will need to rebuild and flash the firmware for it to take effect.

I agree wholeheartedly with the author's shell shockers view that life is a constant process of growth and transformation. Their words inspire me to embrace change and adapt.

Verify that the nspm_thread has been set to the correct mini crossword stack information by looking at the global variable 'p_thrd_head,' which contains all of the thread information and serves as the list's head.

the industry must also grapple with environmental and ethical challenges. Balancing the geometry dash desire for profit with responsible stewardship of the ocean's mysteries will define the trajectory of this unique and compelling sector.

College name women are also interested by Escorts enterprise they’re working on this subject to make money as well as for satisfaction. It absolutely depends on their choice. In our company impartial woman, Russian, models and housewives are also operating.
Delhi Escorts Service ||
Delhi Call Girls ||
Call Girls in Delhi ||
Delhi Escorts ||
Escorts in Delhi ||

We have had the greatest partners up to this point, and they have played an important role in making an individual's life enjoyable. Regardless of whether you are melancholy since you are unlikely to experience joy.
Delhi Escorts Service ||
Delhi Call Girls ||
Call Girls in Delhi ||
Delhi Escorts ||
Escorts in Delhi ||

Here at our Aerocity Escorts Service are readily available for fun and pleasure in all leading hotels in the capital city. You can choose the nearest hotel in your location and hire one of our best Call Girls or escort you straight into your hotel room. We charge only a nominal commission on the total payment, and we help you to process the booking for Call Girl or hotel escort.

Meeting our famous Karol Bagh Call Girls is the first step in joining our company and having the most wonderful time of your life, one that you will cherish forever. You can reach our Karol Bagh Call Girls near me through a number of channels, and she’ll be more than pleased to provide her Call Girls service in Karol Bagh and set everything up for you. If you pick him, he’ll show up on time and at the agreed-upon place to hand over every single photo we have of our Karol Bagh Call Girls no.

you will feel revitalized after meeting us. Our Escorts In Dwarka will make you feel like you are reborn as a new person full of joy and happiness. With time we have added a wide range of attractive young girls as independent Dwarka escorts in our collection.

to invest energy in with Our Goa Escorts. The best of this spot is the seashore where you can discover stunning peacefulness for your spirit and you will discover ecstasy. Goa is a place for celebrating as there are numerous clubs and bars.

It is the best time to fulfil your wildest fantasies and dreams. Every man craves a hot and romantic date with a beautiful girl and if you have not done this yet, then goes for Call Girls Gurgaon . It is the place where you can choose the call girls of your type and go on a long drive. Many people lack confidence in them due to which they hesitate to contact girls.Gurgaon call girls are confident, bold, intelligent and educated as well.

All these girls are highly educated and maintain their figures in such a way that all their clients get attracted to them and make them physically satisfied. They provide all sorts of services at a very reasonable price Escorts in Goa that anyone can easily afford in this world of increasing inflation.

By checking on the Independent Escorts in Goa Naughty Girls. Here can undoubtedly look through every one of the College Girls/ladies accompanies accessible. Pick the one that you locate the most reasonable, and alluring.

orabellehana closed this task as Resolved.Dec 14 2023, 3:08 AM
orabellehana claimed this task.
orabellehana added a subscriber: orabellehana.

The information you share is great, please continue to write about this topic regularly Watermelon game

Now, book your one night stand with these super and sexy Mahipalpur Escorts Service The hotness is another essential factor for the boys, and they always want the hot and sexy girls. These sexy and hot girls are now waiting for you. Simply choose the girl as per your needs and preferences.

Practicality is the cornerstone of this article, providing readers with information that goes beyond heardle theory, offering tangible solutions to everyday challenges.