Page MenuHomePhabricator
Create Task
Maniphest T396

Evaluating macro TFM_PSA_API in c code
Closed, ResolvedPublic
Actions

Description

Both secure_fw/spm/spm_api.c and secure_fw/core/tfm_nspm.c use #if to evaluate the macro TFM_PSA_API. This works in cmake based build as the marco is included in build using "-D" option. But in mbed-os it is included as "#define" which leads to compiler error. Can both spm_api.c and tfm_nspm.c be updated to check the macro TFM_PSA_API using #ifdef?

Event Timeline

devran01 triaged this task as Wishlist priority.Jun 13 2019, 10:22 AM
devran01 created this task.
davidhuziji added a subscriber: davidhuziji.Jun 13 2019, 10:24 AM
davidhuziji removed a subscriber: davidhuziji.
hug-dev added a subscriber: hug-dev.Jun 20 2019, 4:44 PM

Hi @devran01 ,
I think that I accidentally fixed this issue with my code quality patch (https://review.trustedfirmware.org/c/trusted-firmware-m/+/1374/) :)
If you confirm that this indeed fixes your issue, this can be closed when the patch is merged!

devran01 added a comment.Jun 20 2019, 6:23 PM

@hug-dev Thanks for the patch. I can confirm that the changes relevant to this issue looks good.

hug-dev closed this task as Resolved.Jul 18 2019, 5:12 PM
hug-dev claimed this task.

Hi @devran01 , the patch has now been merged so I will go ahead and close this issue.

• BrandynKunde added a subscriber: • BrandynKunde.Fri, Nov 29, 8:57 AM

If T396 mentions improving TF-A/TF-M, it needs to be compatible with current security standards, such as PSA. Besides, sometimes you also need to relax, during that time you should play raft wars to recharge your energy.

• helendam added a subscriber: • helendam.Thu, Dec 5, 2:30 AM

@infinite craft I wanted to take a moment to express my sincere gratitude for sharing such insightful content. It has been incredibly helpful.