Page MenuHomePhabricator

Implement design to fix C enumeration implicit casting
Closed, ResolvedPublic

Description

This issue is a collection of patches that implement the design to fix C enumeration implicit casting (https://review.trustedfirmware.org/c/trusted-firmware-m/+/1040) plus various code quality improvement.

The general list of fixes is:

  • avoid implicit casting by using matching types, casting or conversion functions
  • make explicit that the return value of a function is not used
  • remove function return type if not needed
  • replace preprocessor if condition by ifdef if only definition is checked
  • replace enumerated types not used by preprocessor constants
  • fix indentation of code

This issue is a follow-up of T274 (https://developer.trustedfirmware.org/T274).

The concerned patches are:

Related Objects

Event Timeline

hug-dev triaged this task as Normal priority.Jun 20 2019, 4:05 PM
hug-dev created this task.
hug-dev closed this task as Resolved.Jul 18 2019, 5:10 PM