Page MenuHomePhabricator
Create Task
Maniphest T479

Configure Cmake Build - Error : Could NOT find Sphinx (missing: SPHINX_VERSION)
Closed, ResolvedPublic
Actions

Description

Cmake : 3.10.2
Linux : Ubuntu 18.04

Command

cmake ../ -G"Unix Makefiles" -DTARGET_PLATFORM=MUSCA_A -DCOMPILER=ARMCLANG

When following software requirements, and setting

It reports..

-- Could NOT find Sphinx (missing: SPHINX_VERSION) 
CMake Warning at cmake/Common/BuildSphinxDoc.cmake:59 (message):
  Some tools are missing for Sphinx document generation.  Document generation
  target is not created.
Call Stack (most recent call first):
  cmake/Common/BuildSphinxDoc.cmake:65 (SphinxFindTools)
  secure_fw/CMakeLists.txt:23 (include)

Although I see it being installed in: /usr/bin/sphinx-build and reports

~/trusted-firmware-m/cmake_build$ sphinx-build --version
Sphinx (sphinx-build) 1.6.7

Problem could be here, when it compares the string.

Event Timeline

gyuri-szing added a subscriber: gyuri-szing.Aug 23 2019, 3:01 PM

Newer versions of sphinx seem to print the version as:

$ sphinx-build.exe --version
sphinx-build 2.1.2

I think the ) character is making the reqexp on this line https://git.trustedfirmware.org/trusted-firmware-m.git/tree/cmake/FindSphinx.cmake#n85 fail to match.
Can you please check if changing line 85 like this helps?: if(_SPHINX_VERSION MATCHES ".*sphinx-build[^0-9.]*([0-9.]+).*")

jainvikas8 added a comment.Aug 23 2019, 3:26 PM
CMake Error in cmake/FindSphinx.cmake:
  A logical block opening on line 84 is not closed.
gyuri-szing added a comment.Aug 26 2019, 11:37 AM

Can you please double check you modification? Line 84-88 should be:

if(_SPHINX_VERSION)
        if(_SPHINX_VERSION MATCHES ".*sphinx-build[^0-9.]*([0-9.]+).*")
		string(REGEX REPLACE ".*sphinx-build ([0-9.]+).*" "\\1" SPHINX_VERSION "${_SPHINX_VERSION}")
	endif()
endif()
jainvikas8 added a comment.Aug 27 2019, 1:00 PM

@gyuri-szing

The line sort outs

if(_SPHINX_VERSION MATCHES ".*sphinx-build[^0-9.]*([0-9.]+).*")

Thanks.

gyuri-szing added a comment.Aug 27 2019, 1:10 PM

Can you please create a pull request with the fix?

gyuri-szing closed this task as Resolved.Aug 28 2019, 11:42 AM
gyuri-szing claimed this task.

Fix was merged.

• larrymartin added a subscriber: • larrymartin.Feb 28 2024, 10:40 AM

Consider checking the CMakeLists.txt file at line 23 in the secure_fw directory to ensure the correct inclusion of Sphinx dependencies for document generation.
Remodeling Services in Gilmanton NH