Page MenuHomePhabricator

Device header
Closed, ResolvedPublic

Description

TF-M currently uses “cmsis.h” as the device header. This is not compliant with CMSIS which defines the naming convention for device headers, startup files and system configuration files.

Silicon vendors typically define header filenames that match their device names.

The device agnostic way proposed by CMSIS is to use a preprocessor define CMSIS_device_header that reflects the actual device name and is provided by the build environment.

We suggest to replace:

#include "cmsis.h"

with:

#include CMSIS_device_header

This would affect the following modules:
./secure_fw/core/arch/tfm_arch_v8m_base.c
./secure_fw/core/arch/tfm_arch_v8m_main.c
./secure_fw/core/arch/include/tfm_arch.h
./platform/ext/target: various target files

Related Objects

StatusAssignedTask
Resolveddavidwang
Resolveddavidwang

Event Timeline

RobertRostohar triaged this task as High priority.Oct 4 2019, 11:47 AM
RobertRostohar created this task.

It has been fixed in the new patch.
slope

The world of Slither io is constantly evolving, with snakes growing and shrinking as they consume pellets and battle each other. Adapt to the ever-changing landscape or risk being left behind.

poe2game added a subscriber: poe2game.EditedThu, Dec 5, 11:16 AM

poe2game,Here, you can learn about the latest game information and strategy for Path of Exile 2, simulate skill talent trees, and view building character db.