Page MenuHomePhabricator

New build system issue collector
Open, NormalPublic

Description

This is the single ticket collecting all issues found in the new build system during transition period. Please feel free to add your item to the list below:

  1. Issue with UART on NXP platform (being looked at)​
  2. Support for binary psa-arch-tests (design in progress)​
  3. Some issue with sometimes lacking debug symbols​
    1. Possible workaround – MBEDCRYPTO_BUILD_TYPE=debug
  4. Upstream MbedTLS changes with target prefixing and remove/reduce MbedTLS patches https://github.com/ARMmbed/mbedtls/pull/3407
  5. CC312 provisioning not working correctly

Done:

  1. A lot of documentation still needs updating (patch in progress)​
    1. Core test integration guide
    2. tfm_user_guide.rst signing instructions​
  2. Install/export directory not generated (https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/5983/3)​
  3. Core tests / IRQ tests not being run (patch in progress)​

Event Timeline

Anton-TF triaged this task as Normal priority.Thu, Oct 1, 2:12 PM
Anton-TF created this task.
ainh added a subscriber: ainh.Thu, Oct 1, 10:36 PM
ainh added a comment.Thu, Oct 1, 10:43 PM

MCU boot platforms (like Musca-A) images are singed as a part of the mcuboot build. For the platforms that do not use TFM's MCU boot (e.g. PSoC64), the images have to be signed manually.
Some time ago we had a discussion on adding hooks for running a custom post-build scripts (https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/2588). Can we consider adding this now with the new build system introduction?
thanks

RcColes updated the task description. (Show Details)Fri, Oct 2, 8:22 AM
Anton-TF updated the task description. (Show Details)Fri, Oct 2, 8:25 AM
This comment was removed by RcColes.
In T834#9670, @ainh wrote:

MCU boot platforms (like Musca-A) images are singed as a part of the mcuboot build. For the platforms that do not use TFM's MCU boot (e.g. PSoC64), the images have to be signed manually.
Some time ago we had a discussion on adding hooks for running a custom post-build scripts (https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/2588). Can we consider adding this now with the new build system introduction?
thanks

Since platforms now contain cmakelists.txt, and the signing targets are not generated when BL2 is not enabled (such as for the PSOC64), this should be relatively easy. In the platform cmake file (or as a separate file for clarity) you can define the tfm_s_signed_bin target (and all the others) to run custom scripts. I'd recommend starting by copying the relevant section from bl2/ext/mcuboot/cmakelists.txt into the platform cmake and modifying it to run your scripts instead.

soby-mathew added a subscriber: soby-mathew.EditedFri, Oct 2, 1:47 PM

To elaborate the "Support for binary psa-arch-tests (design in progress)​" point mentioned above.

Currently PSA_ARCH_TEST_PATH is used to point to a different PSA Arch test suite directory and prevent the build system from trying to clone. This means that PSA Arch tests is build from TF-M Cmake. Any changes in Psa Arch tests for configuration option or developer seeking to overrride some default options mean that they have to modify the TF-M build system to acheive this. Also there are patches being held for PSA Arch tests which will fail to apply for a different version. Hence we need a way to allow PSA Arch tests to be build independant of TF-M. This could another option to point to PSA Arch tests binary or some other suitable solution.

RcColes updated the task description. (Show Details)Fri, Oct 9, 1:03 PM
RcColes updated the task description. (Show Details)Mon, Oct 12, 8:46 AM

Building the documentation seems to clone all dependancies which seems like an overhead.