Page MenuHomePhabricator
Create Task
Maniphest T893

User and system includes are not consistent.
Open, Needs TriagePublic
Actions

Description

The user and system includes (files included with "" vs with <>) are not consistent.

  • Update the condign standard and add a clean definition on when "system" includes shall be used. The C99 standard is quite relaxed, but static analyzers treat system includes different. The suggestion is to include any header not owned by TS (or not following TS coding standard) to be included as a system include.
  • Fix the C/C++ files in the repo.

Event Timeline

gyuri-szing renamed this task from User ar system includes are not consistent. to User and system includes are not consistent..Mar 31 2021, 3:05 PM
• enchantdevote added a subscriber: • enchantdevote.EditedAug 3 2023, 8:14 AM

While the C99 standard is rather flexible, static analyzers sometimes take a stricter stance on system driving directions inclusions. The proposal is to treat as a system inclusion any header that is not owned by TS (or that does not adhere to the TS coding standard).