This page provides some information to help contributors using the new Gerrit review system for TF-A patches submission. When you are ready to post a patch (or a series of patches) for review, use the following command to submit it on Gerrit: ``` $ git push origin HEAD:refs/for/integration Counting objects: 5, done. Delta compression using up to 4 threads. Compressing objects: 100% (5/5), done. Writing objects: 100% (5/5), 559 bytes | 0 bytes/s, done. Total 5 (delta 3), reused 0 (delta 0) remote: Resolving deltas: 100% (3/3) remote: Processing changes: refs: 1, new: 1, done remote: remote: SUCCESS remote: remote: New Changes: remote: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/800 Fix a comment in SP_MIN Makefile To ssh://sandrine-bailleux-arm@review.trustedfirmware.org:29418/TF-A/trusted-firmware-a * [new branch] HEAD -> refs/for/integration ``` {F29811, size=full} {F29813, size=full} {F29815, size=full}

This page provides some information to help contributors using the new Gerrit review system for TF-A patches submission. It is not meant to be an exhaustive user guide but instead aims at illustrating the TF-A Contribution Guidelines, to help transitioning from Github to trustedfirmware.org. When you are ready to post a patch (or a series of patches) for review, you should use a git command similar to the following one: ``` $ git push origin HEAD:refs/for/integration Counting objects: 5, done. Delta compression using up to 4 threads. Compressing objects: 100% (5/5), done. Writing objects: 100% (5/5), 559 bytes | 0 bytes/s, done. Total 5 (delta 3), reused 0 (delta 0) remote: Resolving deltas: 100% (3/3) remote: Processing changes: refs: 1, new: 1, done remote: remote: SUCCESS remote: remote: New Changes: remote: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/800 Fix a comment in SP_MIN Makefile To ssh://sandrine-bailleux-arm@review.trustedfirmware.org:29418/TF-A/trusted-firmware-a * [new branch] HEAD -> refs/for/integration ``` This should make your patch(es) appear on the [[https://review.trustedfirmware.org/#/projects/TF-A/trusted-firmware-a,dashboards/site:main | TF-A Gerrit review dashboard]]: {F29811, size=full} Your patch(es) will need to go through code review, IP review and automated testing. If it does not have all approvals, it cannot be merged. The status of the patch is indicated at the top, near the change number. In this example, `Needs IP-Review label`. {F29813, size=full} Once your patch has received all necessary approvals, its status should change to `Ready to submit`: {F29815, size=full} At this stage, a maintainer should shortly merge it into the integration branch.

This page provides some information to help contributors using the new Gerrit review system for TF-A patches submission. It is not meant to be an exhaustive user guide but instead aims at illustrating the TF-A Contribution Guidelines, to help transitioning from Github to trustedfirmware.org. When you are ready to post a patch (or a series of patches) for review, use the followingyou should use a git command to submit it on Gerrit:similar to the following one: ``` $ git push origin HEAD:refs/for/integration Counting objects: 5, done. Delta compression using up to 4 threads. Compressing objects: 100% (5/5), done. Writing objects: 100% (5/5), 559 bytes | 0 bytes/s, done. Total 5 (delta 3), reused 0 (delta 0) remote: Resolving deltas: 100% (3/3) remote: Processing changes: refs: 1, new: 1, done remote: remote: SUCCESS remote: remote: New Changes: remote: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/800 Fix a comment in SP_MIN Makefile To ssh://sandrine-bailleux-arm@review.trustedfirmware.org:29418/TF-A/trusted-firmware-a * [new branch] HEAD -> refs/for/integration ``` This should make your patch(es) appear on the [[https://review.trustedfirmware.org/#/projects/TF-A/trusted-firmware-a,dashboards/site:main | TF-A Gerrit review dashboard]]: {F29811, size=full} Your patch(es) will need to go through code review, IP review and automated testing. If it does not have all approvals, it cannot be merged. The status of the patch is indicated at the top, near the change number. In this example, `Needs IP-Review label`. {F29813, size=full} Once your patch has received all necessary approvals, its status should change to `Ready to submit`: {F29815, size=full} At this stage, a maintainer should shortly merge it into the integration branch.