Page MenuHomePhabricator
Create Task
Maniphest T533

Crypto header clash with mbed-crypto
Closed, ResolvedPublic
Actions

Description

It seems that TF-M copies the crypto headers from mbed-crypto folder ./include/psa into folder ./mbedcrypto/psa. However TF-M also provides different crypto headers in folder ./interface/include/psa.

TF-M modules typically include "psa/crypto.h" except crypto service modules which include "mbedcrypto/psa/crypto.h" through “tfm_mbedcrypto_include.h”.

The problem is that in our tools both include folders (./include from mbed-crypto installation and ./interface/include from TF-M) are in the global search path causing wrong headers being used.

Another issues is the use of “mbedcrypto” prefix in include "mbedcrypto/psa/crypto.h". We have mbed-crypto already installed and copying crypto headers would not be needed when using include “psa/crypto.h”.

Related Objects
Search...

Event Timeline

RobertRostohar triaged this task as High priority.Oct 4 2019, 11:45 AM
RobertRostohar created this task.
KenLSoft added a subscriber: KenLSoft.Oct 8 2019, 12:59 PM

Shall we involve mbed-crypto people for this topic?

adeaarm reassigned this task from adeaarm to davidwang.Oct 23 2019, 10:58 AM
adeaarm added a subscriber: adeaarm.

Assigned to @davidwang for futher tracking and follow up.

davidwang added a comment.Nov 27 2019, 3:17 AM

Working on the proposal.

davidwang added a comment.Jan 15 2020, 9:38 AM

Had the workshop and aligned the solution for this issue.
The changes are made and verified locally for CMSIS Pack.
Next step is to upstream the solution to mbedCrypto.
As it's not TF-M issue anymore, so close this issue.

davidwang closed this task as Resolved.Jan 15 2020, 9:38 AM
• MiguelRandell added a subscriber: • MiguelRandell.Feb 28 2024, 6:30 AM

The workshop was conducted to address the issue, and a suitable solution has been identified and implemented for CMSIS Pack. The changes tunnel rush have been locally tested and verified. The next step involves integrating the solution into mbedCrypto. Since the issue is no longer related to TF-M, it can be concluded and closed.