Page MenuHomePhabricator
Feed Advanced Search

Tue, Mar 30

nathan-menhorn created T912: OP-TEE OS 3.11.0 Hangs at opteed_enter_sp on Cold Boot.
Tue, Mar 30, 4:11 PM · TF-A Bug, Trusted Firmware A

Mar 15 2021

sandrine-bailleux-arm edited the content of Getting started: Contributing TF-A patches on www.trustedfirmware.org.
Mar 15 2021, 9:28 AM · Trusted Firmware A

Feb 25 2021

CJKay renamed Conventional Commits from Conventional Commits Sign-off to Conventional Commits.
Feb 25 2021, 5:50 PM · Trusted Firmware A
CJKay added a comment to Conventional Commits.

Hi all, I suggest we move this discussion back to the mailing list so we can track the progression a bit more easily.

Feb 25 2021, 5:38 PM · Trusted Firmware A
leon-chen-mtk created T887: [Question] Could CASSERT check PSCI_MAX_PWR_LVL be removed?.
Feb 25 2021, 5:53 AM · Trusted Firmware A

Feb 23 2021

jenswi-linaro added a comment to Conventional Commits.

Vote: Jens Wiklander (qemu and OP-TEE Dispatcher): disapprove
I too have concerns with adding more tags to the the subject of the commit message.

Feb 23 2021, 7:17 AM · Trusted Firmware A

Feb 22 2021

joannafarley-arm added a comment to Conventional Commits.

We have had some contact with some other TF.org projects but was not aware of the Mbed TLS project had its own solution already. Its already acknowledged we should to look for a common solution across projects. This discussion is part of that engaging. We do need to make a decision at some point.

Feb 22 2021, 5:56 PM · Trusted Firmware A
vwadekar added a comment to Conventional Commits.

Hi, I agree with @danh-arm. We should try to come up with a unified guidance, if possible. I think we will have a better idea of the path forward, once most of the maintainers respond. Personally, I would be open to merging both approaches to get the best of both worlds.

Feb 22 2021, 5:46 PM · Trusted Firmware A
gyuri-szing added a comment to Conventional Commits.

I think tags in the subject of the commit message are problematic in general. Since commits are expected to capture "logical unit of change", the granularity of tags and commit scope often mismatches. While not mandated in the "Contributors Guide" sections, some commits indeed use tags already (i.e. libc, spmd, docs, etc..). What if a "logical unit of change" affects multiple components (i.e. a fix affects both libc and spmd)?

Feb 22 2021, 5:42 PM · Trusted Firmware A
danh-arm added a comment to Conventional Commits.

Hi, I just want to make you aware that the Mbed TLS project has a different, home-rolled solution to this problem:
https://github.com/ARMmbed/mbedtls/blob/development/ChangeLog.d/00README.md

Feb 22 2021, 3:38 PM · Trusted Firmware A

Feb 21 2021

vwadekar added a comment to Conventional Commits.

Yes, I have found that 50 chars is not enough to describe commits many times. Adding a tag would mean sacrificing space. But I am open to adding this tag to the commit message instead of the header. We already plan to add tags to the message anyways?

Feb 21 2021, 6:24 PM · Trusted Firmware A
raghuncstate added a comment to Conventional Commits.

I think this is generally a good move. The transition period will be ugly and unavoidable but we should reap the benefits of it long term. I do agree with Varun's concern about using tags in the headers but it is a trade-off we will have to make for the benefits standard commits offers.
Varun, is the format <conventional commit tag>:<plat> or <submodule>:<short message> not sufficient? I dont think we want to pack too much into the header any way in terms of what the commit is doing.

Feb 21 2021, 5:38 PM · Trusted Firmware A

Feb 19 2021

vwadekar added a comment to Conventional Commits.

Vote: <Varun Wadekar> (<Tegra>): <disapprove>

Feb 19 2021, 11:47 PM · Trusted Firmware A
CJKay created an object: Conventional Commits.
Feb 19 2021, 11:45 AM · Trusted Firmware A

Dec 2 2020

madhukar-Arm added a comment to T868: TF-A Bug.

Hi,
A developer submitted a patch which closely relates to this issue. Please give your feedback here: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/7314

Dec 2 2020, 6:48 PM · TF-A Bug, Trusted Firmware A

Nov 30 2020

madhukar-Arm added a comment to T868: TF-A Bug.

Hi,
Please use personal email and git configs/identity to push the patch to trustedfirmware.org. Few developers from the tf-a community have done this. Here is a link to contribution guidelines:

Nov 30 2020, 10:28 PM · TF-A Bug, Trusted Firmware A

Nov 28 2020

nickfrasher794 added a comment to T868: TF-A Bug.
Nov 28 2020, 12:37 PM · TF-A Bug, Trusted Firmware A
yuezhiran added a comment to T868: TF-A Bug.

Thanks for your reply. It is difficult to submit code to community or Gerrit using company's account and system. So, I wonder whether it's permitted to upload by providing modifications or “git send-email” with patches.

Nov 28 2020, 4:17 AM · TF-A Bug, Trusted Firmware A

Nov 19 2020

madhukar-Arm added a comment to T868: TF-A Bug.

Hi,
Yeah, looks like such a large system with numerous clusters will run into an issue with the current limitation of "lock_index" being "unsigned char". Please go ahead and submit a patch for review:

Nov 19 2020, 6:23 PM · TF-A Bug, Trusted Firmware A
yuezhiran added a comment to T868: TF-A Bug.

Yes, The power domain topology of the system can be described as 8 sockets, each socket with 10 clusters and each cluster with 8 cores. We just consider a system like this might face the constraint mentioned above, and we must modify the declaration of lock_index to solve this problem. Feature, more and more interconnected system, with numerous cpus, might face the same problem.

Nov 19 2020, 12:49 PM · TF-A Bug, Trusted Firmware A

Nov 18 2020

madhukar-Arm updated subscribers of T868: TF-A Bug.
Nov 18 2020, 5:54 PM · TF-A Bug, Trusted Firmware A
madhukar-Arm added a comment to T868: TF-A Bug.

Hi,
The struct "non_cpu_pwr_domain_node" represents a non-leaf power domain in an SoC such as a logical cluster. As you mentioned, the lock_index declaration with "unsigned char" limits such non-cpu power domains to 64. I believe it doesn't restrict the number of CPUs in a system to be <= 64. Do you currently face an issue with PSCI implementation due to the above constraint? Can you advise what is the power domain topology of your system? I think the lock_index can be expanded using "unsigned int" if needed.

Nov 18 2020, 5:53 PM · TF-A Bug, Trusted Firmware A
yuezhiran created T868: TF-A Bug.
Nov 18 2020, 3:06 AM · TF-A Bug, Trusted Firmware A

Nov 6 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:51 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:50 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:47 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:46 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:44 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:43 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Nov 6 2020, 5:43 PM · Trusted Firmware A

Sep 27 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Sep 27 2020, 3:59 PM · Trusted Firmware A

Aug 28 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Aug 28 2020, 9:25 AM · Trusted Firmware A

Aug 27 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Aug 27 2020, 3:47 PM · Trusted Firmware A

Aug 26 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Aug 26 2020, 2:12 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Aug 26 2020, 2:11 PM · Trusted Firmware A

Aug 12 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Aug 12 2020, 1:11 PM · Trusted Firmware A

Aug 10 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Aug 10 2020, 9:56 AM · Trusted Firmware A

Jul 22 2020

brianq-ti removed a member for Trusted Firmware A: brianq-ti.
Jul 22 2020, 9:06 PM
brianq-ti removed a watcher for Trusted Firmware A: brianq-ti.
Jul 22 2020, 9:06 PM
brianq-ti added a watcher for Trusted Firmware A: brianq-ti.
Jul 22 2020, 9:05 PM
brianq-ti added a member for Trusted Firmware A: brianq-ti.
Jul 22 2020, 9:05 PM
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jul 22 2020, 3:52 PM · Trusted Firmware A

Jul 2 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jul 2 2020, 3:23 PM · Trusted Firmware A

Jun 26 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jun 26 2020, 1:43 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jun 26 2020, 1:42 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jun 26 2020, 9:01 AM · Trusted Firmware A

Jun 23 2020

wlozano0collabora added a comment to T762: RK3399_BAUDRATE default value.

Thanks for your comments and clarification. I should have updated this ticket with the information provided in the mail list, in order to keep them in sync.

Jun 23 2020, 8:16 PM · Trusted Firmware A, TF-A Bug

Jun 19 2020

joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jun 19 2020, 4:00 PM · Trusted Firmware A
joannafarley-arm edited the content of Tf-a-tech-forum-scheduling.
Jun 19 2020, 1:01 PM · Trusted Firmware A
joannafarley-arm created an object: Tf-a-tech-forum-scheduling.
Jun 19 2020, 12:53 PM · Trusted Firmware A
tchebb added a comment to T762: RK3399_BAUDRATE default value.

I noticed this as well, and I was on the verge of submitting a patch until I looked into it further and decided that the current default is justifiable.

Jun 19 2020, 5:04 AM · Trusted Firmware A, TF-A Bug

Jun 3 2020

wlozano0collabora updated the task description for T762: RK3399_BAUDRATE default value.
Jun 3 2020, 4:42 PM · Trusted Firmware A, TF-A Bug
wlozano0collabora triaged T762: RK3399_BAUDRATE default value as Normal priority.
Jun 3 2020, 4:29 PM · Trusted Firmware A, TF-A Bug

May 28 2020

Scimmiaparlante closed T747: mpam_supported wrong register as Resolved.
May 28 2020, 7:42 AM · TF-A Bug, Trusted Firmware A

May 11 2020

Yann-lms added a watcher for Trusted Firmware A: Yann-lms.
May 11 2020, 9:00 AM

May 10 2020

AlexeiFedorov added a comment to T747: mpam_supported wrong register.

Hello Matteo,
Yes, you are right ID_AA64PFR0_EL1 must be used. Thanks for spotting this!

May 10 2020, 12:18 PM · TF-A Bug, Trusted Firmware A
Scimmiaparlante claimed T747: mpam_supported wrong register.
May 10 2020, 11:42 AM · TF-A Bug, Trusted Firmware A

May 9 2020

Scimmiaparlante updated the task description for T747: mpam_supported wrong register.
May 9 2020, 8:17 PM · TF-A Bug, Trusted Firmware A
Scimmiaparlante created T747: mpam_supported wrong register.
May 9 2020, 8:15 PM · TF-A Bug, Trusted Firmware A

Apr 18 2020

fozog created T712: LinuxBoot support for Marvell Macchiatobin.
Apr 18 2020, 10:12 AM · Trusted Firmware A

Mar 31 2020

sandrine-bailleux-arm added a comment to T690: BL31 el3_exit is marked as function.

OK. Regarding naming suggestions, I like func_noabi/endfunc_noabi the most. The reason why I am discounting asmfunc/endasmfunc is because a function implemented in assembly language might still respect the ABI.
I suggest we start with func_noabi/endfunc_noabi and continue the discussion on the patch on Gerrit. Unfortunately, this ticketing system does not have the same visibility as Gerrit or the mailing list and not everyone subscribe to these.

Mar 31 2020, 8:21 AM · TF-A Bug, Trusted Firmware A

Mar 27 2020

userid0x0 added a comment to T690: BL31 el3_exit is marked as function.

Hi @sandrine-bailleux-arm
Ok, In order to safe iterations.
I plan to suggest a new macro which does the followin

  • creates a new section - as func does
  • sets the alginment - as func does
  • sets the type
  • together with the counterpart end??? is sets the .size

. Proposals for names

  • func_noabi/endfunc_noabi - a non-abi conformant function
  • asmfunc/endasmfunc - a assembly routine/function
  • sym/endsym - short, but the name does not imply that it actually creates a block of code/own section
  • ...
Mar 27 2020, 5:45 PM · TF-A Bug, Trusted Firmware A
userid0x0 updated the task description for T698: Page alignment / Debug symbols.
Mar 27 2020, 4:39 PM · TF-A Question, Trusted Firmware A
userid0x0 created T698: Page alignment / Debug symbols.
Mar 27 2020, 4:34 PM · TF-A Question, Trusted Firmware A

Mar 25 2020

pbatard added a comment to T686: RPI3/RPI4: support PSCI CPU_OFF.

Current gerrit proposal to fix this can be found in https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3749 (and related preceding commits).

Mar 25 2020, 4:11 PM · TF-A Bug, Trusted Firmware A
userid0x0 added a comment to T690: BL31 el3_exit is marked as function.

I can try end of the week. Thanks.

Mar 25 2020, 8:30 AM · TF-A Bug, Trusted Firmware A

Mar 20 2020

Yann-lms added a comment to T661: BL32/SP_min cannot use arg3 from BL2 in AARCH32.

Corrected with the following commit that has just been merged:
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3518

Mar 20 2020, 8:04 AM · Trusted Firmware A, TF-A Bug

Mar 19 2020

sandrine-bailleux-arm added a comment to T690: BL31 el3_exit is marked as function.

This makes sense to me. Would you mind preparing a patch that removes the func macro on el3_exit and post it on review.trustedfirmware.org ?

Mar 19 2020, 2:08 PM · TF-A Bug, Trusted Firmware A
userid0x0 created T690: BL31 el3_exit is marked as function.
Mar 19 2020, 10:56 AM · TF-A Bug, Trusted Firmware A

Mar 17 2020

Andre-ARM claimed T669: sunxi h6 need fix memory map.

I took the patch and put it into gerrit. Due to a lack of name or email address I used mine. Happy to change that once I learn about the real identity of "armlabs".

Mar 17 2020, 12:37 AM · Trusted Firmware A

Mar 12 2020

soby-mathew added a comment to T686: RPI3/RPI4: support PSCI CPU_OFF.

Hi Andrew, yes the change looks fine.

Mar 12 2020, 11:58 AM · TF-A Bug, Trusted Firmware A
andreiw updated subscribers of T686: RPI3/RPI4: support PSCI CPU_OFF.
Mar 12 2020, 5:44 AM · TF-A Bug, Trusted Firmware A
andreiw claimed T686: RPI3/RPI4: support PSCI CPU_OFF.
Mar 12 2020, 5:44 AM · TF-A Bug, Trusted Firmware A
andreiw added a comment to T686: RPI3/RPI4: support PSCI CPU_OFF.

If this generally looks okay I'm happy to follow https://developer.trustedfirmware.org/w/tf_a/gerrit-getting-started/ and push this for review according to the TF-A workflow.

Mar 12 2020, 5:44 AM · TF-A Bug, Trusted Firmware A
andreiw added a comment to T686: RPI3/RPI4: support PSCI CPU_OFF.

Again, this is for now staged via Pete's tree and you can view the pull request here - https://github.com/pbatard/arm-trusted-firmware/pull/2

Mar 12 2020, 5:41 AM · TF-A Bug, Trusted Firmware A
andreiw triaged T686: RPI3/RPI4: support PSCI CPU_OFF as High priority.
Mar 12 2020, 5:38 AM · TF-A Bug, Trusted Firmware A

Mar 6 2020

pbatard closed T605: RPi4: Baudrate is set incorrectly with recent versions of start4.elf as Resolved.
Mar 6 2020, 3:07 PM · TF-A Bug, Trusted Firmware A
pbatard added a comment to T605: RPi4: Baudrate is set incorrectly with recent versions of start4.elf.

This has been fixed in https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/2789.

Mar 6 2020, 3:06 PM · TF-A Bug, Trusted Firmware A

Mar 3 2020

liuyunli assigned T680: uefi-build.sh was deleted, need update the script to leiflindholm.
Mar 3 2020, 3:37 AM · TF-A Question, Trusted Firmware A

Mar 2 2020

liuyunli triaged T680: uefi-build.sh was deleted, need update the script as High priority.
Mar 2 2020, 9:38 AM · TF-A Question, Trusted Firmware A

Feb 24 2020

a3f added a comment to T678: stm32mp1: support generating multiple images in one build.

I will send the patches shortly

Feb 24 2020, 4:27 PM · Trusted Firmware A, TF-A Enhancement
a3f triaged T678: stm32mp1: support generating multiple images in one build as Normal priority.
Feb 24 2020, 4:10 PM · Trusted Firmware A, TF-A Enhancement

Feb 15 2020

rickdic closed T632: End-of-interrupt (EOI) handling is missing for RAS interrupts as Resolved.
Feb 15 2020, 10:01 PM · TF-A Question, Trusted Firmware A

Feb 5 2020

Yann-lms added a project to T661: BL32/SP_min cannot use arg3 from BL2 in AARCH32: Trusted Firmware A.
Feb 5 2020, 8:28 AM · Trusted Firmware A, TF-A Bug

Feb 1 2020

joannafarley-arm added a comment to T669: sunxi h6 need fix memory map.

Hi sunxi h6,

Feb 1 2020, 2:21 PM · Trusted Firmware A
armlabs triaged T669: sunxi h6 need fix memory map as Normal priority.
Feb 1 2020, 8:07 AM · Trusted Firmware A

Jan 29 2020

raghuncstate claimed T589: Insufficient ordering guarantees in bakery_lock_get() and bakery_lock_release() in bakery_lock_coherent.c.

Review posted @ https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3296

Jan 29 2020, 3:32 PM · Trusted Firmware A
raghuncstate moved T589: Insufficient ordering guarantees in bakery_lock_get() and bakery_lock_release() in bakery_lock_coherent.c from Backlog to In Progress on the Trusted Firmware A board.
Jan 29 2020, 3:29 PM · Trusted Firmware A

Jan 21 2020

sbranden added a member for Trusted Firmware A: sbranden.
Jan 21 2020, 9:48 PM

Jan 14 2020

odeprez added a comment to T554: Build can fail on systems with stack protection enabled by default.

Nerver mind :) Glad if it works now. Cheers, Olivier.

Jan 14 2020, 2:42 PM · Trusted Firmware A
soby-mathew closed T418: Cryptocell Key Sizes as Resolved.

Closing the issue as the RSA Key size support has now been merged.

Jan 14 2020, 11:52 AM · Trusted Firmware A
soby-mathew added a comment to T418: Cryptocell Key Sizes.

The TF-A now has support for RSA-3K in Cryptocell variant.
https://review.trustedfirmware.org/#/c/TF-A/trusted-firmware-a/+/2263/

Jan 14 2020, 11:51 AM · Trusted Firmware A
Strit added a comment to T554: Build can fail on systems with stack protection enabled by default.

I am sorry guys.
I need to apologize to all who have helped me with this issue.

Jan 14 2020, 10:21 AM · Trusted Firmware A
Leoiuerrsse added a comment to T418: Cryptocell Key Sizes.

Cryptocell key sizes are different. You have different key sizes and i have different, Here we need to move on because all these are different and if you just not share it with a perfect essayhave project then move and start to find something else.

Jan 14 2020, 6:22 AM · Trusted Firmware A

Jan 13 2020

lukakovacic lowered the priority of T646: Support for platform specific power off functions on Marvell Armada 8K boards from High to Normal.
Jan 13 2020, 7:45 PM · Trusted Firmware A
lukakovacic triaged T646: Support for platform specific power off functions on Marvell Armada 8K boards as High priority.
Jan 13 2020, 7:45 PM · Trusted Firmware A
odeprez added a comment to T554: Build can fail on systems with stack protection enabled by default.

The log seems to show additional options versus the regular TF-A build:
-march=armv8-a -O2 -pipe -fstack-protector-strong -fno-plt

Jan 13 2020, 10:19 AM · Trusted Firmware A

Jan 10 2020

Strit added a comment to T554: Build can fail on systems with stack protection enabled by default.

Okay, here's the log.

Jan 10 2020, 4:09 PM · Trusted Firmware A

Jan 9 2020

odeprez added a comment to T554: Build can fail on systems with stack protection enabled by default.

I installed manjaro-arm on an rpi3 and cloned TF-A commit 0348ee49135c

Jan 9 2020, 8:44 AM · Trusted Firmware A

Jan 8 2020

21212124 triaged T641: Does ARMv8 TrustZone provide a secure ROM? as High priority.
Jan 8 2020, 11:20 AM · Trusted Firmware A