Page MenuHomePhabricator
Feed Advanced Search

Advanced Search

Mar 25 2020

soby-mathew created T691: Some PSA-Arch Crypto tests fail with CC-312.
Mar 25 2020, 10:21 AM · Trusted Firmware M

Mar 23 2020

edison-ai closed T441: Wrong return type of tfm_core_set_secure_exception_priorities() as Resolved.

Thanks for reminding me. Miss it. All patches had been merged, close it.

Mar 23 2020, 2:06 AM · Trusted Firmware M

Mar 20 2020

e-shreve-ti added a comment to T441: Wrong return type of tfm_core_set_secure_exception_priorities().

@edison-ai , both patches were merged. Is this task done?

Mar 20 2020, 7:14 PM · Trusted Firmware M
e-shreve-ti added a watcher for Trusted Firmware M: e-shreve-ti.
Mar 20 2020, 7:03 PM

Mar 19 2020

kevin-peng-hao closed T681: TF-M cannot boot up when SST using flash FS on Musca-b1 as Resolved.
Mar 19 2020, 8:55 AM · Trusted Firmware M

Mar 12 2020

matetothpal triaged T687: Non-Secure scatter files might over-allocate RAM as Low priority.
Mar 12 2020, 1:51 PM · Trusted Firmware M

Mar 11 2020

gyuri-szing added a comment to T228: Update build system to support latest cmake version..

This page lists cmake versions available in different Linux distributions.
https://gitlab.kitware.com/cmake/community/-/wikis/CMake-Versions-on-Linux-Distros

Mar 11 2020, 9:24 PM · Trusted Firmware M
ChangwuShan added a comment to T549: Enhancement TF-M to support ACK test.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3634

Mar 11 2020, 3:03 AM · Trusted Firmware M

Mar 10 2020

edison-ai added a comment to T681: TF-M cannot boot up when SST using flash FS on Musca-b1.

By using this patch, the test will stop at test case 4 by the hardware flash bug, which is not related to this defect.
After the test fails, the system cannot boot up anymore except we erase the flashes again.

Mar 10 2020, 2:25 AM · Trusted Firmware M

Mar 4 2020

matetothpal added a comment to T304: Incorrect build options for NS code.

Change for this issue is: https://review.trustedfirmware.org/c/trusted-firmware-m/+/3592

Mar 4 2020, 12:22 PM · Trusted Firmware M
matetothpal claimed T304: Incorrect build options for NS code.
Mar 4 2020, 12:14 PM · Trusted Firmware M

Mar 3 2020

soby-mathew edited projects for T682: psa_open_key/psa_close_key APIs require support for persistent key storage, added: Trusted Firmware M; removed Restricted Project.
Mar 3 2020, 1:24 PM · Trusted Firmware M
kevin-peng-hao added a comment to T681: TF-M cannot boot up when SST using flash FS on Musca-b1.

Patch made to fix:
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3588

Mar 3 2020, 7:27 AM · Trusted Firmware M
kevin-peng-hao created T681: TF-M cannot boot up when SST using flash FS on Musca-b1.
Mar 3 2020, 7:24 AM · Trusted Firmware M

Feb 23 2020

edison-ai added a comment to T549: Enhancement TF-M to support ACK test.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3527/

Feb 23 2020, 12:22 PM · Trusted Firmware M
edison-ai added a comment to T549: Enhancement TF-M to support ACK test.

Enable memory protection for PSA FF test: https://review.trustedfirmware.org/c/trusted-firmware-m/+/3526

Feb 23 2020, 7:16 AM · Trusted Firmware M
edison-ai added a comment to T549: Enhancement TF-M to support ACK test.

Isolation level 2 peripheral MPU config:
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3524
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3525

Feb 23 2020, 6:52 AM · Trusted Firmware M

Feb 22 2020

vbenotmanee added a comment to T185: NSPE parameter checking of iovecs.

NSPE parameter checking of iovecs, With also checking all missed patch. These missed patched are used to take https://www.ukbestessay.net/assignment-writing look, When you decided to check all the mention informative material you understand how and in which way it important to share.

Feb 22 2020, 9:52 AM · Trusted Firmware M
edison-ai added a comment to T549: Enhancement TF-M to support ACK test.

Switch SST FS from flash to RAM: https://review.trustedfirmware.org/c/trusted-firmware-m/+/3523

Feb 22 2020, 7:00 AM · Trusted Firmware M

Feb 21 2020

0xc0170 created T677: Few qcbor files do not contain SPDX identifier.
Feb 21 2020, 8:12 AM · Trusted Firmware M
ChangwuShan added a comment to T549: Enhancement TF-M to support ACK test.

Fix the isolation level issue related with ACK test
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3516

Feb 21 2020, 6:47 AM · Trusted Firmware M

Feb 19 2020

ChangwuShan added a comment to T549: Enhancement TF-M to support ACK test.

Add lifecycle API
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3465/1

Feb 19 2020, 1:39 AM · Trusted Firmware M
ChangwuShan added a comment to T549: Enhancement TF-M to support ACK test.

Fix the PROGRAMMER ERROR issue
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3464

Feb 19 2020, 1:37 AM · Trusted Firmware M

Feb 18 2020

mingyangSun added a comment to T676: Move some SPM files out of core folder and combine with other SPM files..

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3886
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3887
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3433
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3514
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3888

Feb 18 2020, 2:51 PM · Trusted Firmware M
mingyangSun created T676: Move some SPM files out of core folder and combine with other SPM files..
Feb 18 2020, 2:38 PM · Trusted Firmware M
mingyangSun closed T567: SPRTL - SPRTL framework and c runtime library as Resolved.
Feb 18 2020, 2:35 PM · Trusted Firmware M
edison-ai added a comment to T549: Enhancement TF-M to support ACK test.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3098
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3350/9
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3360/8

Feb 18 2020, 10:58 AM · Trusted Firmware M

Feb 14 2020

edison-ai closed T557: PSA FF 1.0.0 alignment as Resolved.

All patches had been merged into the master branch.

Feb 14 2020, 1:58 AM · Trusted Firmware M

Feb 13 2020

kevin-peng-hao closed T634: Crypto: Refine how crypto modules are selected as Resolved.
Feb 13 2020, 7:38 AM · Trusted Firmware M
kevin-peng-hao closed T594: Remove include paths relative to TF-M root as Wontfix.
Feb 13 2020, 7:38 AM · Trusted Firmware M
KenLSoft closed T652: Stuck in tfm_nspm_thread_entry() as Resolved.
Feb 13 2020, 7:04 AM · Trusted Firmware M

Feb 12 2020

tkaman closed T600: Create GPIO platform service for Musca-A and Musca-B1 as Resolved.
Feb 12 2020, 1:40 PM · Trusted Firmware M
tkaman closed T593: Fix QSPI uninit function for Musca A platform as Resolved.
Feb 12 2020, 1:39 PM · Trusted Firmware M
KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Andrej,

Feb 12 2020, 12:10 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,
Yes, the final patch has fixed the issue.
It works now without our workarounds.

Feb 12 2020, 9:40 AM · Trusted Firmware M
Summer-ARM closed T576: Align parameters packing method between ns caller and secure caller and implement the secure parameter packing in SPRTL as Resolved.
Feb 12 2020, 8:56 AM · Trusted Firmware M
KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Andrej,
I have updated patch and test with FP enabled in my side and it works. Can you take a try on your side?
Thanks.

Feb 12 2020, 5:10 AM · Trusted Firmware M

Feb 11 2020

KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Thanks. I just found the patch missed something, I will re-create a patch to update that.

Feb 11 2020, 4:00 AM · Trusted Firmware M

Feb 10 2020

KenLSoft added a comment to T673: The design proposal document update .

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3407

Feb 10 2020, 12:36 PM · Trusted Firmware M
KenLSoft created T673: The design proposal document update .
Feb 10 2020, 11:19 AM · Trusted Firmware M
davidhuziji closed T654: The token_size is not updated with actual token length in Library Model as Resolved.
Feb 10 2020, 1:52 AM · Trusted Firmware M

Feb 7 2020

minosgalanakis triaged T672: Rename Secure Storage Service (SST) to Protected Storage as Normal priority.
Feb 7 2020, 11:00 AM · Restricted Project
minosgalanakis triaged T671: Move the PS partition to the Application RoT as High priority.
Feb 7 2020, 10:55 AM · Restricted Project

Feb 6 2020

GaborAbonyi closed T663: Fix SRAM sanity check in common scatter file as Resolved.

Fix reviewed and merged:
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3333/

Feb 6 2020, 12:51 PM · Trusted Firmware M
GaborAbonyi closed T662: Add eFlash and QSPI flash driver to Musca-B1 platform as Resolved.

Changes reviewed and merged:
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3334/
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3335/
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3336/

Feb 6 2020, 12:50 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Should to confirm, that after the patch the issue is still present.

Feb 6 2020, 7:53 AM · Trusted Firmware M
KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Patch created:

Feb 6 2020, 6:03 AM · Trusted Firmware M

Feb 5 2020

tamasban closed T666: Fix static code analyser findings in QCBOR as Resolved.
Feb 5 2020, 3:29 PM · Trusted Firmware M
tamasban closed T665: Fix static code analyser findings in attestation as Resolved.
Feb 5 2020, 1:24 PM · Trusted Firmware M

Feb 3 2020

KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Thanks for your input, that helps much. I will create fixes when I back to office.

Feb 3 2020, 4:52 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,
after farther testings, PSA Test application still goes to the memory fault.
So I have returned all my two workarounds, which work for all applications:

  1. .stack_top = PART_REGION_ADDR(ARM_LIB_STACK, $$ZI$$Limit) - 0x48,
  2. Disable if (stacked_ctx_pos != p_cur_sp->runtime_data.sp_thrd.sp_btm)
Feb 3 2020, 1:12 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,
Also, it should be done something with the check in tfm_svcalls.c, tfm_core_validate_caller() line 1001:

Feb 3 2020, 12:56 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,

Feb 3 2020, 7:53 AM · Trusted Firmware M

Feb 1 2020

KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

BTW, can you update other tfm_arch_*.h as well?
We can help verify the changes not covered in your side.

Feb 1 2020, 4:35 AM · Trusted Firmware M
KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Andrey,

Feb 1 2020, 4:33 AM · Trusted Firmware M

Jan 31 2020

AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

So my workaround, to avoid psa_panic(), is to disable the check:

Jan 31 2020, 3:54 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

So I have returned to the RESET issue.

Jan 31 2020, 3:42 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

After the following fix - 0x48, the applications does not have the memory fault:

{
    .stack_bottom         = PART_REGION_ADDR(ARM_LIB_STACK, $$ZI$$Base),
    .stack_top            = PART_REGION_ADDR(ARM_LIB_STACK, $$ZI$$Limit) - 0x48, //NXP
    .rw_start             = PART_REGION_ADDR(ARM_LIB_STACK, $$ZI$$Base),
},
Jan 31 2020, 2:34 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,

Jan 31 2020, 11:32 AM · Trusted Firmware M
tamasban added a comment to T666: Fix static code analyser findings in QCBOR.

Related change: https://review.trustedfirmware.org/c/trusted-firmware-m/+/3328

Jan 31 2020, 11:18 AM · Trusted Firmware M
tamasban triaged T666: Fix static code analyser findings in QCBOR as Normal priority.
Jan 31 2020, 11:16 AM · Trusted Firmware M
tamasban added a comment to T665: Fix static code analyser findings in attestation.

Related change: https://review.trustedfirmware.org/c/trusted-firmware-m/+/3288

Jan 31 2020, 11:11 AM · Trusted Firmware M
tamasban triaged T665: Fix static code analyser findings in attestation as Normal priority.
Jan 31 2020, 11:02 AM · Trusted Firmware M
KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

More hints for you:

Jan 31 2020, 4:31 AM · Trusted Firmware M
KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Sorry for the late response and thanks for the findings. Could you share your image binary so that I could take a try? I got a board but not set up the environment yet.

Jan 31 2020, 4:04 AM · Trusted Firmware M

Jan 30 2020

GaborAbonyi triaged T663: Fix SRAM sanity check in common scatter file as Normal priority.
Jan 30 2020, 4:25 PM · Trusted Firmware M
GaborAbonyi triaged T662: Add eFlash and QSPI flash driver to Musca-B1 platform as Normal priority.
Jan 30 2020, 3:08 PM · Trusted Firmware M

Jan 29 2020

AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

I have tried to workaround it. Current steps:

  1. Updated to the latest TFM commit.
  2. Reverted changes related to:
    1. 5248af2d7b86775364a0e131eb80ac0330bc81fb
    2. 490281df3736b11b62e25bc98d3e2c6e4e10478c
    3. 483da6447e4360c514538807275904be68395dff

After that, PSA Test application starts working.
But the regression test application still goes to the Memory fault during the first App ROT partition initialization, on the first SVC call.

  1. Switched App ROT partitions to PSA ROT, in tfm_spm_db.inc => after that regression tests are OK.
Jan 29 2020, 9:53 AM · Trusted Firmware M

Jan 28 2020

matetothpal closed T598: TF-M: Move debug authentication documentation as Resolved.

Change for this issue had been merged

Jan 28 2020, 2:44 PM · Trusted Firmware M
matetothpal closed T601: TF-M Core: Unify register clear in naked functions as Resolved.

Fix for this issue had been merged

Jan 28 2020, 2:26 PM · Trusted Firmware M

Jan 27 2020

davidvincze closed T619: Integrate TF-M buildsystem with upstream MCUBoot as Resolved.
Jan 27 2020, 2:06 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

FYI:
For ARMClang/Keil

  1. Functional API and TFM_LVL=1, all applications/tests are OK!!!
  2. IPC API and TFM_LVL=1 => repetitive reset.
  3. IPC API and TFM_LVL=2 => goes to the mentioned memory fault.
Jan 27 2020, 1:55 PM · Trusted Firmware M
ronald-cron-arm raised the priority of T657: Add support for ArmClang version 6.13 from Normal to Needs Triage.
Jan 27 2020, 12:48 PM · Trusted Firmware M
ronald-cron-arm claimed T657: Add support for ArmClang version 6.13.
Jan 27 2020, 12:46 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Another experiment. Switching to Armasm V5 from v6 did not help, the same result - goes to the Memory fault.
So, for this moment only GCC (for PSA tests) is OK.

Jan 27 2020, 12:15 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

BTW: At the same time the TFM Regression Tests application (using GCC) goes to infinite reset on test_app()=>tfm_secure_client_run_tests()=>psa_connect(TFM_SECURE_CLIENT_SFN_RUN_TESTS_SID,TFM_SECURE_CLIENT_SFN_RUN_TESTS_VERSION)=>tfm_ns_interface_dispatch()=>fn()=>causes reset

Jan 27 2020, 9:33 AM · Trusted Firmware M
tamasban closed T608: Integrate QCBOR and COSE update as Resolved.
Jan 27 2020, 9:12 AM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,

Jan 27 2020, 9:07 AM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,

Jan 27 2020, 8:26 AM · Trusted Firmware M
ronald-cron-arm triaged T657: Add support for ArmClang version 6.13 as Normal priority.
Jan 27 2020, 8:02 AM · Trusted Firmware M

Jan 25 2020

KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Looks like this was caused by the push operation, and it was caused by accessing an address out of ARM_LIB_STACK.

Jan 25 2020, 8:31 AM · Trusted Firmware M

Jan 24 2020

AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

After tfm_core_svc_handler() returns, the execution jumps to tfm_nspm_thread_entry().
Strange is, that during this jump PSP is changed from 0x30000FE0 to 0x30001048.

Jan 24 2020, 2:47 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

So the PSP, during main() has following values:
PSP = 0x300001000 PSPLIM = 0x30000800

Jan 24 2020, 11:57 AM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,
Thank you by taking care about it.
Guess, the issue may be caused by the way we are using TFM. We have to compile TFM Secure in one project (instead of separate libraries). Guess, it may cause that some parts of data/code may be placed to unwanted memory sections.
I will try to analyze the generated map file.

Jan 24 2020, 8:59 AM · Trusted Firmware M

Jan 23 2020

AndreyButokNXP added a comment to T653: Apply '-fno-builtin' for building.
Jan 23 2020, 9:12 AM · Trusted Firmware M

Jan 22 2020

davidhuziji created T654: The token_size is not updated with actual token length in Library Model.
Jan 22 2020, 3:31 PM · Trusted Firmware M
KenLSoft added a comment to T653: Apply '-fno-builtin' for building.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3217

Jan 22 2020, 9:38 AM · Trusted Firmware M
KenLSoft changed the edit policy for T653: Apply '-fno-builtin' for building.
Jan 22 2020, 9:37 AM · Trusted Firmware M
KenLSoft added a comment to T649: Increase client partition stack size due to usage is increased.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3216/1

Jan 22 2020, 9:32 AM · Trusted Firmware M
kevin-peng-hao renamed T644: Build system: clean up, minor refines and corner case fixes from Build system: clean up deprecated build configurations to Build system: clean up and minor refines.
Jan 22 2020, 7:57 AM · Trusted Firmware M
KenLSoft created T652: Stuck in tfm_nspm_thread_entry().
Jan 22 2020, 2:26 AM · Trusted Firmware M

Jan 19 2020

shebuk edited the content of TF-M Videos.
Jan 19 2020, 6:02 PM · Trusted Firmware M

Jan 17 2020

matetothpal closed T597: TF-M: Enable multiple MMIO regions per partition as Resolved.

Changes for this issue had been merged.

Jan 17 2020, 12:00 PM · Trusted Firmware M

Jan 16 2020

kevin-peng-hao triaged T650: Update document to clarify the differences between configurations under configs folder as Normal priority.
Jan 16 2020, 12:06 PM · Trusted Firmware M
KenLSoft added a comment to T649: Increase client partition stack size due to usage is increased.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3154

Jan 16 2020, 8:59 AM · Trusted Firmware M
KenLSoft created T649: Increase client partition stack size due to usage is increased.
Jan 16 2020, 8:56 AM · Trusted Firmware M

Jan 15 2020

Summer-ARM added a comment to T576: Align parameters packing method between ns caller and secure caller and implement the secure parameter packing in SPRTL.

https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/3133/

Jan 15 2020, 5:48 AM · Trusted Firmware M
Summer-ARM reopened T576: Align parameters packing method between ns caller and secure caller and implement the secure parameter packing in SPRTL as "Open".
Jan 15 2020, 5:38 AM · Trusted Firmware M
KenLSoft updated the task description for T647: Patchset tiny update/fine-tune list.
Jan 15 2020, 1:38 AM · Trusted Firmware M
KenLSoft added a comment to T647: Patchset tiny update/fine-tune list.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3130

Jan 15 2020, 1:37 AM · Trusted Firmware M