Page MenuHomePhabricator
Feed Advanced Search

Fri, Feb 14

edison-ai closed T557: PSA FF 1.0.0 alignment as Resolved.

All patches had been merged into the master branch.

Fri, Feb 14, 1:58 AM · Trusted Firmware M

Thu, Feb 13

kevin-peng-hao closed T634: Crypto: Refine how crypto modules are selected as Resolved.
Thu, Feb 13, 7:38 AM · Trusted Firmware M
kevin-peng-hao closed T594: Remove include paths relative to TF-M root as Wontfix.
Thu, Feb 13, 7:38 AM · Trusted Firmware M
KenLSoft closed T652: Stuck in tfm_nspm_thread_entry() as Resolved.
Thu, Feb 13, 7:04 AM · Trusted Firmware M

Wed, Feb 12

tkaman closed T600: Create GPIO platform service for Musca-A and Musca-B1 as Resolved.
Wed, Feb 12, 1:40 PM · Trusted Firmware M
tkaman closed T593: Fix QSPI uninit function for Musca A platform as Resolved.
Wed, Feb 12, 1:39 PM · Trusted Firmware M
KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Andrey,

Wed, Feb 12, 12:10 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,
Yes, the final patch has fixed the issue. It works now without our workarounds.

Wed, Feb 12, 9:40 AM · Trusted Firmware M
Summer-ARM closed T576: Align parameters packing method between ns caller and secure caller and implement the secure parameter packing in SPRTL as Resolved.
Wed, Feb 12, 8:56 AM · Trusted Firmware M
KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Andrej,
I have updated patch and test with FP enabled in my side and it works. Can you take a try on your side?
Thanks.

Wed, Feb 12, 5:10 AM · Trusted Firmware M

Tue, Feb 11

KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Thanks. I just found the patch missed something, I will re-create a patch to update that.

Tue, Feb 11, 4:00 AM · Trusted Firmware M

Mon, Feb 10

KenLSoft added a comment to T673: The design proposal document update .

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3407

Mon, Feb 10, 12:36 PM · Trusted Firmware M
KenLSoft created T673: The design proposal document update .
Mon, Feb 10, 11:19 AM · Trusted Firmware M
davidhuziji closed T654: The token_size is not updated with actual token length in Library Model as Resolved.
Mon, Feb 10, 1:52 AM · Trusted Firmware M

Fri, Feb 7

minosgalanakis triaged T672: Rename Secure Storage Service (SST) to Protected Storage as Normal priority.
Fri, Feb 7, 11:00 AM · Trusted Firmware M
minosgalanakis triaged T671: Move the PS partition to the Application RoT as High priority.
Fri, Feb 7, 10:55 AM · Trusted Firmware M

Thu, Feb 6

GaborAbonyi closed T663: Fix SRAM sanity check in common scatter file as Resolved.

Fix reviewed and merged:
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3333/

Thu, Feb 6, 12:51 PM · Trusted Firmware M
GaborAbonyi closed T662: Add eFlash and QSPI flash driver to Musca-B1 platform as Resolved.

Changes reviewed and merged:
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3334/
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3335/
https://review.trustedfirmware.org/c/trusted-firmware-m/+/3336/

Thu, Feb 6, 12:50 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Should to confirm, that after the patch the issue is still present.

Thu, Feb 6, 7:53 AM · Trusted Firmware M
KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Patch created:

Thu, Feb 6, 6:03 AM · Trusted Firmware M

Wed, Feb 5

tamasban closed T666: Fix static code analyser findings in QCBOR as Resolved.
Wed, Feb 5, 3:29 PM · Trusted Firmware M
tamasban closed T665: Fix static code analyser findings in attestation as Resolved.
Wed, Feb 5, 1:24 PM · Trusted Firmware M

Mon, Feb 3

KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Thanks for your input, that helps much. I will create fixes when I back to the office.

Mon, Feb 3, 4:52 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,
after farther testings, PSA Test application still goes to the memory fault.
So I have returned all my two workarounds, which work for all applications:

  1. .stack_top = PART_REGION_ADDR(ARM_LIB_STACK, $$ZI$$Limit) - 0x48,
  2. Disable if (stacked_ctx_pos != p_cur_sp->runtime_data.sp_thrd.sp_btm)
Mon, Feb 3, 1:12 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,
Also, it should be done something with the check in tfm_svcalls.c, tfm_core_validate_caller() line 1001:

Mon, Feb 3, 12:56 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,

Mon, Feb 3, 7:53 AM · Trusted Firmware M

Sat, Feb 1

KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

BTW, can you update other tfm_arch_*.h as well?
We can help verify the changes not covered in your side.

Sat, Feb 1, 4:35 AM · Trusted Firmware M
KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Andrey,

Sat, Feb 1, 4:33 AM · Trusted Firmware M

Fri, Jan 31

AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

So my workaround, to avoid psa_panic(), is to disable the check:

Fri, Jan 31, 3:54 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

So I have returned to the RESET issue.

Fri, Jan 31, 3:42 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

After the following fix - 0x48, the applications does not have the memory fault:

{
    .stack_bottom         = PART_REGION_ADDR(ARM_LIB_STACK, $$ZI$$Base),
    .stack_top            = PART_REGION_ADDR(ARM_LIB_STACK, $$ZI$$Limit) - 0x48, //NXP
    .rw_start             = PART_REGION_ADDR(ARM_LIB_STACK, $$ZI$$Base),
},
Fri, Jan 31, 2:34 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,

Fri, Jan 31, 11:32 AM · Trusted Firmware M
tamasban added a comment to T666: Fix static code analyser findings in QCBOR.

Related change: https://review.trustedfirmware.org/c/trusted-firmware-m/+/3328

Fri, Jan 31, 11:18 AM · Trusted Firmware M
tamasban triaged T666: Fix static code analyser findings in QCBOR as Normal priority.
Fri, Jan 31, 11:16 AM · Trusted Firmware M
tamasban added a comment to T665: Fix static code analyser findings in attestation.

Related change: https://review.trustedfirmware.org/c/trusted-firmware-m/+/3288

Fri, Jan 31, 11:11 AM · Trusted Firmware M
tamasban triaged T665: Fix static code analyser findings in attestation as Normal priority.
Fri, Jan 31, 11:02 AM · Trusted Firmware M
KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

More hints for you:

Fri, Jan 31, 4:31 AM · Trusted Firmware M
KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Sorry for the late response and thanks for the findings. Could you share your image binary so that I could take a try? I got a board but not set up the environment yet.

Fri, Jan 31, 4:04 AM · Trusted Firmware M

Thu, Jan 30

GaborAbonyi triaged T663: Fix SRAM sanity check in common scatter file as Normal priority.
Thu, Jan 30, 4:25 PM · Trusted Firmware M
GaborAbonyi triaged T662: Add eFlash and QSPI flash driver to Musca-B1 platform as Normal priority.
Thu, Jan 30, 3:08 PM · Trusted Firmware M

Wed, Jan 29

AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

I have tried to workaround it. Current steps:

  1. Updated to the latest TFM commit.
  2. Reverted changes related to:
    1. 5248af2d7b86775364a0e131eb80ac0330bc81fb
    2. 490281df3736b11b62e25bc98d3e2c6e4e10478c
    3. 483da6447e4360c514538807275904be68395dff

After that, PSA Test application starts working.
But the regression test application still goes to the Memory fault during the first App ROT partition initialization, on the first SVC call.

  1. Switched App ROT partitions to PSA ROT, in tfm_spm_db.inc => after that regression tests are OK.
Wed, Jan 29, 9:53 AM · Trusted Firmware M

Tue, Jan 28

matetothpal closed T598: TF-M: Move debug authentication documentation as Resolved.

Change for this issue had been merged

Tue, Jan 28, 2:44 PM · Trusted Firmware M
matetothpal closed T601: TF-M Core: Unify register clear in naked functions as Resolved.

Fix for this issue had been merged

Tue, Jan 28, 2:26 PM · Trusted Firmware M

Mon, Jan 27

davidvincze closed T619: Integrate TF-M buildsystem with upstream MCUBoot as Resolved.
Mon, Jan 27, 2:06 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

FYI:
For ARMClang/Keil

  1. Functional API and TFM_LVL=1, all applications/tests are OK!!!
  2. IPC API and TFM_LVL=1 => repetitive reset.
  3. IPC API and TFM_LVL=2 => goes to the mentioned memory fault.
Mon, Jan 27, 1:55 PM · Trusted Firmware M
ronald-cron-arm raised the priority of T657: Add support for ArmClang version 6.13 from Normal to Needs Triage.
Mon, Jan 27, 12:48 PM · Trusted Firmware M
ronald-cron-arm claimed T657: Add support for ArmClang version 6.13.
Mon, Jan 27, 12:46 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Another experiment. Switching to Armasm V5 from v6 did not help, the same result - goes to the Memory fault.
So, for this moment only GCC (for PSA tests) is OK.

Mon, Jan 27, 12:15 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

BTW: At the same time the TFM Regression Tests application (using GCC) goes to infinite reset on test_app()=>tfm_secure_client_run_tests()=>psa_connect(TFM_SECURE_CLIENT_SFN_RUN_TESTS_SID,TFM_SECURE_CLIENT_SFN_RUN_TESTS_VERSION)=>tfm_ns_interface_dispatch()=>fn()=>causes reset

Mon, Jan 27, 9:33 AM · Trusted Firmware M
tamasban closed T608: Integrate QCBOR and COSE update as Resolved.
Mon, Jan 27, 9:12 AM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,

Mon, Jan 27, 9:07 AM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,

Mon, Jan 27, 8:26 AM · Trusted Firmware M
ronald-cron-arm triaged T657: Add support for ArmClang version 6.13 as Normal priority.
Mon, Jan 27, 8:02 AM · Trusted Firmware M

Sat, Jan 25

KenLSoft added a comment to T652: Stuck in tfm_nspm_thread_entry().

Looks like this was caused by the push operation, and it was caused by accessing an address out of ARM_LIB_STACK.

Sat, Jan 25, 8:31 AM · Trusted Firmware M

Fri, Jan 24

AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

After tfm_core_svc_handler() returns, the execution jumps to tfm_nspm_thread_entry().
Strange is, that during this jump PSP is changed from 0x30000FE0 to 0x30001048.

Fri, Jan 24, 2:47 PM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

So the PSP, during main() has following values:
PSP = 0x300001000 PSPLIM = 0x30000800

Fri, Jan 24, 11:57 AM · Trusted Firmware M
AndreyButokNXP added a comment to T652: Stuck in tfm_nspm_thread_entry().

Hi Ken,
Thank you by taking care about it.
Guess, the issue may be caused by the way we are using TFM. We have to compile TFM Secure in one project (instead of separate libraries). Guess, it may cause that some parts of data/code may be placed to unwanted memory sections.
I will try to analyze the generated map file.

Fri, Jan 24, 8:59 AM · Trusted Firmware M

Thu, Jan 23

AndreyButokNXP added a comment to T653: Apply '-fno-builtin' for building.
Thu, Jan 23, 9:12 AM · Trusted Firmware M

Wed, Jan 22

davidhuziji created T654: The token_size is not updated with actual token length in Library Model.
Wed, Jan 22, 3:31 PM · Trusted Firmware M
KenLSoft added a comment to T653: Apply '-fno-builtin' for building.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3217

Wed, Jan 22, 9:38 AM · Trusted Firmware M
KenLSoft changed the edit policy for T653: Apply '-fno-builtin' for building.
Wed, Jan 22, 9:37 AM · Trusted Firmware M
KenLSoft added a comment to T649: Increase client partition stack size due to usage is increased.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3216/1

Wed, Jan 22, 9:32 AM · Trusted Firmware M
kevin-peng-hao renamed T644: Build system: clean up and minor refines from Build system: clean up deprecated build configurations to Build system: clean up and minor refines.
Wed, Jan 22, 7:57 AM · Trusted Firmware M
KenLSoft created T652: Stuck in tfm_nspm_thread_entry().
Wed, Jan 22, 2:26 AM · Trusted Firmware M

Sun, Jan 19

shebuk edited the content of TF-M Videos.
Sun, Jan 19, 6:02 PM · Trusted Firmware M

Jan 17 2020

matetothpal closed T597: TF-M: Enable multiple MMIO regions per partition as Resolved.

Changes for this issue had been merged.

Jan 17 2020, 12:00 PM · Trusted Firmware M

Jan 16 2020

kevin-peng-hao triaged T650: Update document to clarify the differences between configurations under configs folder as Normal priority.
Jan 16 2020, 12:06 PM · Trusted Firmware M
KenLSoft added a comment to T649: Increase client partition stack size due to usage is increased.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3154

Jan 16 2020, 8:59 AM · Trusted Firmware M
KenLSoft created T649: Increase client partition stack size due to usage is increased.
Jan 16 2020, 8:56 AM · Trusted Firmware M

Jan 15 2020

Summer-ARM added a comment to T576: Align parameters packing method between ns caller and secure caller and implement the secure parameter packing in SPRTL.

https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/3133/

Jan 15 2020, 5:48 AM · Trusted Firmware M
Summer-ARM reopened T576: Align parameters packing method between ns caller and secure caller and implement the secure parameter packing in SPRTL as "Open".
Jan 15 2020, 5:38 AM · Trusted Firmware M
KenLSoft updated the task description for T647: Patchset tiny update/fine-tune list.
Jan 15 2020, 1:38 AM · Trusted Firmware M
KenLSoft added a comment to T647: Patchset tiny update/fine-tune list.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3130

Jan 15 2020, 1:37 AM · Trusted Firmware M
KenLSoft changed the edit policy for T647: Patchset tiny update/fine-tune list.
Jan 15 2020, 1:31 AM · Trusted Firmware M

Jan 13 2020

KenLSoft added a comment to T426: Source strcuture adjustment.

Remove log.sh/log.bat from code base:

Jan 13 2020, 9:43 AM · Trusted Firmware M
matetothpal closed T558: Tf-M: Core: tfm_memory_check should be called privileged=true in case of NS caller as Resolved.

Change for this issue had been merged

Jan 13 2020, 9:34 AM · Trusted Firmware M
davidhuziji closed T645: Fail to compile PSoC64 with GNUARM as Resolved.
Jan 13 2020, 3:10 AM · Trusted Firmware M

Jan 10 2020

davidhuziji added a comment to T645: Fail to compile PSoC64 with GNUARM.

Patch is uploaded to https://review.trustedfirmware.org/c/trusted-firmware-m/+/3107.

Jan 10 2020, 10:16 AM · Trusted Firmware M
davidhuziji added a comment to T645: Fail to compile PSoC64 with GNUARM.

The root cause is:

  1. When building SPRTL, arch type is fetched from GNUARM cmake file since SPRTL CMake file is included with add_subdirectory() instead of include().
  2. The CM0+ arch type should be "armv6s-m". However, it is set to "armv6-m" in GNUARM cmake file, which stands for CM0. CM0 doesn't support SVC. Thus the build failed.
  3. Previously, the psa_client.c and` psa_service.c` were not in SPRTL folder. When building the both files, cpu type is fetched which is correct.
Jan 10 2020, 10:15 AM · Trusted Firmware M
AlamyLiu triaged T645: Fail to compile PSoC64 with GNUARM as High priority.
Jan 10 2020, 5:57 AM · Trusted Firmware M
edison-ai closed T631: stack overlap for irq handling in library mode as Resolved.

Patch had been merged.

Jan 10 2020, 1:58 AM · Trusted Firmware M
edison-ai added a project to T549: Enhancement TF-M to support ACK test: Trusted Firmware M.
Jan 10 2020, 1:58 AM · Trusted Firmware M
edison-ai closed T435: PSA APIs alignment as Resolved.

All patches had been merged to the master branch.

Jan 10 2020, 1:57 AM · Trusted Firmware M

Jan 9 2020

kevin-peng-hao created T644: Build system: clean up and minor refines.
Jan 9 2020, 8:21 AM · Trusted Firmware M
KenLSoft added a comment to T643: Suppress the ns jumping message.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/3094

Jan 9 2020, 5:40 AM · Trusted Firmware M
KenLSoft changed the edit policy for T643: Suppress the ns jumping message.
Jan 9 2020, 5:37 AM · Trusted Firmware M

Jan 7 2020

matetothpal closed T640: Platform: Fix build error for AN539 and AN524 platforms as Resolved.

Change for this issue had been merged as a hotfix

Jan 7 2020, 3:28 PM · Trusted Firmware M
matetothpal added a comment to T640: Platform: Fix build error for AN539 and AN524 platforms.

Change for this issue: https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/3051/

Jan 7 2020, 3:02 PM · Trusted Firmware M
matetothpal claimed T640: Platform: Fix build error for AN539 and AN524 platforms.
Jan 7 2020, 3:01 PM · Trusted Firmware M
matetothpal triaged T640: Platform: Fix build error for AN539 and AN524 platforms as High priority.
Jan 7 2020, 3:01 PM · Trusted Firmware M
KenLSoft closed T203: Veneer implementation change for IPC client APIs as Resolved.
Jan 7 2020, 1:27 AM · Trusted Firmware M
KenLSoft added a comment to T203: Veneer implementation change for IPC client APIs.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/2448

Jan 7 2020, 1:27 AM · Trusted Firmware M
KenLSoft closed T635: Fix psoc build error as Resolved.
Jan 7 2020, 1:27 AM · Trusted Firmware M
KenLSoft added a comment to T635: Fix psoc build error.

https://review.trustedfirmware.org/c/trusted-firmware-m/+/2966

Jan 7 2020, 1:26 AM · Trusted Firmware M
KenLSoft closed T628: Remove 'stdout' reference in qcobr test as Resolved.
Jan 7 2020, 1:25 AM · Trusted Firmware M

Jan 6 2020

minosgalanakis added a comment to T639: Trusted Firmware-M Documentation Quality.

Patch link:

Jan 6 2020, 4:32 PM · Restricted Project, Trusted Firmware M
minosgalanakis triaged T639: Trusted Firmware-M Documentation Quality as Low priority.
Jan 6 2020, 4:21 PM · Restricted Project, Trusted Firmware M
minosgalanakis closed T527: Update TF-M readme in git as Resolved.
Jan 6 2020, 3:57 PM · Trusted Firmware M
minosgalanakis closed T528: Documents Name with TF-M prefix as Resolved.
Jan 6 2020, 3:57 PM · Trusted Firmware M
minosgalanakis closed T530: Align TrustedFirmare-M to TrustedFirmare-A documentation for presentation purposes as Resolved.
Jan 6 2020, 3:56 PM · Trusted Firmware M