Page MenuHomePhabricator
Feed Advanced Search

Advanced Search

Mar 18 2019

KenLSoft added a comment to T276: stacking issue in psa_call when FP was enabled.

Thanks.

Mar 18 2019, 1:18 AM · Trusted Firmware M

Mar 17 2019

mikisch81 added a comment to T276: stacking issue in psa_call when FP was enabled.

@KenLSoft Yes, our platform (LPC55S69 by NXP) does defined __FPU_PRESENT=1U.

Mar 17 2019, 9:17 AM · Trusted Firmware M

Mar 15 2019

KenLSoft added a comment to T276: stacking issue in psa_call when FP was enabled.

@mikisch81
A short question, has your platform defined __FPU_PRESENT=1?

Mar 15 2019, 10:31 AM · Trusted Firmware M

Mar 14 2019

Summer-ARM added a comment to T276: stacking issue in psa_call when FP was enabled.

Patches for the fixing:
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/713/

Mar 14 2019, 9:02 AM · Trusted Firmware M

Mar 13 2019

matetothpal triaged T280: Add _a and _b1 prefix to the linker config and startup files for the MUSCA_A and MUSCA_B1 targets as Low priority.
Mar 13 2019, 12:36 PM · Trusted Firmware M
orenc17 added a comment to T273: tfm_svcall_psa_get() receives 0 signal in doorbell scenario.

i can confirm that the patch is working on mbed-os with NXP LPC55S69

Mar 13 2019, 11:53 AM · Trusted Firmware M
KenLSoft added a comment to T273: tfm_svcall_psa_get() receives 0 signal in doorbell scenario.

Patches for the fixing:
https://review.trustedfirmware.org/c/trusted-firmware-m/+/712

Mar 13 2019, 10:24 AM · Trusted Firmware M
kevin-peng-hao closed T151: Remove unused platform dependencies from TF-M as Resolved.
Mar 13 2019, 10:03 AM · Trusted Firmware M
gyuri-szing added a comment to T228: Update build system to support latest cmake version..

No. T95 needs deeper investigation to check what cmake version the fix supports and if all aspects are addressed. Response files not only affect the linker but the archiver too.
There was an important bugfix for response file handling merged into cmake 3.9 so we might need to drop support for anything below 3.10.

Mar 13 2019, 8:38 AM · Trusted Firmware M
KenLSoft added a comment to T228: Update build system to support latest cmake version..

Does it mean that patches mentioned in T95 could be merged?

Mar 13 2019, 8:34 AM · Trusted Firmware M
gyuri-szing added a comment to T228: Update build system to support latest cmake version..

The response file problem is another ticket. See https://developer.trustedfirmware.org/T95

Mar 13 2019, 8:24 AM · Trusted Firmware M
KenLSoft added a comment to T228: Update build system to support latest cmake version..
Fatal error: L6002U: Could not open file @CMakeFiles/tfm_s.dir/objects1.rsp: No such file or directory
Finished: 0 information, 0 warning, 0 error and 1 fatal error messages.
make.exe[2]: *** [app/secure_fw/CMakeFiles/tfm_s.dir/build.make:167: app/secure_fw/tfm_s.axf] Error 1
make.exe[1]: *** [CMakeFiles/Makefile2:252: app/secure_fw/CMakeFiles/tfm_s.dir/all] Error 2
make.exe: *** [Makefile:118: all] Error 2
Mar 13 2019, 8:17 AM · Trusted Firmware M
gyuri-szing added a comment to T228: Update build system to support latest cmake version..

and what error do you get?

Mar 13 2019, 8:14 AM · Trusted Firmware M
KenLSoft added a comment to T228: Update build system to support latest cmake version..

Hi,
I am using ARMCLANG build on AN521, with latest master branch:

https://git.trustedfirmware.org/trusted-firmware-m.git/commit/?h=refs/heads/master&id=807fedbb8070b6d735e1c9e2103e6c1ea632fe8c
Mar 13 2019, 8:10 AM · Trusted Firmware M
KenLSoft added a comment to T276: stacking issue in psa_call when FP was enabled.

The patch is created, do the test now. Expect to publish it soon for review.
Thanks.

Mar 13 2019, 7:52 AM · Trusted Firmware M
gyuri-szing added a comment to T228: Update build system to support latest cmake version..

In my test environment I could not re-create any failure. Can you please provide more details about your case?

Mar 13 2019, 7:42 AM · Trusted Firmware M
KenLSoft added a comment to T228: Update build system to support latest cmake version..

Hi Gyuri,
I saw the document update patch, but cmake 3.10 still fails in my side. Which means the document is updated first before cmake change?
Thanks.

Mar 13 2019, 7:38 AM · Trusted Firmware M

Mar 12 2019

KenLSoft added a comment to T273: tfm_svcall_psa_get() receives 0 signal in doorbell scenario.

Can you elaborate on the root cause?

Mar 12 2019, 1:30 AM · Trusted Firmware M

Mar 11 2019

tamasban created Rollback Protection.
Mar 11 2019, 1:32 PM · Trusted Firmware M
tamasban created Trusted Boot.
Mar 11 2019, 1:32 PM · Trusted Firmware M
mikisch81 added a comment to T276: stacking issue in psa_call when FP was enabled.

We are currently pre-occupied with the 5.12 release, you can look at Mbed-os PR#10027 to see how we solved this issue.

Mar 11 2019, 12:11 PM · Trusted Firmware M
mikisch81 added a comment to T273: tfm_svcall_psa_get() receives 0 signal in doorbell scenario.

Can you elaborate on the root cause?

Mar 11 2019, 10:27 AM · Trusted Firmware M
KenLSoft added a comment to T273: tfm_svcall_psa_get() receives 0 signal in doorbell scenario.

Hi @mikisch81 ,
We have spotted this issue, and now thinking the best solution for it. Please ping me if you have any updates for this task, thanks!

Mar 11 2019, 10:22 AM · Trusted Firmware M
KenLSoft added a comment to T276: stacking issue in psa_call when FP was enabled.

Hi @mikisch81,
Since you have found the root cause, can you provide a fix for that? You can push to branch feature-ipc.
Thanks.

Mar 11 2019, 1:45 AM · Trusted Firmware M

Mar 10 2019

mikisch81 added a comment to T276: stacking issue in psa_call when FP was enabled.

Inside the svc_handler if you check LR, which holds EXC_RETURN.

Mar 10 2019, 4:27 PM · Trusted Firmware M
mikisch81 updated subscribers of T276: stacking issue in psa_call when FP was enabled.
Mar 10 2019, 11:58 AM · Trusted Firmware M
mikisch81 added a comment to T276: stacking issue in psa_call when FP was enabled.

We are experiencing this issue on the NXP LPC55S69 MCU, which is Cortex-M33-FE core.

Mar 10 2019, 11:56 AM · Trusted Firmware M
orenc17 created T276: stacking issue in psa_call when FP was enabled.
Mar 10 2019, 11:49 AM · Trusted Firmware M

Mar 7 2019

tamasban added a comment to T275: Enhance attestation test suite .

Related changes:
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/700/
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/701/
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/685/
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/702/
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/703/
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/704/
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/705/

Mar 7 2019, 1:21 PM · Trusted Firmware M
tamasban added a comment to T250: Rename useful_buf to set proper namespace.

https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/651/
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/699/

Mar 7 2019, 1:18 PM · Trusted Firmware M
tamasban added a comment to T275: Enhance attestation test suite .
Mar 7 2019, 1:17 PM · Trusted Firmware M
tamasban added a comment to T251: Fix alignment issues in QCBOR lib.

https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/644/

Mar 7 2019, 1:16 PM · Trusted Firmware M
tamasban triaged T275: Enhance attestation test suite as Normal priority.
Mar 7 2019, 1:12 PM · Trusted Firmware M

Mar 5 2019

adeaarm closed T249: Add support for using Mbed TLS 2.16.0 as Resolved.
Mar 5 2019, 10:52 AM · Trusted Firmware M
adeaarm added a comment to T249: Add support for using Mbed TLS 2.16.0.

Fix for this is provided with https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/635/

Mar 5 2019, 10:52 AM · Trusted Firmware M
adeaarm closed T262: Build: Fix the location of some exported headers with make install as Resolved.
Mar 5 2019, 10:50 AM · Trusted Firmware M
edison-ai closed T264: psa_wait may return 0 on PSA_BLOCK as Resolved.
Mar 5 2019, 2:04 AM · Trusted Firmware M
edison-ai added a comment to T264: psa_wait may return 0 on PSA_BLOCK.

Thanks.

Mar 5 2019, 2:03 AM · Trusted Firmware M

Mar 4 2019

hug-dev added a comment to T274: Improve code quality.

Concerned patches are:

Mar 4 2019, 4:12 PM · Trusted Firmware M
hug-dev triaged T274: Improve code quality as Low priority.
Mar 4 2019, 3:51 PM · Trusted Firmware M
mikisch81 added a comment to T264: psa_wait may return 0 on PSA_BLOCK.

Opened https://developer.trustedfirmware.org/T273

Mar 4 2019, 2:02 PM · Trusted Firmware M
mikisch81 created T273: tfm_svcall_psa_get() receives 0 signal in doorbell scenario.
Mar 4 2019, 2:00 PM · Trusted Firmware M
matetothpal added a comment to T32: Implement secure IRQ handling .

The following changes are further created for this issue:

Mar 4 2019, 9:07 AM · Trusted Firmware M
kevin-peng-hao added a comment to T272: Run code from eFlash instead of QSPI in MUSCA_B1.

Patches for this ticket: https://review.trustedfirmware.org/c/trusted-firmware-m/+/669

Mar 4 2019, 2:08 AM · Trusted Firmware M
kevin-peng-hao triaged T272: Run code from eFlash instead of QSPI in MUSCA_B1 as Low priority.
Mar 4 2019, 2:07 AM · Trusted Firmware M
edison-ai added a comment to T264: psa_wait may return 0 on PSA_BLOCK.

Could you create a new Task issue for it?

Mar 4 2019, 1:40 AM · Trusted Firmware M

Mar 3 2019

mikisch81 added a comment to T264: psa_wait may return 0 on PSA_BLOCK.

Hi all,

Mar 3 2019, 2:21 PM · Trusted Firmware M

Mar 1 2019

matetothpal triaged T271: Add positive core test suite to configIPC as Normal priority.
Mar 1 2019, 1:20 PM · Trusted Firmware M
matetothpal triaged T270: Fix interactive core tests as Normal priority.
Mar 1 2019, 12:48 PM · Trusted Firmware M
jf549 closed T148: Fix FPU and DSP defs in system_core_musca.h for Musca-B1 as Resolved.

Issue resolved by https://developer.trustedfirmware.org/T192

Mar 1 2019, 11:00 AM · Trusted Firmware M
edison-ai added a comment to T264: psa_wait may return 0 on PSA_BLOCK.

So there are two issues:

  1. The first issue should have been fixed in the above two patches.
  2. The second issue had been fixed in this patch: https://review.trustedfirmware.org/c/trusted-firmware-m/+/612. This patch had been merged into "feature-ipc" branch on Feb 12. So, please update your to align with the newest code version.
Mar 1 2019, 9:05 AM · Trusted Firmware M

Feb 28 2019

orenc17 added a comment to T264: psa_wait may return 0 on PSA_BLOCK.

We checked both patches, and they do not seem to fix the issue

Feb 28 2019, 1:59 PM · Trusted Firmware M
gyuri-szing added a comment to T228: Update build system to support latest cmake version..

After extensive testing no blocking issues could be identified and this effort turned to be a documentation update. See https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/661/
All mentioned cmake versions work fine win the build-system..

Feb 28 2019, 6:27 AM · Trusted Firmware M
edison-ai closed T263: set_rhandle durring disconnect cause panic as Resolved.
Feb 28 2019, 1:49 AM · Trusted Firmware M
edison-ai closed T216: psa_set_rhandle() during PSA_IPC_CONNECT as Resolved.
Feb 28 2019, 1:47 AM · Trusted Firmware M

Feb 27 2019

edison-ai added a comment to T264: psa_wait may return 0 on PSA_BLOCK.

Add another patch to fix this problem in GCC: https://review.trustedfirmware.org/c/trusted-firmware-m/+/666/1

Feb 27 2019, 9:10 AM · Trusted Firmware M
edison-ai added a comment to T264: psa_wait may return 0 on PSA_BLOCK.

Fix it on this patch: https://review.trustedfirmware.org/c/trusted-firmware-m/+/662/1. Please check it on your board.

Feb 27 2019, 7:37 AM · Trusted Firmware M

Feb 26 2019

kevin-peng-hao added a comment to T192: Sync TF-M platform support with internal platform repos.

The ticket is addressed by:
https://review.trustedfirmware.org/c/trusted-firmware-m/+/655
https://review.trustedfirmware.org/c/trusted-firmware-m/+/656

Feb 26 2019, 2:08 AM · Trusted Firmware M

Feb 25 2019

akiannillo added a watcher for Trusted Firmware M: akiannillo.
Feb 25 2019, 1:20 PM
wmnt updated the task description for T151: Remove unused platform dependencies from TF-M.
Feb 25 2019, 9:44 AM · Trusted Firmware M
mikisch81 added a comment to T264: psa_wait may return 0 on PSA_BLOCK.
Feb 25 2019, 7:39 AM · Trusted Firmware M

Feb 24 2019

orenc17 added a comment to T264: psa_wait may return 0 on PSA_BLOCK.

@KenLSoft

  1. from my latest debug session i found that psa_wait returns the correct signals, but by the time psa_get tries to handle them the signals shut down and then psa_get will go into panic
  2. client sends a string to SP1, SP1 doubles the string and calls SP2, SP2 should reverse the string and return it to SP1 which will return it to client.
  3. i dont know
Feb 24 2019, 6:43 PM · Trusted Firmware M
mikisch81 added a comment to T263: set_rhandle durring disconnect cause panic.

I can verify that https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/653/ works on our code.

Feb 24 2019, 7:55 AM · Trusted Firmware M

Feb 22 2019

tamasban closed T258: Fix memory unaligned access issue as Resolved.
Feb 22 2019, 2:45 PM · Trusted Firmware M
edison-ai added a comment to T263: set_rhandle durring disconnect cause panic.

Hello, this bug had been fixed in this patch: https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/653/

Feb 22 2019, 7:32 AM · Trusted Firmware M

Feb 21 2019

mikisch81 updated the task description for T224: tfm_memory_check is inaccurate.
Feb 21 2019, 3:27 PM · Trusted Firmware M
KenLSoft added a comment to T264: psa_wait may return 0 on PSA_BLOCK.

Hi Oren,
I read the test code and got some questions:

  1. There are two partitions involved, can you tell which psa_wait returned wrong signal code and show me the debug message (I noticed SP2 would print out something if psa_wait returned error message)? It would be nice if you can tell the line number in the source you shared.
  2. It looks like the case is: client -> SP1 -> SP2, three roles get involved in testing, is that true? Or there are more roles?
  3. I can not find TF-M adapter layer in cloned source of mbed-os, is the code showed as same as the working version on your local?
Feb 21 2019, 2:22 PM · Trusted Firmware M
KenLSoft added a comment to T263: set_rhandle durring disconnect cause panic.

Hi Oren,
For PSA related ticket please add me as subscriber. Thanks.

Feb 21 2019, 2:12 PM · Trusted Firmware M
mmorenobarm added a watcher for Trusted Firmware M: mmorenobarm.
Feb 21 2019, 1:28 PM
adeaarm added a watcher for Trusted Firmware M: adeaarm.
Feb 21 2019, 11:18 AM
wmnt edited the content of Non-secure Client Management.
Feb 21 2019, 10:42 AM · Trusted Firmware M
wmnt edited the content of Non-secure Client Management.
Feb 21 2019, 10:41 AM · Trusted Firmware M
orenc17 added a project to T264: psa_wait may return 0 on PSA_BLOCK: Trusted Firmware M.
Feb 21 2019, 10:05 AM · Trusted Firmware M
orenc17 created T263: set_rhandle durring disconnect cause panic.
Feb 21 2019, 9:43 AM · Trusted Firmware M

Feb 20 2019

adeaarm added a comment to T262: Build: Fix the location of some exported headers with make install.

The change which fixes this issue is available here: https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/650/

Feb 20 2019, 3:28 PM · Trusted Firmware M
adeaarm triaged T262: Build: Fix the location of some exported headers with make install as Low priority.
Feb 20 2019, 3:27 PM · Trusted Firmware M

Feb 19 2019

ashutoshksingh closed T242: Update contribution guide and maintainer list as Resolved.
Feb 19 2019, 5:18 PM · Trusted Firmware M
tamasban added a comment to T258: Fix memory unaligned access issue.

Related changes:
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/647/
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/646/

Feb 19 2019, 4:29 PM · Trusted Firmware M
tamasban triaged T258: Fix memory unaligned access issue as High priority.
Feb 19 2019, 1:05 PM · Trusted Firmware M
tamasban closed T171: Handling of initial attestation key as Resolved.
Feb 19 2019, 8:40 AM · Trusted Firmware M
tamasban closed T168: Refactor shared data TLV entry header as Resolved.
Feb 19 2019, 8:40 AM · Trusted Firmware M
tamasban closed T170: Define attestation service platform API as Resolved.
Feb 19 2019, 8:40 AM · Trusted Firmware M
tamasban closed T176: Attestation test cases names should be unique as Resolved.
Feb 19 2019, 8:39 AM · Trusted Firmware M
tamasban closed T178: Clean-up attestation header as Resolved.
Feb 19 2019, 8:39 AM · Trusted Firmware M
tamasban closed T182: Replace attestation token encoding to CBOR/COSE as Resolved.
Feb 19 2019, 8:39 AM · Trusted Firmware M
tamasban closed T169: Add missing claims to attestation token as Resolved.
Feb 19 2019, 8:38 AM · Trusted Firmware M
tamasban closed T173: Fix include patch in attestation service as Resolved.
Feb 19 2019, 8:38 AM · Trusted Firmware M
tamasban closed T167: Extend attestation API with get_token_size() as Resolved.
Feb 19 2019, 8:38 AM · Trusted Firmware M
tamasban closed T172: Rename device ID to instance ID as Resolved.
Feb 19 2019, 8:37 AM · Trusted Firmware M
tamasban closed T177: Attestation service input verification as Resolved.
Feb 19 2019, 8:37 AM · Trusted Firmware M
tamasban closed T217: Decouple attestation from TF-M SPM as Resolved.
Feb 19 2019, 8:37 AM · Trusted Firmware M
tamasban added a comment to T217: Decouple attestation from TF-M SPM.

Related change:
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/552/

Feb 19 2019, 8:37 AM · Trusted Firmware M
tamasban closed T237: Updated attestation service integration guide as Resolved.
Feb 19 2019, 8:36 AM · Trusted Firmware M
tamasban closed T247: Fix boot data handling as Resolved.
Feb 19 2019, 8:36 AM · Trusted Firmware M

Feb 18 2019

mmorenobarm edited the content of Profiling.
Feb 18 2019, 4:29 PM · Trusted Firmware M
tamasban added a comment to T182: Replace attestation token encoding to CBOR/COSE.

Update the API version number to 1.0-beta:
https://review.trustedfirmware.org/#/c/trusted-firmware-m/+/641/

Feb 18 2019, 11:33 AM · Trusted Firmware M
matetothpal closed T226: Configure Isolation for partitions with SPM_PART_FLAG_IPC flag as Resolved.

The change for this issue has been merged.

Feb 18 2019, 8:42 AM · Trusted Firmware M
matetothpal closed T225: In case of more than one thread of the same priority, a running thread might not get scheduled as Resolved.

The change for this issue have been merged.

Feb 18 2019, 8:42 AM · Trusted Firmware M
KenLSoft added a comment to T226: Configure Isolation for partitions with SPM_PART_FLAG_IPC flag.

Validated and merged. Please help to close this ticket.

Feb 18 2019, 2:10 AM · Trusted Firmware M
KenLSoft added a comment to T225: In case of more than one thread of the same priority, a running thread might not get scheduled.

Validated and merged.
Can you help to close this item? Thanks.

Feb 18 2019, 2:08 AM · Trusted Firmware M